From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:42625 "EHLO lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408AbdEHKqW (ORCPT ); Mon, 8 May 2017 06:46:22 -0400 Subject: Re: [PATCH 8/8] omapdrm: hdmi4: hook up the HDMI CEC support To: Tomi Valkeinen , linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Hans Verkuil , Peter Ujfalusi References: <20170414102512.48834-1-hverkuil@xs4all.nl> <20170414102512.48834-9-hverkuil@xs4all.nl> <144b95df-8eb2-1307-1157-2eb2572c51aa@xs4all.nl> <7d3ab159-9284-bcc8-80f0-cbc621769203@ti.com> From: Hans Verkuil Message-ID: Date: Mon, 8 May 2017 12:46:14 +0200 MIME-Version: 1.0 In-Reply-To: <7d3ab159-9284-bcc8-80f0-cbc621769203@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 05/08/2017 12:26 PM, Tomi Valkeinen wrote: > On 06/05/17 14:58, Hans Verkuil wrote: > >> My assumption was that hdmi_display_disable() was called when the hotplug would go >> away. But I discovered that that isn't the case, or at least not when X is running. >> It seems that the actual HPD check is done in hdmic_detect() in >> omapdrm/displays/connector-hdmi.c. > > For some HW it's done there (in the case there's no IP handling the > HPD), but in some cases it's done in tpd12s015 driver (e.g. pandaboard), > and in some cases it also could be done in the hdmi driver (if the HPD > is handled by the HDMI IP, but at the moment we don't have this case > supported in the SW). > >> But there I have no access to hdmi.core (needed for the hdmi4_cec_set_phys_addr() call). >> >> Any idea how to solve this? I am not all that familiar with drm, let alone omapdrm, >> so if you can point me in the right direction, then that would be very helpful. > > Hmm, indeed, looks the the output is kept enabled even if HPD drops and > the connector status is changed to disconnected. > > I don't have a very good solution... I think we have to add a function > to omapdss_hdmi_ops, which the connector-hdmi and tpd12s015 drivers can > call when they detect a HPD change. That call would go to the HDMI IP > driver. Right, I was thinking the same, I just wasn't sure if that was the correct solution. > Peter is about to send hotplug-interrupt-handling series, I think the > HPD function work should be done on top of that, as otherwise it'll just > conflict horribly. OK, I'll do that. I'll get CEC supported on the omap4 eventually! :-) Regards, Hans