From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1etaew-000287-GQ for qemu-devel@nongnu.org; Wed, 07 Mar 2018 10:07:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1etaet-0005vj-5e for qemu-devel@nongnu.org; Wed, 07 Mar 2018 10:07:14 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52240 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1etaet-0005v0-0H for qemu-devel@nongnu.org; Wed, 07 Mar 2018 10:07:11 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9D2998182D0C for ; Wed, 7 Mar 2018 15:07:10 +0000 (UTC) References: <20180306053320.15401-1-peterx@redhat.com> <20180306053320.15401-10-peterx@redhat.com> <20180307123650.GD20201@redhat.com> <20180307124038.GE20201@redhat.com> From: Paolo Bonzini Message-ID: Date: Wed, 7 Mar 2018 16:06:53 +0100 MIME-Version: 1.0 In-Reply-To: <20180307124038.GE20201@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 9/9] chardev: tcp: postpone TLS work until machine done List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "=?UTF-8?Q?Daniel_P._Berrang=c3=a9?=" , Peter Xu Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= On 07/03/2018 13:40, Daniel P. Berrang=C3=A9 wrote: > On Wed, Mar 07, 2018 at 12:36:50PM +0000, Daniel P. Berrang=C3=A9 wrote= : >> On Tue, Mar 06, 2018 at 01:33:20PM +0800, Peter Xu wrote: >>> TLS handshake may create background GSource tasks, while we won't kno= w >>> the correct GMainContext until the whole chardev (including frontend) >>> inited. Let's postpone the initial TLS handshake until machine done. >>> >>> For dynamically created tcp chardev, we don't postpone that by checki= ng >>> the init_machine_done variable. >> >> Not sure I see the need for this one - we've already postponed the >> acceptance of a client in the patch 7. >=20 > Opps, meant to remove this comment, in favour of the later comment - ig= nore > this bit. Since time is ticking for soft freeze, I'll queue the series without this patch. Paolo >> >>> >>> Signed-off-by: Peter Xu >>> --- >>> chardev/char-socket.c | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/chardev/char-socket.c b/chardev/char-socket.c >>> index bd40864f87..997c70dd7d 100644 >>> --- a/chardev/char-socket.c >>> +++ b/chardev/char-socket.c >>> @@ -31,6 +31,7 @@ >>> #include "qemu/option.h" >>> #include "qapi/error.h" >>> #include "qapi/clone-visitor.h" >>> +#include "sysemu/sysemu.h" >>> =20 >>> #include "chardev/char-io.h" >>> =20 >>> @@ -722,6 +723,11 @@ static void tcp_chr_tls_init(Chardev *chr) >>> Error *err =3D NULL; >>> gchar *name; >>> =20 >>> + if (!machine_init_done) { >>> + /* This will be postponed to machine_done notifier */ >>> + return; >>> + } >>> + >>> if (s->is_listen) { >>> tioc =3D qio_channel_tls_new_server( >>> s->ioc, s->tls_creds, >>> @@ -1145,6 +1151,10 @@ static int tcp_chr_machine_done_hook(Chardev *= chr) >>> tcp_chr_connect_async(chr); >>> } >>> =20 >>> + if (s->tls_creds) { >>> + tcp_chr_tls_init(chr); >>> + } >> >> This looks questionable - AFAICT, there's no guarantee we have any >> client connection active when the machine dnoe hook runs. Only if >> the chardev is set in client mode, and reconnect_time is *not* set, >> but this seems to be run unconditionally. >> >> >> Regards, >> Daniel >> --=20 >> |: https://berrange.com -o- https://www.flickr.com/photos/dber= range :| >> |: https://libvirt.org -o- https://fstop138.berrang= e.com :| >> |: https://entangle-photo.org -o- https://www.instagram.com/dber= range :| >> >=20 > Regards, > Daniel >=20