From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D6F946E3B2 for ; Mon, 26 Jul 2021 04:43:13 +0000 (UTC) References: <20210705125617.4631-1-bhanuprakash.modem@intel.com> <20210705125617.4631-4-bhanuprakash.modem@intel.com> From: Karthik B S Message-ID: Date: Mon, 26 Jul 2021 10:12:54 +0530 In-Reply-To: <20210705125617.4631-4-bhanuprakash.modem@intel.com> Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 3/3] tests/intel-ci: Remove hang tests from pre-merge blacklist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Bhanuprakash Modem , igt-dev@lists.freedesktop.org, anshuman.gupta@intel.com List-ID: On 7/5/2021 6:26 PM, Bhanuprakash Modem wrote: > Remove kms_(busy|flip)-*hang* tests from pre-merge blacklist > > Signed-off-by: Bhanuprakash Modem Please add the details of how much improvement in execution time we're seeing with this patch. I'm assuming it should be ~50%(on platforms with 4 pipes), since we're restricting the execution to 2 pipes. But will be good to have this detail in the commit message. With this added, the patch looks good to me. Reviewed-by: Karthik B S > --- > tests/intel-ci/blacklist-pre-merge.txt | 39 -------------------------- > 1 file changed, 39 deletions(-) > > diff --git a/tests/intel-ci/blacklist-pre-merge.txt b/tests/intel-ci/blacklist-pre-merge.txt > index 115474d987..dc6095ea1b 100644 > --- a/tests/intel-ci/blacklist-pre-merge.txt > +++ b/tests/intel-ci/blacklist-pre-merge.txt > @@ -71,45 +71,6 @@ igt@gem_pwrite@big-.* > igt@gem_exec_alignment@.* > > > -############################################################################### > -# These 4 tests are covering an edge case which should never be hit by users > -# unless we already are in a bad situation, yet they are responsible for a > -# significant portion of our execution time: > -# > -# - shard-skl: 2% (~5 minutes) > -# - shard-kbl: 4% (~5 minutes) > -# - shard-apl: 2.7% (~5 minutes) > -# - shard-glk: 4.5% (~10 minutes) > -# - shard-icl: 2.5% (~5 minutes) > -# - shard-tgl: 3.5% (~7 minutes) > -# > -# Issue: https://gitlab.freedesktop.org/drm/intel/issues/1284 > -# > -# Data acquired on 2020-02-20 by Martin Peres > -############################################################################### > -igt@kms_flip@flip-vs-modeset-vs-hang(-interruptible)? > -igt@kms_flip@flip-vs-panning-vs-hang(-interruptible)? > - > - > -############################################################################### > -# These 28 tests are covering an edge case which should never be hit by users > -# unless we already are in a bad situation, yet they are responsible for a > -# significant portion of our execution time: > -# > -# - shard-skl: 1.7% (~4 minutes) > -# - shard-kbl: 2.8% (~3.5 minutes) > -# - shard-apl: 2.2% (~4 minutes) > -# - shard-glk: 1.8% (~4 minutes) > -# - shard-icl: 1.9% (~4 minutes) > -# - shard-tgl: 2.8% (~5.5 minutes) > -# > -# Issue: https://gitlab.freedesktop.org/drm/intel/issues/1285 > -# > -# Data acquired on 2020-02-20 by Martin Peres > -############################################################################### > -igt@kms_busy@.*hang.* > - > - > ############################################################################### > # This test is reading one file at a time while being suspended, which makes > # testing extremelly slow. This is a developer-only feature which is also used _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev