From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751978AbdBUKwp convert rfc822-to-8bit (ORCPT ); Tue, 21 Feb 2017 05:52:45 -0500 Received: from ste-pvt-msa2.bahnhof.se ([213.80.101.71]:32518 "EHLO ste-ftg-msa2.bahnhof.se" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751266AbdBUKwh (ORCPT ); Tue, 21 Feb 2017 05:52:37 -0500 Subject: Re: DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes) To: David Airlie References: <20161028081050.1042-1-daniel.vetter@ffwll.ch> <07f5e4a3-f7ef-df5e-d8cc-3759d828719d@shipmail.org> <44292f61-80ce-bf39-8a22-8ac685586af0@shipmail.org> <1176275231.24491633.1487655299858.JavaMail.zimbra@redhat.com> Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Daniel Vetter , linux-kernel@vger.kernel.org From: Thomas Hellstrom Message-ID: Date: Tue, 21 Feb 2017 11:52:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1176275231.24491633.1487655299858.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/21/2017 06:34 AM, David Airlie wrote: >> No. >> >> IMO Not fixing this immediately through stable is out of the question. >> The deal is that we don't break userspace. >> Having said that, I'm not against a long term vmwgfx-only solution. But >> let's fix this now. >> >> Admittedly we missed testing this but you got to understand that not all >> developer teams have a multitude of >> developers (we have on average one for the whole linux graphics driver >> stack except GL), and the bug >> doesn't show up for QE on regression testing unless they run >> gnome-sheel/Wayland which they currently don't, and I guess they've been >> focused on the fb2 regression. >> >> It's no secret that we've been using the control nodes for some time. >> The CONTROL_ALLOW is present in the >> driver private ioctls and the commit has been there since 2016. >> >> The user-space code has been present in vmware-tools also since that >> commit and due to the long release cycles of >> open-vm-tools the open-vm-tools version was just about to be released. >> It's necessary for non-xorg > can you send a revert against drm-next? I'm not sure how clean it will be. > > there might be an intermediate step. > > Then can we port vmtools of this behaviour, not even sure what it is doing. > > Dave. So after a quick investigation of the impact it looks like the daemon patch was pulled out of the Fedora open-vm-tools update in time. This limits the impact to within VMware where we can update the daemon code and rerun the test cycle. I've posted a patch that makes it possible for us to use render-nodes instead of control nodes. /Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Hellstrom Subject: Re: DRM_CONTROL node breakage (Re: [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes) Date: Tue, 21 Feb 2017 11:52:28 +0100 Message-ID: References: <20161028081050.1042-1-daniel.vetter@ffwll.ch> <07f5e4a3-f7ef-df5e-d8cc-3759d828719d@shipmail.org> <44292f61-80ce-bf39-8a22-8ac685586af0@shipmail.org> <1176275231.24491633.1487655299858.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1176275231.24491633.1487655299858.JavaMail.zimbra@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: David Airlie Cc: Daniel Vetter , Intel Graphics Development , linux-kernel@vger.kernel.org, DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gMDIvMjEvMjAxNyAwNjozNCBBTSwgRGF2aWQgQWlybGllIHdyb3RlOgo+PiBOby4KPj4KPj4g SU1PIE5vdCBmaXhpbmcgdGhpcyBpbW1lZGlhdGVseSB0aHJvdWdoIHN0YWJsZSBpcyBvdXQgb2Yg dGhlIHF1ZXN0aW9uLgo+PiBUaGUgZGVhbCBpcyB0aGF0IHdlIGRvbid0IGJyZWFrIHVzZXJzcGFj ZS4KPj4gSGF2aW5nIHNhaWQgdGhhdCwgSSdtIG5vdCBhZ2FpbnN0IGEgbG9uZyB0ZXJtIHZtd2dm eC1vbmx5IHNvbHV0aW9uLiBCdXQKPj4gbGV0J3MgZml4IHRoaXMgbm93Lgo+Pgo+PiBBZG1pdHRl ZGx5IHdlIG1pc3NlZCB0ZXN0aW5nIHRoaXMgYnV0IHlvdSBnb3QgdG8gdW5kZXJzdGFuZCB0aGF0 IG5vdCBhbGwKPj4gZGV2ZWxvcGVyIHRlYW1zIGhhdmUgYSBtdWx0aXR1ZGUgb2YKPj4gZGV2ZWxv cGVycyAod2UgaGF2ZSBvbiBhdmVyYWdlIG9uZSBmb3IgdGhlIHdob2xlIGxpbnV4IGdyYXBoaWNz IGRyaXZlcgo+PiBzdGFjayBleGNlcHQgR0wpLCBhbmQgdGhlIGJ1Zwo+PiBkb2Vzbid0IHNob3cg dXAgZm9yIFFFIG9uIHJlZ3Jlc3Npb24gdGVzdGluZyB1bmxlc3MgdGhleSBydW4KPj4gZ25vbWUt c2hlZWwvV2F5bGFuZCB3aGljaCB0aGV5IGN1cnJlbnRseSBkb24ndCwgYW5kIEkgZ3Vlc3MgdGhl eSd2ZSBiZWVuCj4+IGZvY3VzZWQgb24gdGhlIGZiMiByZWdyZXNzaW9uLgo+Pgo+PiBJdCdzIG5v IHNlY3JldCB0aGF0IHdlJ3ZlIGJlZW4gdXNpbmcgdGhlIGNvbnRyb2wgbm9kZXMgZm9yIHNvbWUg dGltZS4KPj4gVGhlIENPTlRST0xfQUxMT1cgaXMgcHJlc2VudCBpbiB0aGUKPj4gZHJpdmVyIHBy aXZhdGUgaW9jdGxzIGFuZCB0aGUgY29tbWl0IGhhcyBiZWVuIHRoZXJlIHNpbmNlIDIwMTYuCj4+ Cj4+IFRoZSB1c2VyLXNwYWNlIGNvZGUgaGFzIGJlZW4gcHJlc2VudCBpbiB2bXdhcmUtdG9vbHMg YWxzbyBzaW5jZSB0aGF0Cj4+IGNvbW1pdCBhbmQgZHVlIHRvIHRoZSBsb25nIHJlbGVhc2UgY3lj bGVzIG9mCj4+IG9wZW4tdm0tdG9vbHMgdGhlIG9wZW4tdm0tdG9vbHMgdmVyc2lvbiB3YXMganVz dCBhYm91dCB0byBiZSByZWxlYXNlZC4KPj4gSXQncyBuZWNlc3NhcnkgZm9yIG5vbi14b3JnCj4g Y2FuIHlvdSBzZW5kIGEgcmV2ZXJ0IGFnYWluc3QgZHJtLW5leHQ/IEknbSBub3Qgc3VyZSBob3cg Y2xlYW4gaXQgd2lsbCBiZS4KPgo+IHRoZXJlIG1pZ2h0IGJlIGFuIGludGVybWVkaWF0ZSBzdGVw Lgo+Cj4gVGhlbiBjYW4gd2UgcG9ydCB2bXRvb2xzIG9mIHRoaXMgYmVoYXZpb3VyLCBub3QgZXZl biBzdXJlIHdoYXQgaXQgaXMgZG9pbmcuCj4KPiBEYXZlLgoKU28gYWZ0ZXIgYSBxdWljayBpbnZl c3RpZ2F0aW9uIG9mIHRoZSBpbXBhY3QgaXQgbG9va3MgbGlrZSB0aGUgZGFlbW9uCnBhdGNoIHdh cyBwdWxsZWQgb3V0IG9mIHRoZSBGZWRvcmEgb3Blbi12bS10b29scyB1cGRhdGUgaW4gdGltZS4g VGhpcwpsaW1pdHMgdGhlIGltcGFjdCB0byB3aXRoaW4gVk13YXJlIHdoZXJlIHdlIGNhbiB1cGRh dGUgdGhlIGRhZW1vbiBjb2RlCmFuZCByZXJ1biB0aGUgdGVzdCBjeWNsZS4gSSd2ZSBwb3N0ZWQg YSBwYXRjaCB0aGF0IG1ha2VzIGl0IHBvc3NpYmxlIGZvcgp1cyB0byB1c2UgcmVuZGVyLW5vZGVz IGluc3RlYWQgb2YgY29udHJvbCBub2Rlcy4KCi9UaG9tYXMKCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==