From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88307C6778D for ; Tue, 11 Sep 2018 17:29:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B2A420880 for ; Tue, 11 Sep 2018 17:29:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B2A420880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728217AbeIKW3e (ORCPT ); Tue, 11 Sep 2018 18:29:34 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47184 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727419AbeIKW3e (ORCPT ); Tue, 11 Sep 2018 18:29:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A86CF7A9; Tue, 11 Sep 2018 10:29:14 -0700 (PDT) Received: from [10.37.8.51] (unknown [10.37.8.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 02A5D3F703; Tue, 11 Sep 2018 10:29:11 -0700 (PDT) Subject: Re: [PATCH 11/11] dts: tc2: Update coresight bindings for hardware ports To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robh@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org, mathieu.poirier@linaro.org, arm@kernel.org, Liviu Dudau , Lorenzo Pieralisi References: <1536661032-30481-1-git-send-email-suzuki.poulose@arm.com> <1536661032-30481-12-git-send-email-suzuki.poulose@arm.com> <20180911170113.GA27663@e107155-lin> <9cf11b0c-b5c0-b39d-8c57-ad7aea5c6212@arm.com> From: Suzuki K Poulose Message-ID: Date: Tue, 11 Sep 2018 18:30:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <9cf11b0c-b5c0-b39d-8c57-ad7aea5c6212@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2018 06:23 PM, Sudeep Holla wrote: > > > On 11/09/18 18:15, Suzuki K Poulose wrote: >> On 09/11/2018 06:01 PM, Sudeep Holla wrote: >>> On Tue, Sep 11, 2018 at 11:17:12AM +0100, Suzuki K Poulose wrote: >>>> Switch to the new coresight bindings >>>> >>> >>> I still see the below warnings: >>> >>> vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address): >>>     /replicator/in-ports: graph node has single child node 'port@0', >>>     #address-cells/#size-cells are not necessary >>> vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address): >>>     /funnel@20040000/out-ports: graph node has single child node >>> 'port@0', >>>     #address-cells/#size-cells are not necessary >>> >>> I need the below patch to fix them, let me know if it looks OK, I can >>> amend and apply. >> >> Thanks for reporting. I purposefully added the "address-cells" and >> followed the format everywhere in the series thinking that, that is >> indeed the formal way of doing it, rather than having implicit port >> numbers. I can send an updated series fixing it everywhere. >> > No need to post the update for TC2 unless it's different from what I > have proposed. > Yes, the changes look good. Thanks Sudeep. I will drop this patch from the next version then. Btw, my kernel build didn't trigger those warnings. Thanks Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 From: suzuki.poulose@arm.com (Suzuki K Poulose) Date: Tue, 11 Sep 2018 18:30:06 +0100 Subject: [PATCH 11/11] dts: tc2: Update coresight bindings for hardware ports In-Reply-To: <9cf11b0c-b5c0-b39d-8c57-ad7aea5c6212@arm.com> References: <1536661032-30481-1-git-send-email-suzuki.poulose@arm.com> <1536661032-30481-12-git-send-email-suzuki.poulose@arm.com> <20180911170113.GA27663@e107155-lin> <9cf11b0c-b5c0-b39d-8c57-ad7aea5c6212@arm.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/11/2018 06:23 PM, Sudeep Holla wrote: > > > On 11/09/18 18:15, Suzuki K Poulose wrote: >> On 09/11/2018 06:01 PM, Sudeep Holla wrote: >>> On Tue, Sep 11, 2018 at 11:17:12AM +0100, Suzuki K Poulose wrote: >>>> Switch to the new coresight bindings >>>> >>> >>> I still see the below warnings: >>> >>> vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address): >>> ????/replicator/in-ports: graph node has single child node 'port at 0', >>> ????#address-cells/#size-cells are not necessary >>> vexpress-v2p-ca15_a7.dtb: Warning (graph_child_address): >>> ????/funnel at 20040000/out-ports: graph node has single child node >>> 'port at 0', >>> ????#address-cells/#size-cells are not necessary >>> >>> I need the below patch to fix them, let me know if it looks OK, I can >>> amend and apply. >> >> Thanks for reporting. I purposefully added the "address-cells" and >> followed the format everywhere in the series thinking that, that is >> indeed the formal way of doing it, rather than having implicit port >> numbers. I can send an updated series fixing it everywhere. >> > No need to post the update for TC2 unless it's different from what I > have proposed. > Yes, the changes look good. Thanks Sudeep. I will drop this patch from the next version then. Btw, my kernel build didn't trigger those warnings. Thanks Suzuki