All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Michael Schmitz <schmitzmic@gmail.com>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>
Cc: Debian m68k <debian-68k@lists.debian.org>, Helge Deller <deller@gmx.de>
Subject: Re: Seccomp support for linux-m68k
Date: Sat, 25 Jul 2020 20:54:43 +0200	[thread overview]
Message-ID: <b0d75d13-e241-43a9-30a7-46330e68cf30@physik.fu-berlin.de> (raw)
In-Reply-To: <06f3ccd0-3567-5905-eea0-80fb18206648@gmail.com>

On 7/25/20 11:29 AM, Michael Schmitz wrote:
> Looking at your SH patch, I see no changes to check for syscall numbers, just a check of the syscall_trace_enter() return code added? Is that all that's needed for m68k as well?

From my understanding, you basically check whether the syscall number is -1
and if that's the case, you just skip to ret_from_syscall. At least that's what
we're doing on SH in entry.S.

The rest of the handling is done in C code in kernel/ptrace.c in do_syscall_trace_enter:

if (secure_computing() == -1)
		return -1;


> What return code would we need to set on returning from an aborted syscall?
> (Without setting a specific one, -ENOSYS will be used by default.)

If we're talking about syscall_trace_enter(), it should be -1.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

  parent reply	other threads:[~2020-07-25 18:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-20  8:46 Seccomp support for linux-m68k John Paul Adrian Glaubitz
2020-03-20 22:49 ` Finn Thain
2020-03-20 22:59   ` John Paul Adrian Glaubitz
2020-03-20 23:08     ` Finn Thain
2020-03-21 22:18     ` Michael Schmitz
2020-03-21 22:48       ` John Paul Adrian Glaubitz
2020-03-21 23:01         ` John Paul Adrian Glaubitz
2020-07-21 15:13 ` John Paul Adrian Glaubitz
2020-07-25  9:29   ` Michael Schmitz
2020-07-25 11:55     ` Andreas Schwab
2020-07-26  1:23       ` Michael Schmitz
2020-07-26 11:03         ` Andreas Schwab
2020-07-26 21:02           ` Michael Schmitz
2020-07-26 21:08             ` Andreas Schwab
2020-07-26 21:39               ` Michael Schmitz
2020-07-27  6:35                 ` Andreas Schwab
2020-07-25 18:54     ` John Paul Adrian Glaubitz [this message]
2020-07-26  1:34       ` Michael Schmitz
2020-07-26  7:13         ` Michael Schmitz
2020-07-26 11:05         ` Andreas Schwab
2020-07-26 20:46           ` Michael Schmitz
2020-07-26 21:10             ` Andreas Schwab
2020-07-26 22:40               ` Michael Schmitz
2020-07-25 22:48     ` John Paul Adrian Glaubitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0d75d13-e241-43a9-30a7-46330e68cf30@physik.fu-berlin.de \
    --to=glaubitz@physik.fu-berlin.de \
    --cc=debian-68k@lists.debian.org \
    --cc=deller@gmx.de \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.