From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace Date: Thu, 18 Apr 2019 19:12:13 +0200 Message-ID: References: <20190417205439.17685-1-jacek.anaszewski@gmail.com> <20190417205439.17685-2-jacek.anaszewski@gmail.com> <20190418122135.GA6925@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Takashi Iwai , Pavel Machek Cc: linux-leds@vger.kernel.org, Arnd Bergmann , dtor@google.com, robh@kernel.org, Jaroslav Kysela , linux@roeck-us.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-leds@vger.kernel.org On 4/18/19 2:24 PM, Takashi Iwai wrote: > On Thu, 18 Apr 2019 14:21:35 +0200, > Pavel Machek wrote: >> >> On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: >>> On Wed, 17 Apr 2019 22:54:14 +0200, >>> Jacek Anaszewski wrote: >>>> >>>> led_colors clashes with the array of the same name being added >>>> to the LED class. Do the following amendments to fix this issue >>>> and the other prospective one. >>>> >>>> led_colors -> toneport_led_colors >>>> led_init_vals -> toneport_led_init_vals >>>> >>>> Fixes: f44edd7b2bbed ("ALSA: line6/toneport: Implement LED controls via LED class") >>>> Signed-off-by: Jacek Anaszewski >>>> Cc: Jaroslav Kysela >>>> Cc: Takashi Iwai >>>> Cc: Arnd Bergmann >>> >>> Looks good. >>> >>> Feel free to take my ack: >>> Reviewed-by: Takashi Iwai Thanks. >> I guess this is independend of pretty much everything, and should be >> taken through the sound tree? > > I don't mind either way. If it's easier for you to take through sound > tree, just let me know. I prefer to take it via LED tree as this patch is needed by the LED naming set. -- Best regards, Jacek Anaszewski