From: santosh.shilimkar@oracle.com
To: Leon Romanovsky <leonro@mellanox.com>
Cc: John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hans Westgaard Ry <hans.westgaard.ry@oracle.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, rds-devel@oss.oracle.com,
linux-rdma@vger.kernel.org, linux-mm@kvack.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] net/rds: Track user mapped pages through special API
Date: Wed, 12 Feb 2020 09:55:02 -0800 [thread overview]
Message-ID: <b0e45342-4415-67e4-8c5b-37a6fc8d310e@oracle.com> (raw)
In-Reply-To: <20200212175159.GD679970@unreal>
On 2/12/20 9:51 AM, Leon Romanovsky wrote:
> On Wed, Feb 12, 2020 at 09:31:51AM -0800, santosh.shilimkar@oracle.com wrote:
>> On 2/11/20 7:03 PM, John Hubbard wrote:
>>> From: Leon Romanovsky <leonro@mellanox.com>
>>>
>>> Convert net/rds to use the newly introduces pin_user_pages() API,
>>> which properly sets FOLL_PIN. Setting FOLL_PIN is now required for
>>> code that requires tracking of pinned pages.
>>>
>>> Note that this effectively changes the code's behavior: it now
>>> ultimately calls set_page_dirty_lock(), instead of set_page_dirty().
>>> This is probably more accurate.
>>>
>>> As Christoph Hellwig put it, "set_page_dirty() is only safe if we are
>>> dealing with a file backed page where we have reference on the inode it
>>> hangs off." [1]
>>>
>>> [1] https://urldefense.com/v3/__https://lore.kernel.org/r/20190723153640.GB720@lst.de__;!!GqivPVa7Brio!OJHuecs9Iup5ig3kQBi_423uMMuskWhBQAdOICrY3UQ_ZfEaxt9ySY7E8y32Q7pk5tByyA$
>>>
>>> Cc: Hans Westgaard Ry <hans.westgaard.ry@oracle.com>
>>> Cc: Santosh Shilimkar <santosh.shilimkar@oracle.com>
>>> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
>>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>>> ---
>> Change looks fine to me. Just on safer side, we will try
>> to test this change with regression suite to make sure it
>> works as expected.
>
> Thanks Santosh,
> I wrote this patch before John's series was merged into the tree,
> but back then, Hans tested it and it worked, hope that it still works. :)
>
I see. Wasn't aware of it. In that case, its should be fine.
Regards,
Santosh
next prev parent reply other threads:[~2020-02-12 17:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 3:03 [PATCH 0/1] net/rds: Track user mapped pages through special API John Hubbard
2020-02-12 3:03 ` [PATCH 1/1] " John Hubbard
2020-02-12 17:31 ` santosh.shilimkar
2020-02-12 17:51 ` Leon Romanovsky
2020-02-12 17:55 ` santosh.shilimkar [this message]
2020-02-17 2:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e45342-4415-67e4-8c5b-37a6fc8d310e@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hans.westgaard.ry@oracle.com \
--cc=jhubbard@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.