From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73865C433EF for ; Fri, 8 Oct 2021 06:47:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0063061040 for ; Fri, 8 Oct 2021 06:47:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0063061040 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 83E9683564; Fri, 8 Oct 2021 08:47:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="A36CTUVL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1CB598337C; Fri, 8 Oct 2021 08:47:24 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E38E3835F1 for ; Fri, 8 Oct 2021 08:47:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=4915a58762=patrice.chotard@foss.st.com Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1984ZdJ7022582; Fri, 8 Oct 2021 08:47:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=RUBi00+msdFJcUXXd2yRojWEfwG+8UmlxDWL2SS0Xg8=; b=A36CTUVLfRF2VyKL75ymlB0aHGL2od9SOmAmJTppgjRx+kE9mTDcftZBHSbtCXjFR4ne d0yyZu7wQzvZBrBoLhn/3sOQ8qruyLDaLaXiQcR7z4SjjXPVgG8l3qh7rm0s/CeWMiR8 z1fnISH8uyiZWWfJk4H6VF0LQOM7s1SKCuoTD65csRfOnnD/kSbIqlqT7Vmg+MmdbH7E nJ/QHn1Rf1+B5EejJsZIkIt63JTX9esXmTyW6fwXnBzeDvq0jOI/GSQfiUDiEEYytSlE 89cHVO/9GYEPM+LN4bl2DdI0staz9C2OW05TEEOxBZ0t5c/3KFAjaQg3oRIefvtnv9NX yA== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3bjbjshr0p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Oct 2021 08:47:07 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 186E7100038; Fri, 8 Oct 2021 08:47:07 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 100AC214D37; Fri, 8 Oct 2021 08:47:07 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.45) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Fri, 8 Oct 2021 08:47:06 +0200 Subject: Re: [PATCH 2/2] board: dh_stm32mp1: Remove gpio_hog_probe_all() from board To: Marek Vasut , CC: Patrick DELAUNAY , U-Boot STM32 , Simon Glass References: <20210901095143.4143-1-patrice.chotard@foss.st.com> <20210901095143.4143-2-patrice.chotard@foss.st.com> <1c71e380-0472-d5d1-aae9-4ac3b31f59f4@denx.de> From: Patrice CHOTARD Message-ID: Date: Fri, 8 Oct 2021 08:47:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1c71e380-0472-d5d1-aae9-4ac3b31f59f4@denx.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG2NODE2.st.com (10.75.127.5) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-08_02,2021-10-07_02,2020-04-07_01 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi On 9/3/21 3:02 PM, Marek Vasut wrote: > On 9/1/21 11:51 AM, Patrice Chotard wrote: >> DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in >> commit 49b10cb49262 ("gpio: fixes for gpio-hog support"). >> >> And furthermore, gpio_hog_probe_all() is already called in board_r.c. >> So gpio_hog_probe() can be removed from stm32mp1.c. >> >> Signed-off-by: Patrice Chotard >> Cc: Marek Vasut >> --- >> >>   board/dhelectronics/dh_stm32mp1/board.c | 3 --- >>   1 file changed, 3 deletions(-) >> >> diff --git a/board/dhelectronics/dh_stm32mp1/board.c b/board/dhelectronics/dh_stm32mp1/board.c >> index d7c1857c16..725b438d76 100644 >> --- a/board/dhelectronics/dh_stm32mp1/board.c >> +++ b/board/dhelectronics/dh_stm32mp1/board.c >> @@ -593,9 +593,6 @@ int board_init(void) >>       /* address of boot parameters */ >>       gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100; >>   -    if (CONFIG_IS_ENABLED(DM_GPIO_HOG)) >> -        gpio_hog_probe_all(); >> - >>       board_key_check(); > > This is likely OK, yes. Applied on u-boot-stm32 for next Thanks Patrice