From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C4AC49EA7 for ; Fri, 25 Jun 2021 03:09:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95887613FE for ; Fri, 25 Jun 2021 03:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233098AbhFYDL3 (ORCPT ); Thu, 24 Jun 2021 23:11:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56757 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233086AbhFYDLY (ORCPT ); Thu, 24 Jun 2021 23:11:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624590544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x2g9lBasApYrM4QFsD5hgHZyz+dwqoNSSbWrkfNZV2I=; b=T6N0mwGoButy10GAz6VAREaDqLgSnMS8/WRzbOHKWk53UAg5xA+8sxo6HxfHc6PO1P9gTI gaUlXOwVPE02TBSVgaKuW4qMfUFpwtqms4QzbuyVKTHFnQR7XQ/m6W/cBIl5FkJ41R99Df kdQ/kAnyqXRKDRSHk7IDdS81zVbODRg= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-474-1sTHtkmONU6luBGwr-d9bg-1; Thu, 24 Jun 2021 23:09:01 -0400 X-MC-Unique: 1sTHtkmONU6luBGwr-d9bg-1 Received: by mail-pf1-f200.google.com with SMTP id k12-20020aa788cc0000b0290306b50a28ecso4858437pff.10 for ; Thu, 24 Jun 2021 20:08:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=x2g9lBasApYrM4QFsD5hgHZyz+dwqoNSSbWrkfNZV2I=; b=Ql39PMTfoENGEaDTDVV29zmMVQdwTATvueqa4Rp6q/NP5e1gKtiZakqXNyhSQCix25 xh3hXZo6G260VYnmCcgnKLV1IEOKz65S8hU/rwjtvFjGYpEVx1W2+K+eE1V/zCZKOedl sXF0HlcVDwjehvYr0kZ7ICrRHQtKRZAjLYqP1YDQRc0ID+loj75od1drA1G4MJpGAsrd D4jrGdjPMk27NIfyVc/0HdZNBcvlNN6/VpZaERPy/xjMhEkefY/Xdh69rpwklmCtHban 2HiZapNQmM26Hzz0Txtq04U/BI6ljwkwRnJnrNIArQ3vwn4n1Hlg4ATa7DtwGbYNZQWy 8Sfw== X-Gm-Message-State: AOAM531V1rl6KHLdOm3yXufTCyd5drOZRcWbX1NpbW8vn91YORzGxyj6 NVGixIhYRrmX7fV6WHJFG4ttJEqV3cgJMpi6aYpviIinBcvHh22JdoD0vFlnY8DsX143ZBGn1pf PKFr5TFvWuzP8Lb8FBPgI/DeK5bjPeRuh3bfcPcfoLWoEULTwsjMzw/BO5ldaHAr6aO0cMtKef0 S6 X-Received: by 2002:a17:90a:d302:: with SMTP id p2mr597055pju.186.1624590535545; Thu, 24 Jun 2021 20:08:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSt2a7irPTEnHB75wt/k1DcVWt+k1ibjJ9B3uVz8Ybl5wVpiHcOLL8vV4fUc+onvCWC2yUZA== X-Received: by 2002:a17:90a:d302:: with SMTP id p2mr597003pju.186.1624590535223; Thu, 24 Jun 2021 20:08:55 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id z9sm4301129pfc.101.2021.06.24.20.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 20:08:54 -0700 (PDT) Subject: Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace To: Yongji Xie Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , Stefano Garzarella , Parav Pandit , Christoph Hellwig , Christian Brauner , Randy Dunlap , Matthew Wilcox , Al Viro , Jens Axboe , bcrl@kvack.org, Jonathan Corbet , =?UTF-8?Q?Mika_Penttil=c3=a4?= , Dan Carpenter , joro@8bytes.org, Greg KH , songmuchun@bytedance.com, virtualization , netdev@vger.kernel.org, kvm , linux-fsdevel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel References: <20210615141331.407-1-xieyongji@bytedance.com> <20210615141331.407-10-xieyongji@bytedance.com> <1bba439f-ffc8-c20e-e8a4-ac73e890c592@redhat.com> <0aeb7cb7-58e5-1a95-d830-68edd7e8ec2e@redhat.com> <48cab125-093b-2299-ff9c-3de8c7c5ed3d@redhat.com> From: Jason Wang Message-ID: Date: Fri, 25 Jun 2021 11:08:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/6/24 下午5:16, Yongji Xie 写道: > On Thu, Jun 24, 2021 at 4:14 PM Jason Wang wrote: >> >> 在 2021/6/24 下午12:46, Yongji Xie 写道: >>>> So we need to deal with both FEATURES_OK and reset, but probably not >>>> DRIVER_OK. >>>> >>> OK, I see. Thanks for the explanation. One more question is how about >>> clearing the corresponding status bit in get_status() rather than >>> making set_status() fail. Since the spec recommends this way for >>> validation which is done in virtio_dev_remove() and >>> virtio_finalize_features(). >>> >>> Thanks, >>> Yongji >>> >> I think you can. Or it would be even better that we just don't set the >> bit during set_status(). >> > Yes, that's what I mean. > >> I just realize that in vdpa_reset() we had: >> >> static inline void vdpa_reset(struct vdpa_device *vdev) >> { >> const struct vdpa_config_ops *ops = vdev->config; >> >> vdev->features_valid = false; >> ops->set_status(vdev, 0); >> } >> >> We probably need to add the synchronization here. E.g re-read with a >> timeout. >> > Looks like the timeout is already in set_status(). Do you mean the VDUSE's implementation? > Do we really need a > duplicated one here? 1) this is the timeout at the vDPA layer instead of the VDUSE layer. 2) it really depends on what's the meaning of the timeout for set_status of VDUSE. Do we want: 2a) for set_status(): relay the message to userspace and wait for the userspace to quiescence the datapath or 2b) for set_status(): simply relay the message to userspace, reply is no needed. Userspace will use a command to update the status when the datapath is stop. The the status could be fetched via get_stats(). 2b looks more spec complaint. > And how to handle failure? Adding a return value > to virtio_config_ops->reset() and passing the error to the upper > layer? Something like this. Thanks > > Thanks, > Yongji > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D489C49EA6 for ; Fri, 25 Jun 2021 03:09:08 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3623D613FE for ; Fri, 25 Jun 2021 03:09:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3623D613FE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9826640176; Fri, 25 Jun 2021 03:09:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F8Pz5CPhGL4u; Fri, 25 Jun 2021 03:09:06 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 936B740004; Fri, 25 Jun 2021 03:09:06 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 53618C001A; Fri, 25 Jun 2021 03:09:06 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id B8D2DC0010 for ; Fri, 25 Jun 2021 03:09:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 9FF4483C81 for ; Fri, 25 Jun 2021 03:09:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp1.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LN4M9YryNjWb for ; Fri, 25 Jun 2021 03:09:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id D9C0983760 for ; Fri, 25 Jun 2021 03:09:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624590542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x2g9lBasApYrM4QFsD5hgHZyz+dwqoNSSbWrkfNZV2I=; b=iaT02gjDN2MRRtiVAwie2VFaySSMUfhFl+tBDA+4/FUu5gNq8qg0+YApq9MZrzh/jeEPOO 5CqTeoMzah7s9OU3gZDHbfY1Ci22uVNAl/rV2Ohi8OsEQHwZPy6JkcgkE7alZH7JMKdsCP VxkAw9vR+uCUstkc2VWs/iEvFWl/xuY= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-486-1NNgceY_ORqUCMP9RgmVBA-1; Thu, 24 Jun 2021 23:09:00 -0400 X-MC-Unique: 1NNgceY_ORqUCMP9RgmVBA-1 Received: by mail-pf1-f198.google.com with SMTP id p42-20020a056a000a2ab02902f33d81f23fso5272150pfh.9 for ; Thu, 24 Jun 2021 20:08:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=x2g9lBasApYrM4QFsD5hgHZyz+dwqoNSSbWrkfNZV2I=; b=RgGUxhSDsKiqfQJqyYuSgwC/rJI6mZiI52JCJJgncl94POvmwC42XC6wePR3nGD8ZU KREusDT8ceXPlI5d/PQNvb+kYMizXT8KRw3SzrrRV5OOPpQ64pEBVE5wz497KkiJj6oa y1T9Buaq+ebJw7lhNkFwLdUemYHKbHwW08ugbcGmLmAKiKrffJcg+e/fskdgjXMbG51z cmzj8hjmHE73ZX8PVBNEMS3AXeJwsmNutCy1h4owt70W1ungBIuh5EkIHHYXfL0FlLI1 jGDoZI1NTObOB148vc2LO2OfwnW805pzGN9tBOCzMLLCv73qgiUFJ4B0hhEh0x6furaM T8aw== X-Gm-Message-State: AOAM533f/xcSSonT8+isx77Zx6HKJQBPzFux2+N4q734Jq5Dj2cwEKpz ls20hsDcVmwnRPgx/xhWZpCdNXZheFtPKnrcWsv3fIM3q2j6xqIgsXO65pJAl0mRasJiKgmdGB2 5k3KdI3PrReVejDSSyTgrG9rL7D5lmQ== X-Received: by 2002:a17:90a:d302:: with SMTP id p2mr597045pju.186.1624590535460; Thu, 24 Jun 2021 20:08:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSt2a7irPTEnHB75wt/k1DcVWt+k1ibjJ9B3uVz8Ybl5wVpiHcOLL8vV4fUc+onvCWC2yUZA== X-Received: by 2002:a17:90a:d302:: with SMTP id p2mr597003pju.186.1624590535223; Thu, 24 Jun 2021 20:08:55 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id z9sm4301129pfc.101.2021.06.24.20.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 20:08:54 -0700 (PDT) Subject: Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace To: Yongji Xie References: <20210615141331.407-1-xieyongji@bytedance.com> <20210615141331.407-10-xieyongji@bytedance.com> <1bba439f-ffc8-c20e-e8a4-ac73e890c592@redhat.com> <0aeb7cb7-58e5-1a95-d830-68edd7e8ec2e@redhat.com> <48cab125-093b-2299-ff9c-3de8c7c5ed3d@redhat.com> From: Jason Wang Message-ID: Date: Fri, 25 Jun 2021 11:08:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: kvm , "Michael S. Tsirkin" , virtualization , Christian Brauner , Jonathan Corbet , Matthew Wilcox , Christoph Hellwig , Dan Carpenter , Stefano Garzarella , Al Viro , Stefan Hajnoczi , songmuchun@bytedance.com, Jens Axboe , Greg KH , Randy Dunlap , linux-kernel , iommu@lists.linux-foundation.org, bcrl@kvack.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, =?UTF-8?Q?Mika_Penttil=c3=a4?= X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" CuWcqCAyMDIxLzYvMjQg5LiL5Y2INToxNiwgWW9uZ2ppIFhpZSDlhpnpgZM6Cj4gT24gVGh1LCBK dW4gMjQsIDIwMjEgYXQgNDoxNCBQTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3 cm90ZToKPj4KPj4g5ZyoIDIwMjEvNi8yNCDkuIvljYgxMjo0NiwgWW9uZ2ppIFhpZSDlhpnpgZM6 Cj4+Pj4gU28gd2UgbmVlZCB0byBkZWFsIHdpdGggYm90aCBGRUFUVVJFU19PSyBhbmQgcmVzZXQs IGJ1dCBwcm9iYWJseSBub3QKPj4+PiBEUklWRVJfT0suCj4+Pj4KPj4+IE9LLCBJIHNlZS4gVGhh bmtzIGZvciB0aGUgZXhwbGFuYXRpb24uIE9uZSBtb3JlIHF1ZXN0aW9uIGlzIGhvdyBhYm91dAo+ Pj4gY2xlYXJpbmcgdGhlIGNvcnJlc3BvbmRpbmcgc3RhdHVzIGJpdCBpbiBnZXRfc3RhdHVzKCkg cmF0aGVyIHRoYW4KPj4+IG1ha2luZyBzZXRfc3RhdHVzKCkgZmFpbC4gU2luY2UgdGhlIHNwZWMg cmVjb21tZW5kcyB0aGlzIHdheSBmb3IKPj4+IHZhbGlkYXRpb24gd2hpY2ggaXMgZG9uZSBpbiB2 aXJ0aW9fZGV2X3JlbW92ZSgpIGFuZAo+Pj4gdmlydGlvX2ZpbmFsaXplX2ZlYXR1cmVzKCkuCj4+ Pgo+Pj4gVGhhbmtzLAo+Pj4gWW9uZ2ppCj4+Pgo+PiBJIHRoaW5rIHlvdSBjYW4uIE9yIGl0IHdv dWxkIGJlIGV2ZW4gYmV0dGVyIHRoYXQgd2UganVzdCBkb24ndCBzZXQgdGhlCj4+IGJpdCBkdXJp bmcgc2V0X3N0YXR1cygpLgo+Pgo+IFllcywgdGhhdCdzIHdoYXQgSSBtZWFuLgo+Cj4+IEkganVz dCByZWFsaXplIHRoYXQgaW4gdmRwYV9yZXNldCgpIHdlIGhhZDoKPj4KPj4gc3RhdGljIGlubGlu ZSB2b2lkIHZkcGFfcmVzZXQoc3RydWN0IHZkcGFfZGV2aWNlICp2ZGV2KQo+PiB7Cj4+ICAgICAg ICAgICBjb25zdCBzdHJ1Y3QgdmRwYV9jb25maWdfb3BzICpvcHMgPSB2ZGV2LT5jb25maWc7Cj4+ Cj4+ICAgICAgICAgICB2ZGV2LT5mZWF0dXJlc192YWxpZCA9IGZhbHNlOwo+PiAgICAgICAgICAg b3BzLT5zZXRfc3RhdHVzKHZkZXYsIDApOwo+PiB9Cj4+Cj4+IFdlIHByb2JhYmx5IG5lZWQgdG8g YWRkIHRoZSBzeW5jaHJvbml6YXRpb24gaGVyZS4gRS5nIHJlLXJlYWQgd2l0aCBhCj4+IHRpbWVv dXQuCj4+Cj4gTG9va3MgbGlrZSB0aGUgdGltZW91dCBpcyBhbHJlYWR5IGluIHNldF9zdGF0dXMo KS4KCgpEbyB5b3UgbWVhbiB0aGUgVkRVU0UncyBpbXBsZW1lbnRhdGlvbj8KCgo+ICAgRG8gd2Ug cmVhbGx5IG5lZWQgYQo+IGR1cGxpY2F0ZWQgb25lIGhlcmU/CgoKMSkgdGhpcyBpcyB0aGUgdGlt ZW91dCBhdCB0aGUgdkRQQSBsYXllciBpbnN0ZWFkIG9mIHRoZSBWRFVTRSBsYXllci4KMikgaXQg cmVhbGx5IGRlcGVuZHMgb24gd2hhdCdzIHRoZSBtZWFuaW5nIG9mIHRoZSB0aW1lb3V0IGZvciBz ZXRfc3RhdHVzIApvZiBWRFVTRS4KCkRvIHdlIHdhbnQ6CgoyYSkgZm9yIHNldF9zdGF0dXMoKTog cmVsYXkgdGhlIG1lc3NhZ2UgdG8gdXNlcnNwYWNlIGFuZCB3YWl0IGZvciB0aGUgCnVzZXJzcGFj ZSB0byBxdWllc2NlbmNlIHRoZSBkYXRhcGF0aAoKb3IKCjJiKSBmb3Igc2V0X3N0YXR1cygpOiBz aW1wbHkgcmVsYXkgdGhlIG1lc3NhZ2UgdG8gdXNlcnNwYWNlLCByZXBseSBpcyBubyAKbmVlZGVk LiBVc2Vyc3BhY2Ugd2lsbCB1c2UgYSBjb21tYW5kIHRvIHVwZGF0ZSB0aGUgc3RhdHVzIHdoZW4g dGhlIApkYXRhcGF0aCBpcyBzdG9wLiBUaGUgdGhlIHN0YXR1cyBjb3VsZCBiZSBmZXRjaGVkIHZp YSBnZXRfc3RhdHMoKS4KCjJiIGxvb2tzIG1vcmUgc3BlYyBjb21wbGFpbnQuCgo+IEFuZCBob3cg dG8gaGFuZGxlIGZhaWx1cmU/IEFkZGluZyBhIHJldHVybiB2YWx1ZQo+IHRvIHZpcnRpb19jb25m aWdfb3BzLT5yZXNldCgpIGFuZCBwYXNzaW5nIHRoZSBlcnJvciB0byB0aGUgdXBwZXIKPiBsYXll cj8KCgpTb21ldGhpbmcgbGlrZSB0aGlzLgoKVGhhbmtzCgoKPgo+IFRoYW5rcywKPiBZb25namkK PgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUg bWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlz dHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86196C49EA5 for ; Fri, 25 Jun 2021 03:09:10 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FDDA613FA for ; Fri, 25 Jun 2021 03:09:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FDDA613FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 1745C40176; Fri, 25 Jun 2021 03:09:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id i8WO5c_llGvF; Fri, 25 Jun 2021 03:09:09 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id B8E79400DC; Fri, 25 Jun 2021 03:09:08 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 941C6C001A; Fri, 25 Jun 2021 03:09:08 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E48A2C0022 for ; Fri, 25 Jun 2021 03:09:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D2B224054B for ; Fri, 25 Jun 2021 03:09:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q9W4PtpltNJX for ; Fri, 25 Jun 2021 03:09:06 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id D38DD40512 for ; Fri, 25 Jun 2021 03:09:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624590544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x2g9lBasApYrM4QFsD5hgHZyz+dwqoNSSbWrkfNZV2I=; b=T6N0mwGoButy10GAz6VAREaDqLgSnMS8/WRzbOHKWk53UAg5xA+8sxo6HxfHc6PO1P9gTI gaUlXOwVPE02TBSVgaKuW4qMfUFpwtqms4QzbuyVKTHFnQR7XQ/m6W/cBIl5FkJ41R99Df kdQ/kAnyqXRKDRSHk7IDdS81zVbODRg= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-61h-81O5OC-7iFARHsnHMQ-1; Thu, 24 Jun 2021 23:09:00 -0400 X-MC-Unique: 61h-81O5OC-7iFARHsnHMQ-1 Received: by mail-pg1-f197.google.com with SMTP id 4-20020a6315440000b029022154a87a57so5157698pgv.13 for ; Thu, 24 Jun 2021 20:08:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=x2g9lBasApYrM4QFsD5hgHZyz+dwqoNSSbWrkfNZV2I=; b=Xmvm7Gq4nLPnwFovKrfH9Ym2RTW78ey9CMG+Q+jEsto+ioX6TkMfogud00qMygJb5j oAmdzk8ckndprmrxRkDEW0xSK4nFOGU3CWwh3beLfZaWda4a/OWf6UmudxI4YXXPa22N JJKpEW3Oq6FN3dfb3eRZPwV8raaVIQ1mTjpdytn1I4VoEo9RgcECuOXDTXC6uyxyyElh ROrAcf+4cGWIcxI/kyNOSUtdlNc+OKBFvNNShMmkhdHTFiFKcizcFDYVZY6ctEi8yaMT VE4qYHmS0p9N4h/R8PGFylbsFv5XLICqw6sVVAJvlEEepj2Jc5CvF8Nwpwt6VQ6ynQLe YYyw== X-Gm-Message-State: AOAM533RAecFBVTxxmReVn33oo1D12jBfyHagwuKJnokPTe0AoVDZI5K H1vDmornku8/jhTC1BJlirqxjJ0F2nEgL1eoTQa8rukOibyE1idzyidbcG5EFzt0r5vtQxeDKP7 cBYgsuwa1nZnY1eKS6hKYqTWe0Q/o2miB+gTbnSk6Lw== X-Received: by 2002:a17:90a:d302:: with SMTP id p2mr597052pju.186.1624590535520; Thu, 24 Jun 2021 20:08:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSt2a7irPTEnHB75wt/k1DcVWt+k1ibjJ9B3uVz8Ybl5wVpiHcOLL8vV4fUc+onvCWC2yUZA== X-Received: by 2002:a17:90a:d302:: with SMTP id p2mr597003pju.186.1624590535223; Thu, 24 Jun 2021 20:08:55 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id z9sm4301129pfc.101.2021.06.24.20.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jun 2021 20:08:54 -0700 (PDT) Subject: Re: [PATCH v8 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace To: Yongji Xie References: <20210615141331.407-1-xieyongji@bytedance.com> <20210615141331.407-10-xieyongji@bytedance.com> <1bba439f-ffc8-c20e-e8a4-ac73e890c592@redhat.com> <0aeb7cb7-58e5-1a95-d830-68edd7e8ec2e@redhat.com> <48cab125-093b-2299-ff9c-3de8c7c5ed3d@redhat.com> From: Jason Wang Message-ID: Date: Fri, 25 Jun 2021 11:08:42 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: kvm , "Michael S. Tsirkin" , virtualization , Christian Brauner , Jonathan Corbet , joro@8bytes.org, Matthew Wilcox , Christoph Hellwig , Dan Carpenter , Al Viro , Stefan Hajnoczi , songmuchun@bytedance.com, Jens Axboe , Greg KH , Randy Dunlap , linux-kernel , iommu@lists.linux-foundation.org, bcrl@kvack.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, =?UTF-8?Q?Mika_Penttil=c3=a4?= X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIxLzYvMjQg5LiL5Y2INToxNiwgWW9uZ2ppIFhpZSDlhpnpgZM6Cj4gT24gVGh1LCBK dW4gMjQsIDIwMjEgYXQgNDoxNCBQTSBKYXNvbiBXYW5nIDxqYXNvd2FuZ0ByZWRoYXQuY29tPiB3 cm90ZToKPj4KPj4g5ZyoIDIwMjEvNi8yNCDkuIvljYgxMjo0NiwgWW9uZ2ppIFhpZSDlhpnpgZM6 Cj4+Pj4gU28gd2UgbmVlZCB0byBkZWFsIHdpdGggYm90aCBGRUFUVVJFU19PSyBhbmQgcmVzZXQs IGJ1dCBwcm9iYWJseSBub3QKPj4+PiBEUklWRVJfT0suCj4+Pj4KPj4+IE9LLCBJIHNlZS4gVGhh bmtzIGZvciB0aGUgZXhwbGFuYXRpb24uIE9uZSBtb3JlIHF1ZXN0aW9uIGlzIGhvdyBhYm91dAo+ Pj4gY2xlYXJpbmcgdGhlIGNvcnJlc3BvbmRpbmcgc3RhdHVzIGJpdCBpbiBnZXRfc3RhdHVzKCkg cmF0aGVyIHRoYW4KPj4+IG1ha2luZyBzZXRfc3RhdHVzKCkgZmFpbC4gU2luY2UgdGhlIHNwZWMg cmVjb21tZW5kcyB0aGlzIHdheSBmb3IKPj4+IHZhbGlkYXRpb24gd2hpY2ggaXMgZG9uZSBpbiB2 aXJ0aW9fZGV2X3JlbW92ZSgpIGFuZAo+Pj4gdmlydGlvX2ZpbmFsaXplX2ZlYXR1cmVzKCkuCj4+ Pgo+Pj4gVGhhbmtzLAo+Pj4gWW9uZ2ppCj4+Pgo+PiBJIHRoaW5rIHlvdSBjYW4uIE9yIGl0IHdv dWxkIGJlIGV2ZW4gYmV0dGVyIHRoYXQgd2UganVzdCBkb24ndCBzZXQgdGhlCj4+IGJpdCBkdXJp bmcgc2V0X3N0YXR1cygpLgo+Pgo+IFllcywgdGhhdCdzIHdoYXQgSSBtZWFuLgo+Cj4+IEkganVz dCByZWFsaXplIHRoYXQgaW4gdmRwYV9yZXNldCgpIHdlIGhhZDoKPj4KPj4gc3RhdGljIGlubGlu ZSB2b2lkIHZkcGFfcmVzZXQoc3RydWN0IHZkcGFfZGV2aWNlICp2ZGV2KQo+PiB7Cj4+ICAgICAg ICAgICBjb25zdCBzdHJ1Y3QgdmRwYV9jb25maWdfb3BzICpvcHMgPSB2ZGV2LT5jb25maWc7Cj4+ Cj4+ICAgICAgICAgICB2ZGV2LT5mZWF0dXJlc192YWxpZCA9IGZhbHNlOwo+PiAgICAgICAgICAg b3BzLT5zZXRfc3RhdHVzKHZkZXYsIDApOwo+PiB9Cj4+Cj4+IFdlIHByb2JhYmx5IG5lZWQgdG8g YWRkIHRoZSBzeW5jaHJvbml6YXRpb24gaGVyZS4gRS5nIHJlLXJlYWQgd2l0aCBhCj4+IHRpbWVv dXQuCj4+Cj4gTG9va3MgbGlrZSB0aGUgdGltZW91dCBpcyBhbHJlYWR5IGluIHNldF9zdGF0dXMo KS4KCgpEbyB5b3UgbWVhbiB0aGUgVkRVU0UncyBpbXBsZW1lbnRhdGlvbj8KCgo+ICAgRG8gd2Ug cmVhbGx5IG5lZWQgYQo+IGR1cGxpY2F0ZWQgb25lIGhlcmU/CgoKMSkgdGhpcyBpcyB0aGUgdGlt ZW91dCBhdCB0aGUgdkRQQSBsYXllciBpbnN0ZWFkIG9mIHRoZSBWRFVTRSBsYXllci4KMikgaXQg cmVhbGx5IGRlcGVuZHMgb24gd2hhdCdzIHRoZSBtZWFuaW5nIG9mIHRoZSB0aW1lb3V0IGZvciBz ZXRfc3RhdHVzIApvZiBWRFVTRS4KCkRvIHdlIHdhbnQ6CgoyYSkgZm9yIHNldF9zdGF0dXMoKTog cmVsYXkgdGhlIG1lc3NhZ2UgdG8gdXNlcnNwYWNlIGFuZCB3YWl0IGZvciB0aGUgCnVzZXJzcGFj ZSB0byBxdWllc2NlbmNlIHRoZSBkYXRhcGF0aAoKb3IKCjJiKSBmb3Igc2V0X3N0YXR1cygpOiBz aW1wbHkgcmVsYXkgdGhlIG1lc3NhZ2UgdG8gdXNlcnNwYWNlLCByZXBseSBpcyBubyAKbmVlZGVk LiBVc2Vyc3BhY2Ugd2lsbCB1c2UgYSBjb21tYW5kIHRvIHVwZGF0ZSB0aGUgc3RhdHVzIHdoZW4g dGhlIApkYXRhcGF0aCBpcyBzdG9wLiBUaGUgdGhlIHN0YXR1cyBjb3VsZCBiZSBmZXRjaGVkIHZp YSBnZXRfc3RhdHMoKS4KCjJiIGxvb2tzIG1vcmUgc3BlYyBjb21wbGFpbnQuCgo+IEFuZCBob3cg dG8gaGFuZGxlIGZhaWx1cmU/IEFkZGluZyBhIHJldHVybiB2YWx1ZQo+IHRvIHZpcnRpb19jb25m aWdfb3BzLT5yZXNldCgpIGFuZCBwYXNzaW5nIHRoZSBlcnJvciB0byB0aGUgdXBwZXIKPiBsYXll cj8KCgpTb21ldGhpbmcgbGlrZSB0aGlzLgoKVGhhbmtzCgoKPgo+IFRoYW5rcywKPiBZb25namkK PgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVh bGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRp b24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZv L3ZpcnR1YWxpemF0aW9u