From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0875766861303745365==" MIME-Version: 1.0 From: Helge Deller To: kbuild-all@lists.01.org Subject: Re: [linux-next:master 3272/11956] undefined reference to `ioread64_hi_lo' Date: Wed, 30 Sep 2020 16:38:51 +0200 Message-ID: In-Reply-To: <202009300950.j4HIBO1j-lkp@intel.com> List-Id: --===============0875766861303745365== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 9/30/20 3:44 AM, kernel test robot wrote: > Hi Helge, > > FYI, the error/warning still remains. I answered on 8/29/20, 10:47 PM and didn't got any reply.... Here is what I wrote: In drivers/firmware/arm_scmi/perf.c iowrite64_hi_lo() is called directly. So, I could add this function to arch/parisc/lib/iomap.c to prevent the lin= ker error. But this file is compiled on parisc just because CONFIG_COMPILE_TEST is set= , while in production builds it would never be compiled. So, what's the usual take in such a scenario? Shall I ignore this linker error and 0-day warning, or shall I add a workar= ound? In general I'd prefer this patch: --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -8,7 +8,7 @@ menu "Firmware Drivers" config ARM_SCMI_PROTOCOL bool "ARM System Control and Management Interface (SCMI) Message Pr= otocol" - depends on ARM || ARM64 || COMPILE_TEST + depends on ARM || ARM64 || (COMPILE_TEST && OF) depends on MAILBOX help ARM System Control and Management Interface (SCMI) protocol is a Would that be Ok? Helge > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g= it master > head: 49e7e3e905e437a02782019570f70997e2da9101 > commit: ad697ae387f9f707c4065ab26d583c007bec76e4 [3272/11956] parisc: Add= qemu fw_cfg interface > config: parisc-allyesconfig (attached as .config) > compiler: hppa-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next= .git/commit/?id=3Dad697ae387f9f707c4065ab26d583c007bec76e4 > git remote add linux-next https://git.kernel.org/pub/scm/linux/ke= rnel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout ad697ae387f9f707c4065ab26d583c007bec76e4 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.cros= s ARCH=3Dparisc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > hppa-linux-ld: drivers/firmware/arm_scmi/perf.o: in function `scmi_per= f_fc_ring_db': >>> (.text+0x610): undefined reference to `ioread64_hi_lo' >>> hppa-linux-ld: (.text+0x63c): undefined reference to `iowrite64_hi_lo' > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org > --===============0875766861303745365==--