All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: fs_enet: sync rx dma buffer before reading
@ 2022-05-19 19:24 Mans Rullgard
  2022-05-20  5:39 ` Christophe Leroy
  0 siblings, 1 reply; 14+ messages in thread
From: Mans Rullgard @ 2022-05-19 19:24 UTC (permalink / raw)
  To: Pantelis Antoniou, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Vitaly Bordug, Dan Malek, Joakim Tjernlund,
	Christophe Leroy, linuxppc-dev, netdev, linux-kernel

The dma_sync_single_for_cpu() call must precede reading the received
data. Fix this.

Fixes: 070e1f01827c ("net: fs_enet: don't unmap DMA when packet len is below copybreak")
Signed-off-by: Mans Rullgard <mans@mansr.com>
---
 drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
index b3dae17e067e..432ce10cbfd0 100644
--- a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
+++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
@@ -240,14 +240,14 @@ static int fs_enet_napi(struct napi_struct *napi, int budget)
 				/* +2 to make IP header L1 cache aligned */
 				skbn = netdev_alloc_skb(dev, pkt_len + 2);
 				if (skbn != NULL) {
+					dma_sync_single_for_cpu(fep->dev,
+						CBDR_BUFADDR(bdp),
+						L1_CACHE_ALIGN(pkt_len),
+						DMA_FROM_DEVICE);
 					skb_reserve(skbn, 2);	/* align IP header */
 					skb_copy_from_linear_data(skb,
 						      skbn->data, pkt_len);
 					swap(skb, skbn);
-					dma_sync_single_for_cpu(fep->dev,
-						CBDR_BUFADDR(bdp),
-						L1_CACHE_ALIGN(pkt_len),
-						DMA_FROM_DEVICE);
 				}
 			} else {
 				skbn = netdev_alloc_skb(dev, ENET_RX_FRSIZE);
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2022-05-23 20:24 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 19:24 [PATCH] net: fs_enet: sync rx dma buffer before reading Mans Rullgard
2022-05-20  5:39 ` Christophe Leroy
2022-05-20 12:35   ` Måns Rullgård
2022-05-20 12:35     ` Måns Rullgård
2022-05-20 12:54     ` Christophe Leroy
2022-05-20 12:54       ` Christophe Leroy
2022-05-20 17:43       ` Jakub Kicinski
2022-05-20 17:43         ` Jakub Kicinski
2022-05-21  6:44         ` Christophe Leroy
2022-05-21  6:44           ` Christophe Leroy
2022-05-21 17:44           ` Jakub Kicinski
2022-05-21 17:44             ` Jakub Kicinski
2022-05-23 20:23             ` Jakub Kicinski
2022-05-23 20:23               ` Jakub Kicinski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.