From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB8CC433B4 for ; Thu, 29 Apr 2021 15:01:38 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 351B261107 for ; Thu, 29 Apr 2021 15:01:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 351B261107 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.120126.227143 (Exim 4.92) (envelope-from ) id 1lc8AN-0004N9-RK; Thu, 29 Apr 2021 15:01:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 120126.227143; Thu, 29 Apr 2021 15:01:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lc8AN-0004N2-OK; Thu, 29 Apr 2021 15:01:23 +0000 Received: by outflank-mailman (input) for mailman id 120126; Thu, 29 Apr 2021 15:01:22 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lc8AM-0004Mx-1h for xen-devel@lists.xenproject.org; Thu, 29 Apr 2021 15:01:22 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id c2ef2041-cea2-49b7-bce5-b4bc2df13556; Thu, 29 Apr 2021 15:01:21 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 256D5B155; Thu, 29 Apr 2021 15:01:20 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2ef2041-cea2-49b7-bce5-b4bc2df13556 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1619708480; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PvmUm53KgHCXUaJWnWOnwWFCAA9Erof4GJ5DZXmYtiA=; b=fbnn1mcexhEDrmoScLvJ9FadC3pZd8Ibh4+f2kbrz0K7ml+q5jmVDAh/qa5vDv2lnz8csA PDR2uGG6rwLxEvfyU6FXrLnLbATOGUERGNBkX7gtw+V4j2LgM9f9cYwMeKzkjaDtVVqE2p 7U8wlwf2uh+bVkE7ei5WBZUrvrSUFrU= Subject: Re: [PATCH v2 02/12] x86/p2m: {,un}map_mmio_regions() are HVM-only To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: <3cf73378-b9d6-0eca-12b6-0f628518bebf@suse.com> <7f8ca70d-8bbe-bd5d-533a-c5ea81dc91a2@suse.com> From: Jan Beulich Message-ID: Date: Thu, 29 Apr 2021 17:01:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 29.04.2021 16:48, Roger Pau Monné wrote: > On Mon, Apr 12, 2021 at 04:06:34PM +0200, Jan Beulich wrote: >> Mirror the "translated" check the functions do to do_domctl(), allowing >> the calls to be DCEd by the compiler. Add ASSERT_UNREACHABLE() to the >> original checks. >> >> Also arrange for {set,clear}_mmio_p2m_entry() and >> {set,clear}_identity_p2m_entry() to respectively live next to each >> other, such that clear_mmio_p2m_entry() can also be covered by the >> #ifdef already covering set_mmio_p2m_entry(). > > Seeing the increase in HVM specific regions, would it make sense to > consider splitting the HVM bits into p2m-hvm.c or some such? As said on the 01/12 sub-thread, I see the goal as p2m.c as a whole becoming HVM specific. >> @@ -1932,7 +1934,10 @@ int map_mmio_regions(struct domain *d, >> unsigned int iter, order; >> >> if ( !paging_mode_translate(d) ) >> + { >> + ASSERT_UNREACHABLE(); >> return 0; >> + } >> >> for ( iter = i = 0; i < nr && iter < MAP_MMIO_MAX_ITER; >> i += 1UL << order, ++iter ) >> @@ -1964,7 +1969,10 @@ int unmap_mmio_regions(struct domain *d, >> unsigned int iter, order; >> >> if ( !paging_mode_translate(d) ) >> + { >> + ASSERT_UNREACHABLE(); >> return 0; > > Maybe consider returning an error here now instead of silently > failing? It's not supposed to be reached, so getting here likely means > something else has gone wrong and it's best to just report an error? Can do, sure. Would be -EOPNOTSUPP. > The rest LGTM: > > Acked-by: Roger Pau Monné Thanks. Jan