From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8F0C433EF for ; Thu, 9 Sep 2021 16:18:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC6FA6113E for ; Thu, 9 Sep 2021 16:18:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC6FA6113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 10B9A6E8AF; Thu, 9 Sep 2021 16:18:33 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id AE8746E8AF for ; Thu, 9 Sep 2021 16:18:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631204310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ewBHaw6CXr7fu1kkTtufkK6zzYGeCnEb1o6teII30n0=; b=jFYvwijWqO0sq1P/nR5XPupRpeQorjWCpd/ryHFa4CrojSV+7sNX7IMx347SW1oc3WSkNw E8zvXzgn7guOcLA/7ZdV3AZbqP2O1y+tz/RgVdXG8D+oUcgC64Rn/J1gysazOJjCc+djLg YfZ5i8vseL07B7Om+EI0xuCZI5pH470= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-245-Tv5RKjzgNQSBCMbGVIJEQQ-1; Thu, 09 Sep 2021 12:18:29 -0400 X-MC-Unique: Tv5RKjzgNQSBCMbGVIJEQQ-1 Received: by mail-qk1-f198.google.com with SMTP id x19-20020a05620a099300b003f64d79cbbaso5159962qkx.7 for ; Thu, 09 Sep 2021 09:18:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=ewBHaw6CXr7fu1kkTtufkK6zzYGeCnEb1o6teII30n0=; b=gY0uWxwNpq9qrwCoD0E767YeavtPEWER4vg89xmdFefnhDmRpmXv0U12PHP9wWFFKd b8m8k8urRrBh2/cGlfZcLT0kPLNbrvSUZb+fsozqShRRusnmCEXB709RJRd43GHsd8oV ioodKmm9l2QDCq+2PzSE4j7y3oUZpbgJLh9PPJWba1CIe2RmSec7f8oMcXsWc500nZX0 0xMtalzEpjYINKMuYwP8Tx7dFEt8Zzm9HEKbKjGdYukqxI9f6LEyDtC3nMonRuMhK+Vy bLOQTPqqZ7j5+5znO21Lu/RMC51VSP7g/khWf5NkF2XpS8iGdD0OGKkYL2hPYCR/PAtd 3bwA== X-Gm-Message-State: AOAM530n0uT7vU4TFQ2Qxo2tb9Lm9wgIO48t6zOCv/OWRX171IbGEg4P URk0+RTEMQMiIWyNWo4U3MblOFJ50MjwSATPNL+5ql4xGrUyypig7d8RSOrML7XGyBCLl2l78Zy dAyor7yfBIOMThAyTm/pittjjobec X-Received: by 2002:a05:6214:130a:: with SMTP id a10mr3869429qvv.53.1631204309057; Thu, 09 Sep 2021 09:18:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfrNSaQBwEqiRj+mMqs77Y036x02BGZlpVc98v6yXwCA+EFrazr+WrnxmecQoDDyTFLf7vxw== X-Received: by 2002:a05:6214:130a:: with SMTP id a10mr3869412qvv.53.1631204308888; Thu, 09 Sep 2021 09:18:28 -0700 (PDT) Received: from [192.168.8.206] (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id a9sm1647417qko.27.2021.09.09.09.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 09:18:28 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 02/13] drm/dp: use more of the extended receiver cap From: Lyude Paul To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, ville.syrjala@linux.intel.com, manasi.d.navare@intel.com Date: Thu, 09 Sep 2021 12:18:27 -0400 In-Reply-To: <282213f032b3dfe10cf7c461083c26b474f09f0f.camel@redhat.com> References: <649051cb896821147feee91aab1f2abc523c1353.1631191763.git.jani.nikula@intel.com> <282213f032b3dfe10cf7c461083c26b474f09f0f.camel@redhat.com> Organization: Red Hat User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" …whoops, that was supposed to be: Reviewed-by: Lyude Paul On Thu, 2021-09-09 at 12:18 -0400, Lyude Paul wrote: > I thought I remembered an issue with this but looked up the previous emails, > and it looks like that this change actually should be safe! > > Signed-off-by: Lyude Paul > > On Thu, 2021-09-09 at 15:51 +0300, Jani Nikula wrote: > > Extend the use of extended receiver cap at 0x2200 to cover > > MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides > > the DP 2.0 128b/132b channel encoding cap. > > > > v2: Extend to DP_RECEIVER_CAP_SIZE (Ville) > > > > Cc: Lyude Paul > > Cc: dri-devel@lists.freedesktop.org > > Cc: Manasi Navare > > Cc: Ville Syrjälä > > Signed-off-by: Jani Nikula > > --- > >  drivers/gpu/drm/drm_dp_helper.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > > b/drivers/gpu/drm/drm_dp_helper.c > > index 9b2a2961fca8..2e74b02ed96b 100644 > > --- a/drivers/gpu/drm/drm_dp_helper.c > > +++ b/drivers/gpu/drm/drm_dp_helper.c > > @@ -608,7 +608,7 @@ static u8 drm_dp_downstream_port_count(const u8 > > dpcd[DP_RECEIVER_CAP_SIZE]) > >  static int drm_dp_read_extended_dpcd_caps(struct drm_dp_aux *aux, > >                                           u8 dpcd[DP_RECEIVER_CAP_SIZE]) > >  { > > -       u8 dpcd_ext[6]; > > +       u8 dpcd_ext[DP_RECEIVER_CAP_SIZE]; > >         int ret; > >   > >         /* > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76998C433EF for ; Thu, 9 Sep 2021 16:18:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41D6161179 for ; Thu, 9 Sep 2021 16:18:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 41D6161179 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B78646E8B1; Thu, 9 Sep 2021 16:18:36 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB1F06E8B1 for ; Thu, 9 Sep 2021 16:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631204314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ewBHaw6CXr7fu1kkTtufkK6zzYGeCnEb1o6teII30n0=; b=UIDL7/ZEygcg7Hh9qAilZJUrc68nS3G2uuCLzEnv+tPssGRGjl4ViyMKQ1uvqgLZuHjPBN 8hiTPtETjTduB+U5qqjqgV3HhFdAMBbV628ZMZC0Axs2xkRb2I1iqC3CMJn6tu4E4vZSIv S0fkN498ZKROovAV2de3hAPqZnGChck= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-r-WmGQu4OA-92FhLEgLAow-1; Thu, 09 Sep 2021 12:18:29 -0400 X-MC-Unique: r-WmGQu4OA-92FhLEgLAow-1 Received: by mail-qk1-f197.google.com with SMTP id 62-20020a3706410000b02903d2cdd9acf0so4899775qkg.21 for ; Thu, 09 Sep 2021 09:18:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=ewBHaw6CXr7fu1kkTtufkK6zzYGeCnEb1o6teII30n0=; b=l7dxO3ulsYpSd4RusXU3umIdt0qf+yey9dBBGG2WNKkggqfmPHIDa3igbhFMWpTJXy z8te74W303H7PSzXeJ0mcyNZN8FMMvX94vVZ7s+UswT5oi5wNZDKX+8eWSSQkjt4vGYy OLqmJB6rD2IkuGp9VxQ0kEna3xTFTs/1UTAAyKz4bMCDVw3uFG5iweeKvaKHxg99RcBv 7fvZCC6jj6ndz4BdQC5lxAwNDPtqQjzfsU8w5cOVJBwEXOIr8TgXaQHD8vQtjxA3PJ9O Gn+UWG6ABFMGIpp4J4/73QcVWgYi7Z3+7vKSRGyfZgEvyZGz2iSCXSkmFEnFcnxOrS+J +NPA== X-Gm-Message-State: AOAM5323LiEYwupndGdDh5+Zx6ki3NH6mV8lTaiwrqQfdKLNXVB+gPRK IvuiI0oIDv9S7RoNaj5GC9ingsF1y4pfbGy5Nj5RNKQ0rHD54P3H0Pto/3nNABN9N9BYnNPZjVL Z6sdbNow4Bzw/mmcXaTtjv5C1D9GO X-Received: by 2002:a05:6214:130a:: with SMTP id a10mr3869438qvv.53.1631204309094; Thu, 09 Sep 2021 09:18:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfrNSaQBwEqiRj+mMqs77Y036x02BGZlpVc98v6yXwCA+EFrazr+WrnxmecQoDDyTFLf7vxw== X-Received: by 2002:a05:6214:130a:: with SMTP id a10mr3869412qvv.53.1631204308888; Thu, 09 Sep 2021 09:18:28 -0700 (PDT) Received: from [192.168.8.206] (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id a9sm1647417qko.27.2021.09.09.09.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 09:18:28 -0700 (PDT) Message-ID: From: Lyude Paul To: Jani Nikula , intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, ville.syrjala@linux.intel.com, manasi.d.navare@intel.com Date: Thu, 09 Sep 2021 12:18:27 -0400 In-Reply-To: <282213f032b3dfe10cf7c461083c26b474f09f0f.camel@redhat.com> References: <649051cb896821147feee91aab1f2abc523c1353.1631191763.git.jani.nikula@intel.com> <282213f032b3dfe10cf7c461083c26b474f09f0f.camel@redhat.com> Organization: Red Hat User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lyude@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Subject: Re: [Intel-gfx] [PATCH v3 02/13] drm/dp: use more of the extended receiver cap X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" …whoops, that was supposed to be: Reviewed-by: Lyude Paul On Thu, 2021-09-09 at 12:18 -0400, Lyude Paul wrote: > I thought I remembered an issue with this but looked up the previous emails, > and it looks like that this change actually should be safe! > > Signed-off-by: Lyude Paul > > On Thu, 2021-09-09 at 15:51 +0300, Jani Nikula wrote: > > Extend the use of extended receiver cap at 0x2200 to cover > > MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides > > the DP 2.0 128b/132b channel encoding cap. > > > > v2: Extend to DP_RECEIVER_CAP_SIZE (Ville) > > > > Cc: Lyude Paul > > Cc: dri-devel@lists.freedesktop.org > > Cc: Manasi Navare > > Cc: Ville Syrjälä > > Signed-off-by: Jani Nikula > > --- > >  drivers/gpu/drm/drm_dp_helper.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/drm_dp_helper.c > > b/drivers/gpu/drm/drm_dp_helper.c > > index 9b2a2961fca8..2e74b02ed96b 100644 > > --- a/drivers/gpu/drm/drm_dp_helper.c > > +++ b/drivers/gpu/drm/drm_dp_helper.c > > @@ -608,7 +608,7 @@ static u8 drm_dp_downstream_port_count(const u8 > > dpcd[DP_RECEIVER_CAP_SIZE]) > >  static int drm_dp_read_extended_dpcd_caps(struct drm_dp_aux *aux, > >                                           u8 dpcd[DP_RECEIVER_CAP_SIZE]) > >  { > > -       u8 dpcd_ext[6]; > > +       u8 dpcd_ext[DP_RECEIVER_CAP_SIZE]; > >         int ret; > >   > >         /* > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat