Re: [PATCH libdrm v4 1/1] amdgpu: move asic id table to a separate file

["Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>]

On 01/06/17 11:27 PM, Li, Samuel wrote:
>> If amdgpu.ids living in the amdgpu directory prevents it from being used by libdrm_radeon (why?), let's put it in a new toplevel directory, e.g.
>> "data".
>>> README is also located in this directory.
>> Not the same thing. It documents things about the header files, and doesn't get installed anywhere.
> I think that is a personal preference.

If you're referring to naming the new directory "data", that's just a
suggestion. Another possibility is to simply put it in the toplevel
directory.

What I wrote about include/drm/README is easily verifiable fact.


>>> My preference is to pass the names only, not to audit from a coder's 
>>> view ...
>> That's not how we do things.
> It is a data file, not really a part of code.

There is nothing magic about it. It's subject to the review process just
like any other file in the repository.

BTW, if you put the file outside of the amdgpu directory, you should
send the patch to the dri-devel mailing list for review as well.


> It shall be your preference to decide how much time you would like to
> spend in auditing the names :)

It shouldn't take as much time as we've spent talking about it in this
thread. :}


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx