From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E433C4338F for ; Thu, 19 Aug 2021 11:48:11 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEEBE6109F for ; Thu, 19 Aug 2021 11:48:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AEEBE6109F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B3BD83139; Thu, 19 Aug 2021 13:48:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="21HVxUCZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2024783139; Thu, 19 Aug 2021 13:48:05 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3FC288321D for ; Thu, 19 Aug 2021 13:47:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=2865fff45f=patrice.chotard@foss.st.com Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17JBkEkn021181; Thu, 19 Aug 2021 13:47:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=aLxVh3baXw/EwC3yiIRiQDu2yt6AnXB4PUJKbKwxpRw=; b=21HVxUCZzWKZqRIjV7NFr8UaQpkBV6lvvAiexEUq5WU1kD3yKXv8Va6wjrdZ8SU5rUNc ClqWr4lEhs7D/felK4/OJjAbra/Dr2EDKLxmHImBCjAZP6iCiWdfAtaw/P0H7rXRs+Jk pYmyzmnP86/5952RP+HQW5LTjgOWRVFNmvSHfas5kNJsxQixiaCCA+kmb5OtQNFtQw+l +bolccmWUC83Frh9XhO/XhpDh4L7UJd1FdXnggHmotjRH1Yg1lB0c2mZgbnkAVu4jpL4 X+e4t+8oo0BlaSoXjhgxd1YvFGELaVrCwl9p4FPB0o5tIlqigAIU6SntYeHNfz69/USe 7Q== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3ah8re47cm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Aug 2021 13:47:54 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id CE32810002A; Thu, 19 Aug 2021 13:47:53 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C3B4F231475; Thu, 19 Aug 2021 13:47:53 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.49) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 19 Aug 2021 13:47:53 +0200 Subject: Re: [PATCH v1 7/7] i2c: stm32f7: compute i2cclk only one time To: CC: Patrick DELAUNAY , U-Boot STM32 , Heiko Schocher References: <20210803100515.29383-1-patrice.chotard@foss.st.com> <20210803100515.29383-8-patrice.chotard@foss.st.com> From: Patrice CHOTARD Message-ID: Date: Thu, 19 Aug 2021 13:47:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210803100515.29383-8-patrice.chotard@foss.st.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.49] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-19_04:2021-08-17, 2021-08-19 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean HI Patrick On 8/3/21 12:05 PM, Patrice Chotard wrote: > From: Patrick Delaunay > > Compute i2cclk only one time in stm32_i2c_compute_timing() > and remove setup parameter (accessible in i2c_priv). > > Signed-off-by: Patrick Delaunay > > Signed-off-by: Patrice Chotard > --- > > drivers/i2c/stm32f7_i2c.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/i2c/stm32f7_i2c.c b/drivers/i2c/stm32f7_i2c.c > index 2b2dae67a3..c6ae65badb 100644 > --- a/drivers/i2c/stm32f7_i2c.c > +++ b/drivers/i2c/stm32f7_i2c.c > @@ -507,14 +507,13 @@ static int stm32_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, > return 0; > } > > -static int stm32_i2c_compute_solutions(struct stm32_i2c_setup *setup, > +static int stm32_i2c_compute_solutions(u32 i2cclk, > + struct stm32_i2c_setup *setup, > const struct stm32_i2c_spec *specs, > struct list_head *solutions) > { > struct stm32_i2c_timings *v; > u32 p_prev = STM32_PRESC_MAX; > - u32 i2cclk = DIV_ROUND_CLOSEST(STM32_NSEC_PER_SEC, > - setup->clock_src); > u32 af_delay_min, af_delay_max; > u16 p, l, a; > int sdadel_min, sdadel_max, scldel_min; > @@ -582,7 +581,8 @@ static int stm32_i2c_compute_solutions(struct stm32_i2c_setup *setup, > return ret; > } > > -static int stm32_i2c_choose_solution(struct stm32_i2c_setup *setup, > +static int stm32_i2c_choose_solution(u32 i2cclk, > + struct stm32_i2c_setup *setup, > const struct stm32_i2c_spec *specs, > struct list_head *solutions, > struct stm32_i2c_timings *s) > @@ -591,8 +591,6 @@ static int stm32_i2c_choose_solution(struct stm32_i2c_setup *setup, > u32 i2cbus = DIV_ROUND_CLOSEST(STM32_NSEC_PER_SEC, > setup->speed_freq); > u32 clk_error_prev = i2cbus; > - u32 i2cclk = DIV_ROUND_CLOSEST(STM32_NSEC_PER_SEC, > - setup->clock_src); > u32 clk_min, clk_max; > u32 af_delay_min; > u32 dnf_delay; > @@ -679,9 +677,9 @@ static const struct stm32_i2c_spec *get_specs(u32 rate) > } > > static int stm32_i2c_compute_timing(struct stm32_i2c_priv *i2c_priv, > - struct stm32_i2c_setup *setup, > struct stm32_i2c_timings *output) > { > + struct stm32_i2c_setup *setup = &i2c_priv->setup; > const struct stm32_i2c_spec *specs; > struct stm32_i2c_timings *v, *_v; > struct list_head solutions; > @@ -712,11 +710,11 @@ static int stm32_i2c_compute_timing(struct stm32_i2c_priv *i2c_priv, > } > > INIT_LIST_HEAD(&solutions); > - ret = stm32_i2c_compute_solutions(setup, specs, &solutions); > + ret = stm32_i2c_compute_solutions(i2cclk, setup, specs, &solutions); > if (ret) > goto exit; > > - ret = stm32_i2c_choose_solution(setup, specs, &solutions, output); > + ret = stm32_i2c_choose_solution(i2cclk, setup, specs, &solutions, output); > if (ret) > goto exit; > > @@ -761,7 +759,7 @@ static int stm32_i2c_setup_timing(struct stm32_i2c_priv *i2c_priv, > } > > do { > - ret = stm32_i2c_compute_timing(i2c_priv, setup, timing); > + ret = stm32_i2c_compute_timing(i2c_priv, timing); > if (ret) { > log_debug("failed to compute I2C timings.\n"); > if (setup->speed_freq > I2C_SPEED_STANDARD_RATE) { > Reviewed-by: Patrice Chotard Thanks Patrice