From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2CA6C433E0 for ; Fri, 5 Mar 2021 11:12:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A021365015 for ; Fri, 5 Mar 2021 11:12:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbhCELLe (ORCPT ); Fri, 5 Mar 2021 06:11:34 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2622 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhCELLU (ORCPT ); Fri, 5 Mar 2021 06:11:20 -0500 Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DsQ125bBNz67jwS; Fri, 5 Mar 2021 19:07:02 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 5 Mar 2021 12:11:19 +0100 Received: from [10.47.8.182] (10.47.8.182) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 5 Mar 2021 11:11:17 +0000 Subject: Re: [PATCH v8 3/3] perf vendor events arm64: Add "_" to the event name, which starts with a number To: Shunsuke Nakamura , , , , , , , , , , CC: , References: <20210305101841.3133721-1-nakamura.shun@fujitsu.com> <20210305101841.3133721-4-nakamura.shun@fujitsu.com> From: John Garry Message-ID: Date: Fri, 5 Mar 2021 11:09:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210305101841.3133721-4-nakamura.shun@fujitsu.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.8.182] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2021 10:18, Shunsuke Nakamura wrote: > The perf parser does not support event names that start with a number. > This patch adds "_" to the event name, which starts with a number. > > Signed-off-by: Shunsuke Nakamura I think that this can be folded into patch 2/3, and my reveiwed-by tag still stands for patch 2/3. Thanks > --- > .../pmu-events/arch/arm64/fujitsu/a64fx/other.json | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > index 68b8e46d6140..10c823ac26cc 100644 > --- a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > +++ b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > @@ -98,31 +98,31 @@ > { > "PublicDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only.", > "EventCode": "0x190", > - "EventName": "0INST_COMMIT", > + "EventName": "_0INST_COMMIT", > "BriefDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only." > }, > { > "PublicDescription": "This event counts every cycle that one instruction is committed.", > "EventCode": "0x191", > - "EventName": "1INST_COMMIT", > + "EventName": "_1INST_COMMIT", > "BriefDescription": "This event counts every cycle that one instruction is committed." > }, > { > "PublicDescription": "This event counts every cycle that two instructions are committed.", > "EventCode": "0x192", > - "EventName": "2INST_COMMIT", > + "EventName": "_2INST_COMMIT", > "BriefDescription": "This event counts every cycle that two instructions are committed." > }, > { > "PublicDescription": "This event counts every cycle that three instructions are committed.", > "EventCode": "0x193", > - "EventName": "3INST_COMMIT", > + "EventName": "_3INST_COMMIT", > "BriefDescription": "This event counts every cycle that three instructions are committed." > }, > { > "PublicDescription": "This event counts every cycle that four instructions are committed.", > "EventCode": "0x194", > - "EventName": "4INST_COMMIT", > + "EventName": "_4INST_COMMIT", > "BriefDescription": "This event counts every cycle that four instructions are committed." > }, > { > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EB4CC433DB for ; Fri, 5 Mar 2021 11:13:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C89C665016 for ; Fri, 5 Mar 2021 11:13:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C89C665016 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ea7mAgi2VbSDZ2PnChYBbw/kTaYl7ehFbCOruQknnPY=; b=ngsB/uSsTQTNNiBv9c8/uFYvA rlQiTnuwpxSCFKt/AOO9DvUI9utmbx2BGgtLXj6bqpOvEM/flK0dqMtKvt2m0PgU/wct4Du714LqR sljhbUQ3BWqXnreq/U0EpM4fuW6FME6e772JZ0zR31FK82+/3QlnSjgZQsQm6dyogq+hG8x7xpmOR sqRs3esFHmtwsOytIFS1ROe/K12JORFl402kl9Ps1Gk9TnJuXSIdsKV+fEiBgsufILDSwUztqWbz7 T0hHoGhBgkYYJhVOfhEBdt4OOWC8xg+Fnne7XCxc7bH9BnUoKZM5Vp541HlaHuRbfzMOrqTpWaAl3 628oDoMiQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lI8Mk-00Ehsr-Ca; Fri, 05 Mar 2021 11:11:30 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lI8Mb-00Ehqx-1T for linux-arm-kernel@lists.infradead.org; Fri, 05 Mar 2021 11:11:24 +0000 Received: from fraeml710-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DsQ125bBNz67jwS; Fri, 5 Mar 2021 19:07:02 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml710-chm.china.huawei.com (10.206.15.59) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 5 Mar 2021 12:11:19 +0100 Received: from [10.47.8.182] (10.47.8.182) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 5 Mar 2021 11:11:17 +0000 Subject: Re: [PATCH v8 3/3] perf vendor events arm64: Add "_" to the event name, which starts with a number To: Shunsuke Nakamura , , , , , , , , , , CC: , References: <20210305101841.3133721-1-nakamura.shun@fujitsu.com> <20210305101841.3133721-4-nakamura.shun@fujitsu.com> From: John Garry Message-ID: Date: Fri, 5 Mar 2021 11:09:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210305101841.3133721-4-nakamura.shun@fujitsu.com> Content-Language: en-US X-Originating-IP: [10.47.8.182] X-ClientProxiedBy: lhreml713-chm.china.huawei.com (10.201.108.64) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210305_111122_526526_BE10CF36 X-CRM114-Status: GOOD ( 16.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/03/2021 10:18, Shunsuke Nakamura wrote: > The perf parser does not support event names that start with a number. > This patch adds "_" to the event name, which starts with a number. > > Signed-off-by: Shunsuke Nakamura I think that this can be folded into patch 2/3, and my reveiwed-by tag still stands for patch 2/3. Thanks > --- > .../pmu-events/arch/arm64/fujitsu/a64fx/other.json | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > index 68b8e46d6140..10c823ac26cc 100644 > --- a/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > +++ b/tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json > @@ -98,31 +98,31 @@ > { > "PublicDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only.", > "EventCode": "0x190", > - "EventName": "0INST_COMMIT", > + "EventName": "_0INST_COMMIT", > "BriefDescription": "This event counts every cycle that no instruction was committed, but counts at the time when commits MOVPRFX only." > }, > { > "PublicDescription": "This event counts every cycle that one instruction is committed.", > "EventCode": "0x191", > - "EventName": "1INST_COMMIT", > + "EventName": "_1INST_COMMIT", > "BriefDescription": "This event counts every cycle that one instruction is committed." > }, > { > "PublicDescription": "This event counts every cycle that two instructions are committed.", > "EventCode": "0x192", > - "EventName": "2INST_COMMIT", > + "EventName": "_2INST_COMMIT", > "BriefDescription": "This event counts every cycle that two instructions are committed." > }, > { > "PublicDescription": "This event counts every cycle that three instructions are committed.", > "EventCode": "0x193", > - "EventName": "3INST_COMMIT", > + "EventName": "_3INST_COMMIT", > "BriefDescription": "This event counts every cycle that three instructions are committed." > }, > { > "PublicDescription": "This event counts every cycle that four instructions are committed.", > "EventCode": "0x194", > - "EventName": "4INST_COMMIT", > + "EventName": "_4INST_COMMIT", > "BriefDescription": "This event counts every cycle that four instructions are committed." > }, > { > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel