From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C91FAC33CAF for ; Sun, 19 Jan 2020 05:43:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 863152071C for ; Sun, 19 Jan 2020 05:43:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726465AbgASFdI (ORCPT ); Sun, 19 Jan 2020 00:33:08 -0500 Received: from smtprelay0229.hostedemail.com ([216.40.44.229]:47155 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725792AbgASFdH (ORCPT ); Sun, 19 Jan 2020 00:33:07 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 43A46182251C0; Sun, 19 Jan 2020 05:33:06 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wheel05_8f543acaa5616 X-Filterd-Recvd-Size: 1631 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Sun, 19 Jan 2020 05:33:04 +0000 (UTC) Message-ID: Subject: Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it From: Joe Perches To: Simon Fong , abbotti@mev.co.uk Cc: hsweeten@visionengravers.com, gregkh@linuxfoundation.org, colin.king@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 18 Jan 2020 21:32:06 -0800 In-Reply-To: <20200119035243.7819-1-simon.fongnt@gmail.com> References: <20200119035243.7819-1-simon.fongnt@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-01-19 at 11:52 +0800, Simon Fong wrote: > Clean up long line and align it [] > diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c [] > @@ -204,7 +204,8 @@ struct usbdux_private { > struct mutex mut; > }; > > -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs) Why do you believe this to be a long line? It's only 63 characters. 1 2 3 4 5 6 7 1234567890123456789012345678901234567890123456789012345678901234567890 static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs) > +static void usbdux_unlink_urbs(struct urb **urbs, > + int num_urbs) > { > int i; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21B2C33CB1 for ; Sun, 19 Jan 2020 16:08:52 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C857820678 for ; Sun, 19 Jan 2020 16:08:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C857820678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6B04985193; Sun, 19 Jan 2020 16:08:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2GINuAOYI4dv; Sun, 19 Jan 2020 16:08:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3F65684F2E; Sun, 19 Jan 2020 16:08:49 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id D45421BF28B for ; Sun, 19 Jan 2020 16:08:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C8CA984C09 for ; Sun, 19 Jan 2020 16:08:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bg1QsNhUAa7U for ; Sun, 19 Jan 2020 16:08:46 +0000 (UTC) X-Greylist: delayed 04:39:59 by SQLgrey-1.7.6 Received: from smtprelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by whitealder.osuosl.org (Postfix) with ESMTPS id 27AB384BF1 for ; Sun, 19 Jan 2020 16:08:45 +0000 (UTC) Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave07.hostedemail.com (Postfix) with ESMTP id 45F931801C1BC for ; Sun, 19 Jan 2020 05:33:09 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 43A46182251C0; Sun, 19 Jan 2020 05:33:06 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wheel05_8f543acaa5616 X-Filterd-Recvd-Size: 1631 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf02.hostedemail.com (Postfix) with ESMTPA; Sun, 19 Jan 2020 05:33:04 +0000 (UTC) Message-ID: Subject: Re: [PATCH 3/3] Staging: comedi: usbdux: cleanup long line and align it From: Joe Perches To: Simon Fong , abbotti@mev.co.uk Date: Sat, 18 Jan 2020 21:32:06 -0800 In-Reply-To: <20200119035243.7819-1-simon.fongnt@gmail.com> References: <20200119035243.7819-1-simon.fongnt@gmail.com> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, colin.king@canonical.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, 2020-01-19 at 11:52 +0800, Simon Fong wrote: > Clean up long line and align it [] > diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c [] > @@ -204,7 +204,8 @@ struct usbdux_private { > struct mutex mut; > }; > > -static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs) Why do you believe this to be a long line? It's only 63 characters. 1 2 3 4 5 6 7 1234567890123456789012345678901234567890123456789012345678901234567890 static void usbdux_unlink_urbs(struct urb **urbs, int num_urbs) > +static void usbdux_unlink_urbs(struct urb **urbs, > + int num_urbs) > { > int i; > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel