From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40E61C433E7 for ; Fri, 16 Oct 2020 07:42:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE0DA207F7 for ; Fri, 16 Oct 2020 07:42:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="qafhaKQk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404762AbgJPHm1 (ORCPT ); Fri, 16 Oct 2020 03:42:27 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:2632 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404710AbgJPHm1 (ORCPT ); Fri, 16 Oct 2020 03:42:27 -0400 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 16 Oct 2020 00:42:14 -0700 Received: from [10.2.49.77] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 16 Oct 2020 07:42:17 +0000 Subject: Re: [PATCH v2 01/17] drm/exynos: Stop using frame_vector helpers To: Daniel Vetter , DRI Development , LKML CC: , , , , , , Daniel Vetter , Jason Gunthorpe , Inki Dae , Joonyoung Shim , "Seung-Woo Kim" , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , "Andrew Morton" , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jan Kara , Dan Williams References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-2-daniel.vetter@ffwll.ch> From: John Hubbard Message-ID: Date: Fri, 16 Oct 2020 00:42:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201009075934.3509076-2-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602834134; bh=0aE9d/+DUnCDZnC0MmsV9767F6olBrZ/z/bqT8CABIE=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=qafhaKQkqbDz6B1AQvEqkAlsZ2wvvxxy3liQgg/I2n/ULg20xCUiIlLAGKfOrDFbr ceoOhJqnaFxeEBdV9ZyHoihaNP6Y7fwttq1CADxMzc02pGDu6VhiYT4r+niYN2SgmQ uGmPACXn3SSz5j5dFYjRoZY/+Mrq7tjnF4FXvsh2m4wH2AH17u27/ZyvctCi5w00pi 0KLehFCXYJ589hr30t/KynvRtlNSSPHafzdq5WTQVzdi6M+21sKkrRvffEX2wbaeq0 VgPWKESwn1uBRAiy722SCSSUnBZPuT7/iCtsX1reQo7i7IUd5KtWfD+25tG5clM1pU nny43JIsIiugw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/9/20 12:59 AM, Daniel Vetter wrote: > All we need are a pages array, pin_user_pages_fast can give us that > directly. Plus this avoids the entire raw pfn side of get_vaddr_frames. >=20 > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Andrew Morton > Cc: John Hubbard > Cc: J=C3=A9r=C3=B4me Glisse > Cc: Jan Kara > Cc: Dan Williams > Cc: linux-mm@kvack.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-media@vger.kernel.org > -- > v2: Use unpin_user_pages_dirty_lock (John) > --- > drivers/gpu/drm/exynos/Kconfig | 1 - > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 47 +++++++++++-------------- > 2 files changed, 20 insertions(+), 28 deletions(-) >=20 Looks good. Reviewed-by: John Hubbard thanks, --=20 John Hubbard NVIDIA > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kcon= fig > index 6417f374b923..43257ef3c09d 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -88,7 +88,6 @@ comment "Sub-drivers" > config DRM_EXYNOS_G2D > bool "G2D" > depends on VIDEO_SAMSUNG_S5P_G2D=3Dn || COMPILE_TEST > - select FRAME_VECTOR > help > Choose this option if you want to use Exynos G2D for DRM. > =20 > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/ex= ynos/exynos_drm_g2d.c > index 967a5cdc120e..ecede41af9b9 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -205,7 +205,8 @@ struct g2d_cmdlist_userptr { > dma_addr_t dma_addr; > unsigned long userptr; > unsigned long size; > - struct frame_vector *vec; > + struct page **pages; > + unsigned int npages; > struct sg_table *sgt; > atomic_t refcount; > bool in_pool; > @@ -378,7 +379,6 @@ static void g2d_userptr_put_dma_addr(struct g2d_data = *g2d, > bool force) > { > struct g2d_cmdlist_userptr *g2d_userptr =3D obj; > - struct page **pages; > =20 > if (!obj) > return; > @@ -398,15 +398,9 @@ static void g2d_userptr_put_dma_addr(struct g2d_data= *g2d, > dma_unmap_sgtable(to_dma_dev(g2d->drm_dev), g2d_userptr->sgt, > DMA_BIDIRECTIONAL, 0); > =20 > - pages =3D frame_vector_pages(g2d_userptr->vec); > - if (!IS_ERR(pages)) { > - int i; > - > - for (i =3D 0; i < frame_vector_count(g2d_userptr->vec); i++) > - set_page_dirty_lock(pages[i]); > - } > - put_vaddr_frames(g2d_userptr->vec); > - frame_vector_destroy(g2d_userptr->vec); > + unpin_user_pages_dirty_lock(g2d_userptr->pages, g2d_userptr->npages, > + true); > + kvfree(g2d_userptr->pages); > =20 > if (!g2d_userptr->out_of_list) > list_del_init(&g2d_userptr->list); > @@ -474,35 +468,34 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct = g2d_data *g2d, > offset =3D userptr & ~PAGE_MASK; > end =3D PAGE_ALIGN(userptr + size); > npages =3D (end - start) >> PAGE_SHIFT; > - g2d_userptr->vec =3D frame_vector_create(npages); > - if (!g2d_userptr->vec) { > + g2d_userptr->pages =3D kvmalloc_array(npages, sizeof(*g2d_userptr->page= s), > + GFP_KERNEL); > + if (!g2d_userptr->pages) { > ret =3D -ENOMEM; > goto err_free; > } > =20 > - ret =3D get_vaddr_frames(start, npages, FOLL_FORCE | FOLL_WRITE, > - g2d_userptr->vec); > + ret =3D pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRITE, > + g2d_userptr->pages); > if (ret !=3D npages) { > DRM_DEV_ERROR(g2d->dev, > "failed to get user pages from userptr.\n"); > if (ret < 0) > - goto err_destroy_framevec; > - ret =3D -EFAULT; > - goto err_put_framevec; > - } > - if (frame_vector_to_pages(g2d_userptr->vec) < 0) { > + goto err_destroy_pages; > + npages =3D ret; > ret =3D -EFAULT; > - goto err_put_framevec; > + goto err_unpin_pages; > } > + g2d_userptr->npages =3D npages; > =20 > sgt =3D kzalloc(sizeof(*sgt), GFP_KERNEL); > if (!sgt) { > ret =3D -ENOMEM; > - goto err_put_framevec; > + goto err_unpin_pages; > } > =20 > ret =3D sg_alloc_table_from_pages(sgt, > - frame_vector_pages(g2d_userptr->vec), > + g2d_userptr->pages, > npages, offset, size, GFP_KERNEL); > if (ret < 0) { > DRM_DEV_ERROR(g2d->dev, "failed to get sgt from pages.\n"); > @@ -538,11 +531,11 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct = g2d_data *g2d, > err_free_sgt: > kfree(sgt); > =20 > -err_put_framevec: > - put_vaddr_frames(g2d_userptr->vec); > +err_unpin_pages: > + unpin_user_pages(g2d_userptr->pages, npages); > =20 > -err_destroy_framevec: > - frame_vector_destroy(g2d_userptr->vec); > +err_destroy_pages: > + kvfree(g2d_userptr->pages); > =20 > err_free: > kfree(g2d_userptr); >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF555C433DF for ; Fri, 16 Oct 2020 07:44:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECE40207F7 for ; Fri, 16 Oct 2020 07:44:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vRoaBtoP"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="qafhaKQk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECE40207F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Il2keZ9TrlJ4ziO15qFHZUh3sCJBHA9qXNHruM2mdi4=; b=vRoaBtoPFJclyEhbbXJcPhwMR tBJHcx2novJb9zKFQJhfSL7VClkeMvNwJvfhtQZqKJgBwk4mPXVAyQ8L4og07NR7nrKZgGJqsK64y V/lYKg7PV8WxpA3AYkmX8psP6UJgEzUOkCqbBJpKoO/hsCMJVCReI+nPwRfbQafdSz9Q5M4i7F8rp uqRWmncTpEjnItkb/hJwmJzQoOrJpJUPkwFSvHKITK95R3FlwEnvaabkZ6dIHW5jMMIN70UOuVCzk pIA4Ag006VUWh/h1WHyCPrfR0wadlUEGeWr1f0BwU8PRCHUy1HDcbUapAlnMGYkjX2F9tHqe0ms+u W4S3rjLcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTKNl-0006sC-0X; Fri, 16 Oct 2020 07:42:33 +0000 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTKNh-0006r4-Vt for linux-arm-kernel@lists.infradead.org; Fri, 16 Oct 2020 07:42:31 +0000 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 16 Oct 2020 00:42:14 -0700 Received: from [10.2.49.77] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 16 Oct 2020 07:42:17 +0000 Subject: Re: [PATCH v2 01/17] drm/exynos: Stop using frame_vector helpers To: Daniel Vetter , DRI Development , LKML References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-2-daniel.vetter@ffwll.ch> From: John Hubbard Message-ID: Date: Fri, 16 Oct 2020 00:42:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201009075934.3509076-2-daniel.vetter@ffwll.ch> Content-Language: en-US X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602834134; bh=0aE9d/+DUnCDZnC0MmsV9767F6olBrZ/z/bqT8CABIE=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=qafhaKQkqbDz6B1AQvEqkAlsZ2wvvxxy3liQgg/I2n/ULg20xCUiIlLAGKfOrDFbr ceoOhJqnaFxeEBdV9ZyHoihaNP6Y7fwttq1CADxMzc02pGDu6VhiYT4r+niYN2SgmQ uGmPACXn3SSz5j5dFYjRoZY/+Mrq7tjnF4FXvsh2m4wH2AH17u27/ZyvctCi5w00pi 0KLehFCXYJ589hr30t/KynvRtlNSSPHafzdq5WTQVzdi6M+21sKkrRvffEX2wbaeq0 VgPWKESwn1uBRAiy722SCSSUnBZPuT7/iCtsX1reQo7i7IUd5KtWfD+25tG5clM1pU nny43JIsIiugw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201016_034230_151024_321F8CF5 X-CRM114-Status: GOOD ( 26.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jan Kara , Joonyoung Shim , kvm@vger.kernel.org, Jason Gunthorpe , Seung-Woo Kim , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Krzysztof Kozlowski , Inki Dae , linux-mm@kvack.org, Kyungmin Park , Kukjin Kim , Daniel Vetter , Andrew Morton , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTAvOS8yMCAxMjo1OSBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBBbGwgd2UgbmVlZCBh cmUgYSBwYWdlcyBhcnJheSwgcGluX3VzZXJfcGFnZXNfZmFzdCBjYW4gZ2l2ZSB1cyB0aGF0Cj4g ZGlyZWN0bHkuIFBsdXMgdGhpcyBhdm9pZHMgdGhlIGVudGlyZSByYXcgcGZuIHNpZGUgb2YgZ2V0 X3ZhZGRyX2ZyYW1lcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGludGVsLmNvbT4KPiBDYzogSmFzb24gR3VudGhvcnBlIDxqZ2dAemllcGUuY2E+Cj4g Q2M6IElua2kgRGFlIDxpbmtpLmRhZUBzYW1zdW5nLmNvbT4KPiBDYzogSm9vbnlvdW5nIFNoaW0g PGp5MDkyMi5zaGltQHNhbXN1bmcuY29tPgo+IENjOiBTZXVuZy1Xb28gS2ltIDxzdzAzMTIua2lt QHNhbXN1bmcuY29tPgo+IENjOiBLeXVuZ21pbiBQYXJrIDxreXVuZ21pbi5wYXJrQHNhbXN1bmcu Y29tPgo+IENjOiBLdWtqaW4gS2ltIDxrZ2VuZUBrZXJuZWwub3JnPgo+IENjOiBLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+Cj4gQ2M6IEFuZHJldyBNb3J0b24gPGFrcG1AbGlu dXgtZm91bmRhdGlvbi5vcmc+Cj4gQ2M6IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNv bT4KPiBDYzogSsOpcsO0bWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhhdC5jb20+Cj4gQ2M6IEphbiBL YXJhIDxqYWNrQHN1c2UuY3o+Cj4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50 ZWwuY29tPgo+IENjOiBsaW51eC1tbUBrdmFjay5vcmcKPiBDYzogbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCj4gQ2M6IGxpbnV4LXNhbXN1bmctc29jQHZnZXIua2VybmVsLm9y Zwo+IENjOiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcKPiAtLQo+IHYyOiBVc2UgdW5waW5f dXNlcl9wYWdlc19kaXJ0eV9sb2NrIChKb2huKQo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2V4 eW5vcy9LY29uZmlnICAgICAgICAgIHwgIDEgLQo+ICAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9l eHlub3NfZHJtX2cyZC5jIHwgNDcgKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ICAgMiBmaWxl cyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyOCBkZWxldGlvbnMoLSkKPiAKCkxvb2tzIGdv b2QuCgpSZXZpZXdlZC1ieTogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgoKdGhh bmtzLAotLSAKSm9obiBIdWJiYXJkCk5WSURJQQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2V4eW5vcy9LY29uZmlnIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmlnCj4gaW5k ZXggNjQxN2YzNzRiOTIzLi40MzI1N2VmM2MwOWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2V4eW5vcy9LY29uZmlnCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmln Cj4gQEAgLTg4LDcgKzg4LDYgQEAgY29tbWVudCAiU3ViLWRyaXZlcnMiCj4gICBjb25maWcgRFJN X0VYWU5PU19HMkQKPiAgIAlib29sICJHMkQiCj4gICAJZGVwZW5kcyBvbiBWSURFT19TQU1TVU5H X1M1UF9HMkQ9biB8fCBDT01QSUxFX1RFU1QKPiAtCXNlbGVjdCBGUkFNRV9WRUNUT1IKPiAgIAlo ZWxwCj4gICAJICBDaG9vc2UgdGhpcyBvcHRpb24gaWYgeW91IHdhbnQgdG8gdXNlIEV4eW5vcyBH MkQgZm9yIERSTS4KPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4 eW5vc19kcm1fZzJkLmMgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMK PiBpbmRleCA5NjdhNWNkYzEyMGUuLmVjZWRlNDFhZjliOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiBAQCAtMjA1LDcgKzIwNSw4IEBAIHN0cnVjdCBnMmRf Y21kbGlzdF91c2VycHRyIHsKPiAgIAlkbWFfYWRkcl90CQlkbWFfYWRkcjsKPiAgIAl1bnNpZ25l ZCBsb25nCQl1c2VycHRyOwo+ICAgCXVuc2lnbmVkIGxvbmcJCXNpemU7Cj4gLQlzdHJ1Y3QgZnJh bWVfdmVjdG9yCSp2ZWM7Cj4gKwlzdHJ1Y3QgcGFnZQkJKipwYWdlczsKPiArCXVuc2lnbmVkIGlu dAkJbnBhZ2VzOwo+ICAgCXN0cnVjdCBzZ190YWJsZQkJKnNndDsKPiAgIAlhdG9taWNfdAkJcmVm Y291bnQ7Cj4gICAJYm9vbAkJCWluX3Bvb2w7Cj4gQEAgLTM3OCw3ICszNzksNiBAQCBzdGF0aWMg dm9pZCBnMmRfdXNlcnB0cl9wdXRfZG1hX2FkZHIoc3RydWN0IGcyZF9kYXRhICpnMmQsCj4gICAJ CQkJCWJvb2wgZm9yY2UpCj4gICB7Cj4gICAJc3RydWN0IGcyZF9jbWRsaXN0X3VzZXJwdHIgKmcy ZF91c2VycHRyID0gb2JqOwo+IC0Jc3RydWN0IHBhZ2UgKipwYWdlczsKPiAgIAo+ICAgCWlmICgh b2JqKQo+ICAgCQlyZXR1cm47Cj4gQEAgLTM5OCwxNSArMzk4LDkgQEAgc3RhdGljIHZvaWQgZzJk X3VzZXJwdHJfcHV0X2RtYV9hZGRyKHN0cnVjdCBnMmRfZGF0YSAqZzJkLAo+ICAgCWRtYV91bm1h cF9zZ3RhYmxlKHRvX2RtYV9kZXYoZzJkLT5kcm1fZGV2KSwgZzJkX3VzZXJwdHItPnNndCwKPiAg IAkJCSAgRE1BX0JJRElSRUNUSU9OQUwsIDApOwo+ICAgCj4gLQlwYWdlcyA9IGZyYW1lX3ZlY3Rv cl9wYWdlcyhnMmRfdXNlcnB0ci0+dmVjKTsKPiAtCWlmICghSVNfRVJSKHBhZ2VzKSkgewo+IC0J CWludCBpOwo+IC0KPiAtCQlmb3IgKGkgPSAwOyBpIDwgZnJhbWVfdmVjdG9yX2NvdW50KGcyZF91 c2VycHRyLT52ZWMpOyBpKyspCj4gLQkJCXNldF9wYWdlX2RpcnR5X2xvY2socGFnZXNbaV0pOwo+ IC0JfQo+IC0JcHV0X3ZhZGRyX2ZyYW1lcyhnMmRfdXNlcnB0ci0+dmVjKTsKPiAtCWZyYW1lX3Zl Y3Rvcl9kZXN0cm95KGcyZF91c2VycHRyLT52ZWMpOwo+ICsJdW5waW5fdXNlcl9wYWdlc19kaXJ0 eV9sb2NrKGcyZF91c2VycHRyLT5wYWdlcywgZzJkX3VzZXJwdHItPm5wYWdlcywKPiArCQkJCSAg ICB0cnVlKTsKPiArCWt2ZnJlZShnMmRfdXNlcnB0ci0+cGFnZXMpOwo+ICAgCj4gICAJaWYgKCFn MmRfdXNlcnB0ci0+b3V0X29mX2xpc3QpCj4gICAJCWxpc3RfZGVsX2luaXQoJmcyZF91c2VycHRy LT5saXN0KTsKPiBAQCAtNDc0LDM1ICs0NjgsMzQgQEAgc3RhdGljIGRtYV9hZGRyX3QgKmcyZF91 c2VycHRyX2dldF9kbWFfYWRkcihzdHJ1Y3QgZzJkX2RhdGEgKmcyZCwKPiAgIAlvZmZzZXQgPSB1 c2VycHRyICYgflBBR0VfTUFTSzsKPiAgIAllbmQgPSBQQUdFX0FMSUdOKHVzZXJwdHIgKyBzaXpl KTsKPiAgIAlucGFnZXMgPSAoZW5kIC0gc3RhcnQpID4+IFBBR0VfU0hJRlQ7Cj4gLQlnMmRfdXNl cnB0ci0+dmVjID0gZnJhbWVfdmVjdG9yX2NyZWF0ZShucGFnZXMpOwo+IC0JaWYgKCFnMmRfdXNl cnB0ci0+dmVjKSB7Cj4gKwlnMmRfdXNlcnB0ci0+cGFnZXMgPSBrdm1hbGxvY19hcnJheShucGFn ZXMsIHNpemVvZigqZzJkX3VzZXJwdHItPnBhZ2VzKSwKPiArCQkJCQkgICAgR0ZQX0tFUk5FTCk7 Cj4gKwlpZiAoIWcyZF91c2VycHRyLT5wYWdlcykgewo+ICAgCQlyZXQgPSAtRU5PTUVNOwo+ICAg CQlnb3RvIGVycl9mcmVlOwo+ICAgCX0KPiAgIAo+IC0JcmV0ID0gZ2V0X3ZhZGRyX2ZyYW1lcyhz dGFydCwgbnBhZ2VzLCBGT0xMX0ZPUkNFIHwgRk9MTF9XUklURSwKPiAtCQlnMmRfdXNlcnB0ci0+ dmVjKTsKPiArCXJldCA9IHBpbl91c2VyX3BhZ2VzX2Zhc3Qoc3RhcnQsIG5wYWdlcywgRk9MTF9G T1JDRSB8IEZPTExfV1JJVEUsCj4gKwkJCQkgIGcyZF91c2VycHRyLT5wYWdlcyk7Cj4gICAJaWYg KHJldCAhPSBucGFnZXMpIHsKPiAgIAkJRFJNX0RFVl9FUlJPUihnMmQtPmRldiwKPiAgIAkJCSAg ICAgICJmYWlsZWQgdG8gZ2V0IHVzZXIgcGFnZXMgZnJvbSB1c2VycHRyLlxuIik7Cj4gICAJCWlm IChyZXQgPCAwKQo+IC0JCQlnb3RvIGVycl9kZXN0cm95X2ZyYW1ldmVjOwo+IC0JCXJldCA9IC1F RkFVTFQ7Cj4gLQkJZ290byBlcnJfcHV0X2ZyYW1ldmVjOwo+IC0JfQo+IC0JaWYgKGZyYW1lX3Zl Y3Rvcl90b19wYWdlcyhnMmRfdXNlcnB0ci0+dmVjKSA8IDApIHsKPiArCQkJZ290byBlcnJfZGVz dHJveV9wYWdlczsKPiArCQlucGFnZXMgPSByZXQ7Cj4gICAJCXJldCA9IC1FRkFVTFQ7Cj4gLQkJ Z290byBlcnJfcHV0X2ZyYW1ldmVjOwo+ICsJCWdvdG8gZXJyX3VucGluX3BhZ2VzOwo+ICAgCX0K PiArCWcyZF91c2VycHRyLT5ucGFnZXMgPSBucGFnZXM7Cj4gICAKPiAgIAlzZ3QgPSBremFsbG9j KHNpemVvZigqc2d0KSwgR0ZQX0tFUk5FTCk7Cj4gICAJaWYgKCFzZ3QpIHsKPiAgIAkJcmV0ID0g LUVOT01FTTsKPiAtCQlnb3RvIGVycl9wdXRfZnJhbWV2ZWM7Cj4gKwkJZ290byBlcnJfdW5waW5f cGFnZXM7Cj4gICAJfQo+ICAgCj4gICAJcmV0ID0gc2dfYWxsb2NfdGFibGVfZnJvbV9wYWdlcyhz Z3QsCj4gLQkJCQkJZnJhbWVfdmVjdG9yX3BhZ2VzKGcyZF91c2VycHRyLT52ZWMpLAo+ICsJCQkJ CWcyZF91c2VycHRyLT5wYWdlcywKPiAgIAkJCQkJbnBhZ2VzLCBvZmZzZXQsIHNpemUsIEdGUF9L RVJORUwpOwo+ICAgCWlmIChyZXQgPCAwKSB7Cj4gICAJCURSTV9ERVZfRVJST1IoZzJkLT5kZXYs ICJmYWlsZWQgdG8gZ2V0IHNndCBmcm9tIHBhZ2VzLlxuIik7Cj4gQEAgLTUzOCwxMSArNTMxLDEx IEBAIHN0YXRpYyBkbWFfYWRkcl90ICpnMmRfdXNlcnB0cl9nZXRfZG1hX2FkZHIoc3RydWN0IGcy ZF9kYXRhICpnMmQsCj4gICBlcnJfZnJlZV9zZ3Q6Cj4gICAJa2ZyZWUoc2d0KTsKPiAgIAo+IC1l cnJfcHV0X2ZyYW1ldmVjOgo+IC0JcHV0X3ZhZGRyX2ZyYW1lcyhnMmRfdXNlcnB0ci0+dmVjKTsK PiArZXJyX3VucGluX3BhZ2VzOgo+ICsJdW5waW5fdXNlcl9wYWdlcyhnMmRfdXNlcnB0ci0+cGFn ZXMsIG5wYWdlcyk7Cj4gICAKPiAtZXJyX2Rlc3Ryb3lfZnJhbWV2ZWM6Cj4gLQlmcmFtZV92ZWN0 b3JfZGVzdHJveShnMmRfdXNlcnB0ci0+dmVjKTsKPiArZXJyX2Rlc3Ryb3lfcGFnZXM6Cj4gKwlr dmZyZWUoZzJkX3VzZXJwdHItPnBhZ2VzKTsKPiAgIAo+ICAgZXJyX2ZyZWU6Cj4gICAJa2ZyZWUo ZzJkX3VzZXJwdHIpOwo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B9FBC433DF for ; Fri, 16 Oct 2020 07:42:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 830FC20878 for ; Fri, 16 Oct 2020 07:42:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="qafhaKQk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 830FC20878 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 768826EA87; Fri, 16 Oct 2020 07:42:29 +0000 (UTC) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 606BD6EA87 for ; Fri, 16 Oct 2020 07:42:28 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 16 Oct 2020 00:42:14 -0700 Received: from [10.2.49.77] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 16 Oct 2020 07:42:17 +0000 Subject: Re: [PATCH v2 01/17] drm/exynos: Stop using frame_vector helpers To: Daniel Vetter , DRI Development , LKML References: <20201009075934.3509076-1-daniel.vetter@ffwll.ch> <20201009075934.3509076-2-daniel.vetter@ffwll.ch> From: John Hubbard Message-ID: Date: Fri, 16 Oct 2020 00:42:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201009075934.3509076-2-daniel.vetter@ffwll.ch> Content-Language: en-US X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1602834134; bh=0aE9d/+DUnCDZnC0MmsV9767F6olBrZ/z/bqT8CABIE=; h=Subject:To:CC:References:From:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=qafhaKQkqbDz6B1AQvEqkAlsZ2wvvxxy3liQgg/I2n/ULg20xCUiIlLAGKfOrDFbr ceoOhJqnaFxeEBdV9ZyHoihaNP6Y7fwttq1CADxMzc02pGDu6VhiYT4r+niYN2SgmQ uGmPACXn3SSz5j5dFYjRoZY/+Mrq7tjnF4FXvsh2m4wH2AH17u27/ZyvctCi5w00pi 0KLehFCXYJ589hr30t/KynvRtlNSSPHafzdq5WTQVzdi6M+21sKkrRvffEX2wbaeq0 VgPWKESwn1uBRAiy722SCSSUnBZPuT7/iCtsX1reQo7i7IUd5KtWfD+25tG5clM1pU nny43JIsIiugw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Jan Kara , Joonyoung Shim , kvm@vger.kernel.org, Jason Gunthorpe , Seung-Woo Kim , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Krzysztof Kozlowski , linux-mm@kvack.org, Kyungmin Park , Kukjin Kim , Daniel Vetter , Andrew Morton , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMTAvOS8yMCAxMjo1OSBBTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBBbGwgd2UgbmVlZCBh cmUgYSBwYWdlcyBhcnJheSwgcGluX3VzZXJfcGFnZXNfZmFzdCBjYW4gZ2l2ZSB1cyB0aGF0Cj4g ZGlyZWN0bHkuIFBsdXMgdGhpcyBhdm9pZHMgdGhlIGVudGlyZSByYXcgcGZuIHNpZGUgb2YgZ2V0 X3ZhZGRyX2ZyYW1lcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGludGVsLmNvbT4KPiBDYzogSmFzb24gR3VudGhvcnBlIDxqZ2dAemllcGUuY2E+Cj4g Q2M6IElua2kgRGFlIDxpbmtpLmRhZUBzYW1zdW5nLmNvbT4KPiBDYzogSm9vbnlvdW5nIFNoaW0g PGp5MDkyMi5zaGltQHNhbXN1bmcuY29tPgo+IENjOiBTZXVuZy1Xb28gS2ltIDxzdzAzMTIua2lt QHNhbXN1bmcuY29tPgo+IENjOiBLeXVuZ21pbiBQYXJrIDxreXVuZ21pbi5wYXJrQHNhbXN1bmcu Y29tPgo+IENjOiBLdWtqaW4gS2ltIDxrZ2VuZUBrZXJuZWwub3JnPgo+IENjOiBLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+Cj4gQ2M6IEFuZHJldyBNb3J0b24gPGFrcG1AbGlu dXgtZm91bmRhdGlvbi5vcmc+Cj4gQ2M6IEpvaG4gSHViYmFyZCA8amh1YmJhcmRAbnZpZGlhLmNv bT4KPiBDYzogSsOpcsO0bWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhhdC5jb20+Cj4gQ2M6IEphbiBL YXJhIDxqYWNrQHN1c2UuY3o+Cj4gQ2M6IERhbiBXaWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50 ZWwuY29tPgo+IENjOiBsaW51eC1tbUBrdmFjay5vcmcKPiBDYzogbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCj4gQ2M6IGxpbnV4LXNhbXN1bmctc29jQHZnZXIua2VybmVsLm9y Zwo+IENjOiBsaW51eC1tZWRpYUB2Z2VyLmtlcm5lbC5vcmcKPiAtLQo+IHYyOiBVc2UgdW5waW5f dXNlcl9wYWdlc19kaXJ0eV9sb2NrIChKb2huKQo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2V4 eW5vcy9LY29uZmlnICAgICAgICAgIHwgIDEgLQo+ICAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9l eHlub3NfZHJtX2cyZC5jIHwgNDcgKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ICAgMiBmaWxl cyBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyOCBkZWxldGlvbnMoLSkKPiAKCkxvb2tzIGdv b2QuCgpSZXZpZXdlZC1ieTogSm9obiBIdWJiYXJkIDxqaHViYmFyZEBudmlkaWEuY29tPgoKdGhh bmtzLAotLSAKSm9obiBIdWJiYXJkCk5WSURJQQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2V4eW5vcy9LY29uZmlnIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmlnCj4gaW5k ZXggNjQxN2YzNzRiOTIzLi40MzI1N2VmM2MwOWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2V4eW5vcy9LY29uZmlnCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9LY29uZmln Cj4gQEAgLTg4LDcgKzg4LDYgQEAgY29tbWVudCAiU3ViLWRyaXZlcnMiCj4gICBjb25maWcgRFJN X0VYWU5PU19HMkQKPiAgIAlib29sICJHMkQiCj4gICAJZGVwZW5kcyBvbiBWSURFT19TQU1TVU5H X1M1UF9HMkQ9biB8fCBDT01QSUxFX1RFU1QKPiAtCXNlbGVjdCBGUkFNRV9WRUNUT1IKPiAgIAlo ZWxwCj4gICAJICBDaG9vc2UgdGhpcyBvcHRpb24gaWYgeW91IHdhbnQgdG8gdXNlIEV4eW5vcyBH MkQgZm9yIERSTS4KPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4 eW5vc19kcm1fZzJkLmMgYi9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMK PiBpbmRleCA5NjdhNWNkYzEyMGUuLmVjZWRlNDFhZjliOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZXh5bm9zL2V4eW5vc19kcm1fZzJkLmMKPiBAQCAtMjA1LDcgKzIwNSw4IEBAIHN0cnVjdCBnMmRf Y21kbGlzdF91c2VycHRyIHsKPiAgIAlkbWFfYWRkcl90CQlkbWFfYWRkcjsKPiAgIAl1bnNpZ25l ZCBsb25nCQl1c2VycHRyOwo+ICAgCXVuc2lnbmVkIGxvbmcJCXNpemU7Cj4gLQlzdHJ1Y3QgZnJh bWVfdmVjdG9yCSp2ZWM7Cj4gKwlzdHJ1Y3QgcGFnZQkJKipwYWdlczsKPiArCXVuc2lnbmVkIGlu dAkJbnBhZ2VzOwo+ICAgCXN0cnVjdCBzZ190YWJsZQkJKnNndDsKPiAgIAlhdG9taWNfdAkJcmVm Y291bnQ7Cj4gICAJYm9vbAkJCWluX3Bvb2w7Cj4gQEAgLTM3OCw3ICszNzksNiBAQCBzdGF0aWMg dm9pZCBnMmRfdXNlcnB0cl9wdXRfZG1hX2FkZHIoc3RydWN0IGcyZF9kYXRhICpnMmQsCj4gICAJ CQkJCWJvb2wgZm9yY2UpCj4gICB7Cj4gICAJc3RydWN0IGcyZF9jbWRsaXN0X3VzZXJwdHIgKmcy ZF91c2VycHRyID0gb2JqOwo+IC0Jc3RydWN0IHBhZ2UgKipwYWdlczsKPiAgIAo+ICAgCWlmICgh b2JqKQo+ICAgCQlyZXR1cm47Cj4gQEAgLTM5OCwxNSArMzk4LDkgQEAgc3RhdGljIHZvaWQgZzJk X3VzZXJwdHJfcHV0X2RtYV9hZGRyKHN0cnVjdCBnMmRfZGF0YSAqZzJkLAo+ICAgCWRtYV91bm1h cF9zZ3RhYmxlKHRvX2RtYV9kZXYoZzJkLT5kcm1fZGV2KSwgZzJkX3VzZXJwdHItPnNndCwKPiAg IAkJCSAgRE1BX0JJRElSRUNUSU9OQUwsIDApOwo+ICAgCj4gLQlwYWdlcyA9IGZyYW1lX3ZlY3Rv cl9wYWdlcyhnMmRfdXNlcnB0ci0+dmVjKTsKPiAtCWlmICghSVNfRVJSKHBhZ2VzKSkgewo+IC0J CWludCBpOwo+IC0KPiAtCQlmb3IgKGkgPSAwOyBpIDwgZnJhbWVfdmVjdG9yX2NvdW50KGcyZF91 c2VycHRyLT52ZWMpOyBpKyspCj4gLQkJCXNldF9wYWdlX2RpcnR5X2xvY2socGFnZXNbaV0pOwo+ IC0JfQo+IC0JcHV0X3ZhZGRyX2ZyYW1lcyhnMmRfdXNlcnB0ci0+dmVjKTsKPiAtCWZyYW1lX3Zl Y3Rvcl9kZXN0cm95KGcyZF91c2VycHRyLT52ZWMpOwo+ICsJdW5waW5fdXNlcl9wYWdlc19kaXJ0 eV9sb2NrKGcyZF91c2VycHRyLT5wYWdlcywgZzJkX3VzZXJwdHItPm5wYWdlcywKPiArCQkJCSAg ICB0cnVlKTsKPiArCWt2ZnJlZShnMmRfdXNlcnB0ci0+cGFnZXMpOwo+ICAgCj4gICAJaWYgKCFn MmRfdXNlcnB0ci0+b3V0X29mX2xpc3QpCj4gICAJCWxpc3RfZGVsX2luaXQoJmcyZF91c2VycHRy LT5saXN0KTsKPiBAQCAtNDc0LDM1ICs0NjgsMzQgQEAgc3RhdGljIGRtYV9hZGRyX3QgKmcyZF91 c2VycHRyX2dldF9kbWFfYWRkcihzdHJ1Y3QgZzJkX2RhdGEgKmcyZCwKPiAgIAlvZmZzZXQgPSB1 c2VycHRyICYgflBBR0VfTUFTSzsKPiAgIAllbmQgPSBQQUdFX0FMSUdOKHVzZXJwdHIgKyBzaXpl KTsKPiAgIAlucGFnZXMgPSAoZW5kIC0gc3RhcnQpID4+IFBBR0VfU0hJRlQ7Cj4gLQlnMmRfdXNl cnB0ci0+dmVjID0gZnJhbWVfdmVjdG9yX2NyZWF0ZShucGFnZXMpOwo+IC0JaWYgKCFnMmRfdXNl cnB0ci0+dmVjKSB7Cj4gKwlnMmRfdXNlcnB0ci0+cGFnZXMgPSBrdm1hbGxvY19hcnJheShucGFn ZXMsIHNpemVvZigqZzJkX3VzZXJwdHItPnBhZ2VzKSwKPiArCQkJCQkgICAgR0ZQX0tFUk5FTCk7 Cj4gKwlpZiAoIWcyZF91c2VycHRyLT5wYWdlcykgewo+ICAgCQlyZXQgPSAtRU5PTUVNOwo+ICAg CQlnb3RvIGVycl9mcmVlOwo+ICAgCX0KPiAgIAo+IC0JcmV0ID0gZ2V0X3ZhZGRyX2ZyYW1lcyhz dGFydCwgbnBhZ2VzLCBGT0xMX0ZPUkNFIHwgRk9MTF9XUklURSwKPiAtCQlnMmRfdXNlcnB0ci0+ dmVjKTsKPiArCXJldCA9IHBpbl91c2VyX3BhZ2VzX2Zhc3Qoc3RhcnQsIG5wYWdlcywgRk9MTF9G T1JDRSB8IEZPTExfV1JJVEUsCj4gKwkJCQkgIGcyZF91c2VycHRyLT5wYWdlcyk7Cj4gICAJaWYg KHJldCAhPSBucGFnZXMpIHsKPiAgIAkJRFJNX0RFVl9FUlJPUihnMmQtPmRldiwKPiAgIAkJCSAg ICAgICJmYWlsZWQgdG8gZ2V0IHVzZXIgcGFnZXMgZnJvbSB1c2VycHRyLlxuIik7Cj4gICAJCWlm IChyZXQgPCAwKQo+IC0JCQlnb3RvIGVycl9kZXN0cm95X2ZyYW1ldmVjOwo+IC0JCXJldCA9IC1F RkFVTFQ7Cj4gLQkJZ290byBlcnJfcHV0X2ZyYW1ldmVjOwo+IC0JfQo+IC0JaWYgKGZyYW1lX3Zl Y3Rvcl90b19wYWdlcyhnMmRfdXNlcnB0ci0+dmVjKSA8IDApIHsKPiArCQkJZ290byBlcnJfZGVz dHJveV9wYWdlczsKPiArCQlucGFnZXMgPSByZXQ7Cj4gICAJCXJldCA9IC1FRkFVTFQ7Cj4gLQkJ Z290byBlcnJfcHV0X2ZyYW1ldmVjOwo+ICsJCWdvdG8gZXJyX3VucGluX3BhZ2VzOwo+ICAgCX0K PiArCWcyZF91c2VycHRyLT5ucGFnZXMgPSBucGFnZXM7Cj4gICAKPiAgIAlzZ3QgPSBremFsbG9j KHNpemVvZigqc2d0KSwgR0ZQX0tFUk5FTCk7Cj4gICAJaWYgKCFzZ3QpIHsKPiAgIAkJcmV0ID0g LUVOT01FTTsKPiAtCQlnb3RvIGVycl9wdXRfZnJhbWV2ZWM7Cj4gKwkJZ290byBlcnJfdW5waW5f cGFnZXM7Cj4gICAJfQo+ICAgCj4gICAJcmV0ID0gc2dfYWxsb2NfdGFibGVfZnJvbV9wYWdlcyhz Z3QsCj4gLQkJCQkJZnJhbWVfdmVjdG9yX3BhZ2VzKGcyZF91c2VycHRyLT52ZWMpLAo+ICsJCQkJ CWcyZF91c2VycHRyLT5wYWdlcywKPiAgIAkJCQkJbnBhZ2VzLCBvZmZzZXQsIHNpemUsIEdGUF9L RVJORUwpOwo+ICAgCWlmIChyZXQgPCAwKSB7Cj4gICAJCURSTV9ERVZfRVJST1IoZzJkLT5kZXYs ICJmYWlsZWQgdG8gZ2V0IHNndCBmcm9tIHBhZ2VzLlxuIik7Cj4gQEAgLTUzOCwxMSArNTMxLDEx IEBAIHN0YXRpYyBkbWFfYWRkcl90ICpnMmRfdXNlcnB0cl9nZXRfZG1hX2FkZHIoc3RydWN0IGcy ZF9kYXRhICpnMmQsCj4gICBlcnJfZnJlZV9zZ3Q6Cj4gICAJa2ZyZWUoc2d0KTsKPiAgIAo+IC1l cnJfcHV0X2ZyYW1ldmVjOgo+IC0JcHV0X3ZhZGRyX2ZyYW1lcyhnMmRfdXNlcnB0ci0+dmVjKTsK PiArZXJyX3VucGluX3BhZ2VzOgo+ICsJdW5waW5fdXNlcl9wYWdlcyhnMmRfdXNlcnB0ci0+cGFn ZXMsIG5wYWdlcyk7Cj4gICAKPiAtZXJyX2Rlc3Ryb3lfZnJhbWV2ZWM6Cj4gLQlmcmFtZV92ZWN0 b3JfZGVzdHJveShnMmRfdXNlcnB0ci0+dmVjKTsKPiArZXJyX2Rlc3Ryb3lfcGFnZXM6Cj4gKwlr dmZyZWUoZzJkX3VzZXJwdHItPnBhZ2VzKTsKPiAgIAo+ICAgZXJyX2ZyZWU6Cj4gICAJa2ZyZWUo ZzJkX3VzZXJwdHIpOwo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==