From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFBD6C4332D for ; Mon, 18 Jan 2021 16:01:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB6FD22C9E for ; Mon, 18 Jan 2021 16:01:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405882AbhARQBs (ORCPT ); Mon, 18 Jan 2021 11:01:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406285AbhARQBk (ORCPT ); Mon, 18 Jan 2021 11:01:40 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96051C061574; Mon, 18 Jan 2021 08:00:59 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id h17so13858432wmq.1; Mon, 18 Jan 2021 08:00:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=NW1iIoeHWjGtkXcMPgktKDuPDLakc04ai1UeSujIYJg=; b=VfoaCcdDYl0BbpelqnGEKUanoKq5mm4JOV357PAHF9BFXbAsJ1mmab31CyvCJIULcq mwVCQDqvcBW63nJzk96kyhJxBXxsiVepTj59DkF8ec/4p/HuDJdlEDwmC7SAp+YVS+Vo E6+A+4SkpJ5Uh/vrtz1AB4FZPjBE29DlTgM0H0TF0se0DnFnaBdIqapYJUXGxPwNx30N YCVJe+U5bZ1oSRlqmcnJuJwu4XqxZAyle+h4Dfs1GIRyYIt6eR0we1TKXxf7HosDXJOa k0GV6aR8rss15t6oj0US/PziIOF7/c12aTAGFKtQcLqT/crlBxmyE1IEoAyeGrpPp8o3 YZTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=NW1iIoeHWjGtkXcMPgktKDuPDLakc04ai1UeSujIYJg=; b=tUeDZ5VyzUiBU0bVrlZ1KO8ZtE2RWk4cFVdh82AbcfHiGeZ7QHVqUP9bZqEBR35LQ6 Gkp02n3WFYCTMZhrp3/bxZyMVZMsdXrIiOUyZfNg/U+QCpjH3IeYk7ZgdBFyf4ekF2JI bsbf5caY4QDm1vQAWerEA6FsTIhhdZSf2l5GbOjmZnYG6xFfRPkSeyUEBOEdOU7npBDH HAJuWNi2Pp5PPKsBF8bqs3l3xQczzjSz2iXE7SJhAVXEknhJoGQCdkwRQ/bBD3M6/Feu Q+CfBXWpERK9HH528ShkSB+I7x9esQfnb8d/diEcAIzKLRzQIB5H1rf+uVxu+QFLUI85 yaWA== X-Gm-Message-State: AOAM530z6VyfPdGsEj+KZOem9Yi95ypACI7XnxlG4obfFAYrnmy+gKBu lqd0Gmf5G/2bzZVX+gc0lHM= X-Google-Smtp-Source: ABdhPJzaYH9/sfyD1Sk0DEU3VyX4kq3lfGOKZfvoVu/6o0Hw7D62cPz6+Vew6gJRM0PdpHc0rHFgUQ== X-Received: by 2002:a05:600c:21d8:: with SMTP id x24mr45435wmj.27.1610985658387; Mon, 18 Jan 2021 08:00:58 -0800 (PST) Received: from [192.168.1.211] ([2.29.208.120]) by smtp.gmail.com with ESMTPSA id m5sm31151558wrz.18.2021.01.18.08.00.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jan 2021 08:00:57 -0800 (PST) Subject: Re: [PATCH v2 6/7] platform: x86: Add intel_skl_int3472 driver To: "andriy.shevchenko@linux.intel.com" , Hans de Goede Cc: =?UTF-8?Q?Barnab=c3=a1s_P=c5=91cze?= , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "devel@acpica.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "andy@kernel.org" , "mika.westerberg@linux.intel.com" , "linus.walleij@linaro.org" , "bgolaszewski@baylibre.com" , "wsa@kernel.org" , "lee.jones@linaro.org" , "mgross@linux.intel.com" , "robert.moore@intel.com" , "erik.kaneda@intel.com" , "sakari.ailus@linux.intel.com" , "laurent.pinchart@ideasonboard.com" , "kieran.bingham@ideasonboard.com" References: <20210118003428.568892-1-djrscally@gmail.com> <20210118003428.568892-7-djrscally@gmail.com> <-GKrxu8GJvGe-PlKkLpblw9N-DtVtS7i87BOCLgJR72yf4hUFpUgiOlGcFero_gqgUxJrX2gxtLOnz_31hJugfam0SXXmXxIzGIhS162mhI=@protonmail.com> <20210118135121.GM4077@smile.fi.intel.com> <20210118152323.GV4077@smile.fi.intel.com> <20210118154852.GY4077@smile.fi.intel.com> From: Daniel Scally Message-ID: Date: Mon, 18 Jan 2021 16:00:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210118154852.GY4077@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 18/01/2021 15:48, andriy.shevchenko@linux.intel.com wrote: > On Mon, Jan 18, 2021 at 04:32:54PM +0100, Hans de Goede wrote: >> On 1/18/21 4:23 PM, andriy.shevchenko@linux.intel.com wrote: > ... > >> 1. Using a folder is fine, desirable even >> 2. I've some concerns about the name, but I'm not really objecting, >> just giving my 2 cents. > Let's get into compromised summary: > - create a folder for these driver files > - name it without _skl_ while leaving this in the file / driver names > > Does everybody agree on this approach? > Works for me!