All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
To: <mingo@redhat.com>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <x86@kernel.org>, Zhenzhong Duan <zhenzhong.duan@oracle.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH RESEND] Calling check_system_tsc_reliable() before unsynchronized_tsc()
Date: Wed, 21 Jun 2017 01:23:37 -0700 (PDT)	[thread overview]
Message-ID: <b1532ef7-cd9f-45f7-9f49-48dd2a5c2495@default> (raw)

unsynchronized_tsc() checks value of tsc_clocksource_reliable which is set by
check_system_tsc_reliable(). It's better to move check_system_tsc_reliable() at
front.

Though X86_FEATURE_CONSTANT_TSC is usually set for TSC reliable system, just in
case.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
 arch/x86/kernel/tsc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 714dfba..a316bdd 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -1412,11 +1412,11 @@ void __init tsc_init(void)
 
 	use_tsc_delay();
 
+	check_system_tsc_reliable();
+
 	if (unsynchronized_tsc())
 		mark_tsc_unstable("TSCs unsynchronized");
 
-	check_system_tsc_reliable();
-
 	detect_art();
 }
 
-- 
1.7.3

             reply	other threads:[~2017-06-21  8:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21  8:23 Zhenzhong Duan [this message]
2017-06-22 13:56 ` [PATCH RESEND] Calling check_system_tsc_reliable() before unsynchronized_tsc() Thomas Gleixner
2017-06-23  8:30   ` Zhenzhong Duan
2017-06-22 14:03 ` [tip:x86/timers] x86/tsc: Call " tip-bot for Zhenzhong Duan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1532ef7-cd9f-45f7-9f49-48dd2a5c2495@default \
    --to=zhenzhong.duan@oracle.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.