From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDFC7C433F5 for ; Wed, 2 Mar 2022 18:16:32 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5D964068B; Wed, 2 Mar 2022 19:16:31 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id DFAE140141 for ; Wed, 2 Mar 2022 19:16:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646244990; x=1677780990; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=ru+RuDiGk9ybvJuhpuFVoGFMCT0TVLQZ5PqH0oPE6bk=; b=Vwv15P43S5zQ6vggI0Dep30zEyrqixqFajN7d8mf1ZbUwKdheSjyO8aI QnF/wMWv3SBMBrLlxFUFLO+2vnl03S3GIDG9LXRWWsULSzrQR+UVs4Fjn dmgaUewWaCHqPiLvUxx0qQkKfwi/5CsQXbJXk5gIGm6GSGDpIaHTKI6u0 bPR0QiYWn5unkyqtqm3tJv4QGFhXimhZmyn6eLGEA6YJdo01iPW1PQGjl yPz8qmf9mB+zxDdxlkLGEdo9zVc+UY47hnJMDD6+Ia/Sow4hooLN/MY82 m7eL2SbaSL93OPXvCCrE2NfhY91pfsZm9Mxz3Vk8uHeWyZD/jEnDz/hGE A==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="316683948" X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="316683948" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 10:16:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="551373302" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 02 Mar 2022 10:16:28 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 10:16:27 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Wed, 2 Mar 2022 10:16:27 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Wed, 2 Mar 2022 10:16:27 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Wed, 2 Mar 2022 10:16:27 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G5ItGx0iXkyrHf+c13uD2XIY+g5f9Avq65LcXQqSqrik2Ftrgh2SHqcJ5LjxEPQc9BN2M6EzwUgO7DaaWij0sf6DMny5FbFYO/pi5uFrKRdSjdjItj8QWrn3HzCV1lIOI/Xib+eeGhZAzl0ZozTVEOl29uoW1a+XmrjMrUI1kt0Nf+PBolSD+fLWq/qK7+dv1TdW7NKeziLqhhmHFfBO8PsFvJMv/j1AN7woG0wdTg+9vt3CbloTdJnlVdIqi+8oj6CMHk+RELNTbNARDiIPCyOQtT810EtreOmLxiLW+SciE5koPSz910Mjay7z1v1YRUn38BgXdYsbA2fOVI5h4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rMF8yN1wBECimWH0vyadnvIb3uj3JZqd/SR3wR6PkGM=; b=ZJikaFZE8AQVraflvklpxT/obAQUIXCibC5k0qtgXM9DY8hZtXUZkvjlOfaikklj5ffWGIVCHMW0bM8hcTLxZw9Y1+MLD4o61HAdeZmcdlRmNf257MyJQVUUVHfB/gQs+7QokOTZNHtN6cIHfEapzK1S9c8UK/qyerFiHfahXRNnvXNLQ0gMf/pHA6+DBovbOQp5lKFF7/h9PX34dOqpUU1LPt4ECw7Jb8nVMgBHC5VMjQLTfGHKHgO1EX1rnVuKdgbK+mXkE5vil7cnZ/iTIUG1UQSU5vq70ZSgLQ9rQbfCSKeCmbij0/Tu8JoDbeoIi6cDNYL5L9DyPapZ6vuWMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM5PR1101MB2297.namprd11.prod.outlook.com (2603:10b6:4:54::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Wed, 2 Mar 2022 18:16:20 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd21:6fbe:8308:2ecf%7]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 18:16:20 +0000 Message-ID: Date: Wed, 2 Mar 2022 18:16:14 +0000 Content-Language: en-US To: Harold Huang , CC: Liron Himi References: <20220302123400.188209-1-baymaxhuang@gmail.com> From: Ferruh Yigit Subject: Re: [PATCH] net/kni: initialize rte_kni_conf to 0 before using it X-User: ferruhy In-Reply-To: <20220302123400.188209-1-baymaxhuang@gmail.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0153.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::14) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b490fac-47ce-460e-b42d-08d9fc78bffa X-MS-TrafficTypeDiagnostic: DM5PR1101MB2297:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2ENer+klPxmLqu+2N307QY6iRKqxr+5BusIIMnTMYwI9QM8p4OXwKBKaIAJ7tW8f0u6hZe6nYOVQV8Li0gRgNve3DO6EnltEkzQjI8j2uWAV6FZ1kqqjo1xQYqiW6sp0nLcQ9h1yprYOyXpqZTGL4W+CsPZwgorZd5kktKAF+4I8ercbtR89YGUFe/YVP38ov1Xn7Cr4HIXltntqCT1QaFGOz4qpvSIoWGFYHGom3scLSIQ4bko1UBmKZYlTP9ai+yyDLquw9+IlsdA3Ee3t6bqhSsdoRt9Bv8lGzPWMqX0nNfkQEGppyn6cPLesWbEawJers1ZSygt8aUwE2kblMKTcnUV/1l93VDuSTprYutxUi2urnVfX5m4oPpzWieXDOsFJYg5PyWwf3trDhOtx5JgG8OZy2jOvogssrfkr26XUW3l7kiisVYfL+nJN8xloc9B/HXOruYfQuApm+mryKP8YPuHvZZLmv3K0gc0/S+ZkeDIaj8qP+ys62s8ajPupdQgC7hduh7bqxbkAODAUklXgt6vP3OLOu39nfr1yVx+MsHU+FR51t6X2GOmycslz1b20g0tLxMpuELhJpJJdfOtE8TfyMLOu8RFPxOI8FyL7VbUctLwbLnryK/6BtZpMS8m7bOOxdlRborscTRxLSrwVCEPRcnVPBrWY4lOESlns4PmssH9MvqfK8sCBZlWBz2ostPtU5LsOvnzVCjSECg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(6512007)(86362001)(5660300002)(31696002)(44832011)(66476007)(66946007)(66556008)(8676002)(8936002)(2906002)(4326008)(2616005)(186003)(26005)(82960400001)(53546011)(36756003)(38100700002)(6506007)(6486002)(6666004)(508600001)(31686004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjhZTUJwNDgvUUp6RndyekJSckJCZWx3WFdoUXFDQXlFN0t1cFgwMVk0R2Jl?= =?utf-8?B?L2NnWENZeUJEemxWY0JRMmFXSDI1L05jY0JEcFI5WnNtZHBkVUJRMW9QWlM4?= =?utf-8?B?WVZsemhSK1pMRTFlYlhPQ1BaNG8xL2FEMm8vdWcwYytyeTZQNTI1a1V4R1JY?= =?utf-8?B?eFY5dTlENXFMengzcEx6T3V5T3ZwZFZPODY5Zk5aQnVtL1o4RXdUbFhmUkYv?= =?utf-8?B?UFJXVUtIVnRDZCtiMU83YzZLc2RGVnV4dkNhWXg5eXJpNzlPTVRZQWI4VDhB?= =?utf-8?B?ZzVtS2pGMGZUSE0xM25JWmpqVzVNOHU4M0RZZGpzemRTSVdBSDRldGIzeita?= =?utf-8?B?WThMSVpjWE1ESzZjdGE2dWY3YWhHanZnbGMvTlY3Uk5UNElQMmlhb1h6cC9W?= =?utf-8?B?V0M3VkhNMUt1em5nL1RuNGl1UEhrSWpWN2RzVnBhUlAyRnREMzYxeUt3endr?= =?utf-8?B?QWNTOUR6MW1QZGpSRFpkVHhoT2QvU25uR254dWlvSFpXZ2dlaTB1ajBObjV0?= =?utf-8?B?Z28vME1kSVdKQTgyM0ZuRldMS2hhbU9WRG9heVNVc2VJVERKTk9JSklOcjM3?= =?utf-8?B?aDdEZFlGd2oydUVDOWg1RFJNeWxmTmlNTmhoc3g2L3dxdklLb1Q1NEtOL0Jj?= =?utf-8?B?VXNNdjY4K2djVU00Nk5IdnprZ2RxMENUTkFYUitHeERoR1ZuR2dlWEswaUFE?= =?utf-8?B?dy8wY00vRFNkUnNrenZRVlFSY0RCZmVSUGZ4a0ttOW0yWEljVjE2c1B6MkxS?= =?utf-8?B?MU13S3djWHp4L3ovL2lDeTRBb1BQMEpvK29xK05FOVZPOVVOZTBETjduWFB0?= =?utf-8?B?K3lhbmlMckRFcThiUklOUDZ6d0dUU0trK1lsYUtQK2FMeEhaTm8wVlhlU0tD?= =?utf-8?B?SElIV1JOa0VuWjhyUzQ2Vkd5UGFLNTR3SU9DTnd5bm85SzkyU2ZnUUR2RUJj?= =?utf-8?B?OWVMaVZ0WG5KVzFwSUYwODZtNEkyZ2lsMnY3ZXBWVUZBNDV3TE43eXdMelVj?= =?utf-8?B?OWhTLzA3SkhRYU9zc0ZKTjVHNUlCTzNOU3dtbTRlSWxhUDVsWW5KbW1yRzdS?= =?utf-8?B?d2JlcG1TbUhhMFRJRTRMalN4TnZrWVo2MXZrVFVVNlFrNWc3N1RDZHBxMUww?= =?utf-8?B?OHZOb01aVFhBUVFnMlpYaUoxeGFPbWxkc3ZkNW1CekhNTWVScXNBc3cxd3VR?= =?utf-8?B?d0N6UGJHdGxvOWFmZWlhanNOblVpeGFURE9UaTNRTEhJODZzZXJ3WG9Fbktj?= =?utf-8?B?MCtlVEFUcml6Uy9ORVpUQU1DSXRnbTI4UEY5ekQ0QUdmZ0srdVJwb1FXUmxP?= =?utf-8?B?UUppeTUrUUtVVVl0amkySU96Ly83ZjJsYWFxUHU5WmFPZDVCdjJ3UFdsUUhm?= =?utf-8?B?V214bmtsYlFSbDdvV3pKQjNneDQ2dEdnMUtpd2dRZGFIajlIaVJhK0E3N3JB?= =?utf-8?B?TFJ0L1ltMUZBdHIrenkrQ08ycEpEZkNKa3hFam1LMXYxUENxRHNwT3RUM2dh?= =?utf-8?B?a2k5TzJWTEY1aXpDOEVUTTFiN1o4WXV2R1BpZFdMNkdvTlVVajBJQzA4OWs4?= =?utf-8?B?L3BFdzdteFpNSXdtNFFpa3M1M0l1UUtGcGU1VGVvSEhqUkloYUlwZFBwODFG?= =?utf-8?B?c1FOK1htaW1jN0IxL0FKd2IwM0o1eElnditwbDFHVFRnRnVVZVhITkpuTyth?= =?utf-8?B?TlBNMVNSRk1RWW11VWVPSEl2V29rY2RzQ1ZZNCtpejM2anlLUUxjSW5OL2I2?= =?utf-8?B?VUMwTDM4WllGdmNWRm9McmxpczIyT2VPYmN0NHZ6b3ZmcFBvV0lYSFlDOTdF?= =?utf-8?B?K0dYZGNpVmY3d1Vkci91cjlxNzdrQ2RnbGVPL1lZcGdKYWZiWkhDTHh0RDN6?= =?utf-8?B?QlA3ajNmMENETm9NTGc1dXBpQW5lRFMvZzVXMkVEdU5RaCtSOVI5eFk4QXBo?= =?utf-8?B?VyszU29leDduLzJuY2w1NHFCcisyMWNzalRhdnQwVHd5Qy9QaStmNWZpV1BG?= =?utf-8?B?ZDRoNE1jSWhaNUxCaFRtanhyRnJPU09XdFZFYUdneUYvUjRqTUZGNU9FUVZa?= =?utf-8?B?ZkdHNFZheWlMOW9qQnlOUE9pNDJCU1orVE81VC83b1lVNmg5THFwZ0RmVzcv?= =?utf-8?B?TkE3c2dXV0JrUEJVWkFLZWRQN3V6QzdvUGtWVjBmSHBrSkxrY2p6M1Z0MEJw?= =?utf-8?Q?FdWmitauvmynRUbQNxtiF9o=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8b490fac-47ce-460e-b42d-08d9fc78bffa X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 18:16:19.9601 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 46x+3beLAByq0BesyRxFGvqlolP/p1jkG4GaUhCGS0PI5et9/RcdFdVX0iDXxlEI/3rhXnazF57upg6SNvG1bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2297 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/2/2022 12:33 PM, Harold Huang wrote: > When kni driver calls eth_kni_start to start device, some fields such as > min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause > kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu > value. This is unexpected and in some time we could not change the kni > device mtu with ip link command. > Agree on the problem and the solution, thanks for the fix. > Fixes: ff1e35fb5f8 ("kni: calculate MTU from mbuf size") > Signed-off-by: Harold Huang > --- > drivers/net/kni/rte_eth_kni.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c > index c428caf441..23b15edfac 100644 > --- a/drivers/net/kni/rte_eth_kni.c > +++ b/drivers/net/kni/rte_eth_kni.c > @@ -128,6 +128,7 @@ eth_kni_start(struct rte_eth_dev *dev) > const char *name = dev->device->name + 4; /* remove net_ */ > > mb_pool = internals->rx_queues[0].mb_pool; > + memset(&conf, 0, sizeof(conf)); Can you prefer initialize to zero, instead of 'memset', I think it is more clear that way: - struct rte_kni_conf conf; + struct rte_kni_conf conf = { 0 }; > strlcpy(conf.name, name, RTE_KNI_NAMESIZE); > conf.force_bind = 0; > conf.group_id = port_id;