From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C99D9C43334 for ; Thu, 2 Jun 2022 09:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbiFBJhQ (ORCPT ); Thu, 2 Jun 2022 05:37:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232800AbiFBJhO (ORCPT ); Thu, 2 Jun 2022 05:37:14 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BDA726F35B for ; Thu, 2 Jun 2022 02:37:12 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id h19so5547707edj.0 for ; Thu, 02 Jun 2022 02:37:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=UbAi11qp5DTn/kiY7uPuGBDObYw/10Y1J5If4iuylkU=; b=hspK3aDSUha2ZlbLkIA4SyM1rE7MGAnEU8h5hlnsgElBeQ9W6KayPlQaKlWLwrAuA5 Saag/wD5eOfxStucPV5KaWWW5ZQMLcshP/opeVN04jFhTn1KfPJQGtKSrs+kaSgNzAZP 9yQo2w7phSDgvaJ+FkPrjSaIQJsWqenwWsXDoMlBoD/4j4DqUWl+Myiwbd8Lcd1yWhEo UwnOeIY2P+Np+bA4GrLJdX1+5o6ky/ok9dO9LfUTqjSPVY9iSNdV1JTvkiG396yi4eLD lPVsksCDuKkdStRSKx4qN35YmRzQdcLeB0Xc09fig9Y9r+23V6vUBu1wK3Z+loUA+c+k /vjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=UbAi11qp5DTn/kiY7uPuGBDObYw/10Y1J5If4iuylkU=; b=O4+1j0iecLzcb6hz/koAELrtGR1Bb25bZ7CubBEH4tKATzo5RwdhNaZCgc9gG554u6 yNss3pQfoVBBOgyKoFajKy2RW21xBg63ksWIcgqIftCAdu809aDWCaferfzEYyF3TL/6 3bf1PbL+29qnizl4A6TYcxgPZgLBirScH+JTewvEZxXuSxzYWFKXPFXuPCXDt7i/Ihqq RIGyDBYSicJMWIAdbt+1Llyn/AnbPmXDfsQza0OgPhGBN4OordKR25rrd965Fq8x6hhc CSJH6BEzOtxd1/nJnaEHpiWnaaQXeRITjIdfhymwnJDig1rfiJFwMHDvKNkZdCUSwqXM 5ssg== X-Gm-Message-State: AOAM5335ROmwTJ9eXRmvk8Nos1mwaDxJnKtHt3T5kWVvQBMv3F4llv4H bOKG7Es4om9eI0Sq64LT7xZ1Dg== X-Google-Smtp-Source: ABdhPJymJuZyD9JpI2fUlnCh+hsniUb5OSHN+1erAyXcoN5TVNkuBzXsGhuVH2mYjVFW/7lyBo6o+A== X-Received: by 2002:a05:6402:430d:b0:42e:199a:4eb8 with SMTP id m13-20020a056402430d00b0042e199a4eb8mr1106417edc.411.1654162630874; Thu, 02 Jun 2022 02:37:10 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id fx10-20020a170906b74a00b00708743e31b2sm1240308ejb.27.2022.06.02.02.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 02:37:10 -0700 (PDT) Message-ID: Date: Thu, 2 Jun 2022 11:37:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Content-Language: en-US From: Krzysztof Kozlowski To: Chanho Park , Kishon Vijay Abraham I , Vinod Koul , Alim Akhtar , Rob Herring , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220602053250.62593-1-chanho61.park@samsung.com> <20220602053250.62593-2-chanho61.park@samsung.com> <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> In-Reply-To: <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/06/2022 11:34, Krzysztof Kozlowski wrote: > On 02/06/2022 07:32, Chanho Park wrote: >> To support secondary ufs phy devices, we need to get an offset value >> from pmu-syscon. >> >> Signed-off-by: Chanho Park >> --- >> .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> index f6ed1a005e7a..d0ba92aa578d 100644 >> --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> @@ -40,9 +40,16 @@ properties: >> - const: tx0_symbol_clk >> >> samsung,pmu-syscon: >> - $ref: '/schemas/types.yaml#/definitions/phandle' >> - description: phandle for PMU system controller interface, used to >> - control pmu registers bits for ufs m-phy >> + $ref: '/schemas/types.yaml#/definitions/phandle-array' >> + items: >> + minItems: 1 >> + items: >> + - description: phandle for PMU system controller interface, used to >> + control pmu registers bits for ufs m-phy >> + - description: offset of the pmu control register > > This does not work... Please test your bindings with different cases. Just to be clear - when I mentioned that minItems should be on second items level, I meant it should affect the second items list, not the first. Now you can have 1, 2 or 10 phandles. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C54EDC433EF for ; Thu, 2 Jun 2022 09:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N9uB9v3p/4skV9YluGYK/I4/T17ph3/qkpYoe4YdCYY=; b=zgNrsorOQPB7f5 9+8DL5K/OhxtMrI+gwZpkFfFw0RDwz6JJ4JC29h6gSlSe25YQfUOd6FUtjTzu4iEWL9KbWQ3sUNKh ago1B2pqkV2k5lNUHk76HntzXYDOUH57mbWfQkh+k/YEDYtNmqmFmpoSmK8BhyfLdRZRUJU5v5fMw z3gs+G4fKBTGH0Nyp+x/ZGXqcE7y/SDMAcqZ5QGCCbJo0aaQyTQeCIp2nBIOp41dTG5IgfDeswYkY lpnmAEe6dz5DkLYSfZ+K7E5zo62egHKRATI7Vj/eI6NVF/kM3cJ9pInZB3XMqDY4tp/qPDsK5SKcy AAeUyGeJwRNYFfwUvAeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwhGU-002VMs-6f; Thu, 02 Jun 2022 09:37:14 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwhGS-002VLc-24 for linux-phy@lists.infradead.org; Thu, 02 Jun 2022 09:37:13 +0000 Received: by mail-ed1-x530.google.com with SMTP id w27so5495263edl.7 for ; Thu, 02 Jun 2022 02:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=UbAi11qp5DTn/kiY7uPuGBDObYw/10Y1J5If4iuylkU=; b=hspK3aDSUha2ZlbLkIA4SyM1rE7MGAnEU8h5hlnsgElBeQ9W6KayPlQaKlWLwrAuA5 Saag/wD5eOfxStucPV5KaWWW5ZQMLcshP/opeVN04jFhTn1KfPJQGtKSrs+kaSgNzAZP 9yQo2w7phSDgvaJ+FkPrjSaIQJsWqenwWsXDoMlBoD/4j4DqUWl+Myiwbd8Lcd1yWhEo UwnOeIY2P+Np+bA4GrLJdX1+5o6ky/ok9dO9LfUTqjSPVY9iSNdV1JTvkiG396yi4eLD lPVsksCDuKkdStRSKx4qN35YmRzQdcLeB0Xc09fig9Y9r+23V6vUBu1wK3Z+loUA+c+k /vjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=UbAi11qp5DTn/kiY7uPuGBDObYw/10Y1J5If4iuylkU=; b=mmX5vuVR73vJKXjhFCK6e+IHNnRCoUCTU0fg2W3HTw/ePS18o1xyJn39kWWbHHMGsv 2AB5+AdYIE9DsE8s2vI9kBpbOn1eUtJIPnJX8eHG2J52bMQ+2s0jPJ1jKibU+MZTigM6 A9WaU41a1vNbuf7VCnqpmkuPzZBc+oxyv8ao011TVGhOHrVxBHnmuE4+O4VfNgDYIqut 9EG/RZ86iYM9bsHgYGEP95IasM8XuS1xk58RbGBZUPSAugPXkUdo2E13XUvCL8UQzPAo M9egHCs3rAIRrFmBwV5t8hJqsLCSfgotl2NUm/6ugF+ihjZiOz+Ic497lXVrMTyFFNFu uqIw== X-Gm-Message-State: AOAM5333II/t8W7lZuCyC0t4VNMf+IfnabXOSCawVoyGfR0zvjdonVuO je2YzteN8UlWTXW6wA48lp4xtQ== X-Google-Smtp-Source: ABdhPJymJuZyD9JpI2fUlnCh+hsniUb5OSHN+1erAyXcoN5TVNkuBzXsGhuVH2mYjVFW/7lyBo6o+A== X-Received: by 2002:a05:6402:430d:b0:42e:199a:4eb8 with SMTP id m13-20020a056402430d00b0042e199a4eb8mr1106417edc.411.1654162630874; Thu, 02 Jun 2022 02:37:10 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id fx10-20020a170906b74a00b00708743e31b2sm1240308ejb.27.2022.06.02.02.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 02:37:10 -0700 (PDT) Message-ID: Date: Thu, 2 Jun 2022 11:37:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Content-Language: en-US From: Krzysztof Kozlowski To: Chanho Park , Kishon Vijay Abraham I , Vinod Koul , Alim Akhtar , Rob Herring , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220602053250.62593-1-chanho61.park@samsung.com> <20220602053250.62593-2-chanho61.park@samsung.com> <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> In-Reply-To: <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_023712_169453_3F14569C X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On 02/06/2022 11:34, Krzysztof Kozlowski wrote: > On 02/06/2022 07:32, Chanho Park wrote: >> To support secondary ufs phy devices, we need to get an offset value >> from pmu-syscon. >> >> Signed-off-by: Chanho Park >> --- >> .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> index f6ed1a005e7a..d0ba92aa578d 100644 >> --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> @@ -40,9 +40,16 @@ properties: >> - const: tx0_symbol_clk >> >> samsung,pmu-syscon: >> - $ref: '/schemas/types.yaml#/definitions/phandle' >> - description: phandle for PMU system controller interface, used to >> - control pmu registers bits for ufs m-phy >> + $ref: '/schemas/types.yaml#/definitions/phandle-array' >> + items: >> + minItems: 1 >> + items: >> + - description: phandle for PMU system controller interface, used to >> + control pmu registers bits for ufs m-phy >> + - description: offset of the pmu control register > > This does not work... Please test your bindings with different cases. Just to be clear - when I mentioned that minItems should be on second items level, I meant it should affect the second items list, not the first. Now you can have 1, 2 or 10 phandles. Best regards, Krzysztof -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 519E0C43334 for ; Thu, 2 Jun 2022 09:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u9YKeldfqN0EgJMkF2qhJsd0KEmn6lx477gi9ovjV30=; b=EmnC2YuT8Lc3FF SXlfFJQXJpjSx3EXs/ZFKbOBn6oNJLdPe1yufbwi0NZwExyFHuttyenC/ExcMXu4u3nqdB9/03hW+ aBIdVi2lY+qLtzLVWpEgrNwxqiYQ9Z/TbhpV1DOT+KVDnLGbrVuaxTdG5yhK9ad79TFtisX13vo4b v2q5z5wLzByqW5ksRL8jicJ9ZlU3lLyeAWSsB9rAqDWqGKutFSQOPOracHxtoDNFoQ6Da89V0YK7g 25k75Vtz4cWyG8oIIeg3XYtv86H/N/m3w3XLdpu4297eGkzKUbD4R4UF8eDDW769jtfIDLEgWKPNa 1iHltAPxvIvB4XLclmKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwhGZ-002VPO-SQ; Thu, 02 Jun 2022 09:37:20 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwhGX-002VLd-1k for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 09:37:18 +0000 Received: by mail-ed1-x52e.google.com with SMTP id c2so5502781edf.5 for ; Thu, 02 Jun 2022 02:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=UbAi11qp5DTn/kiY7uPuGBDObYw/10Y1J5If4iuylkU=; b=hspK3aDSUha2ZlbLkIA4SyM1rE7MGAnEU8h5hlnsgElBeQ9W6KayPlQaKlWLwrAuA5 Saag/wD5eOfxStucPV5KaWWW5ZQMLcshP/opeVN04jFhTn1KfPJQGtKSrs+kaSgNzAZP 9yQo2w7phSDgvaJ+FkPrjSaIQJsWqenwWsXDoMlBoD/4j4DqUWl+Myiwbd8Lcd1yWhEo UwnOeIY2P+Np+bA4GrLJdX1+5o6ky/ok9dO9LfUTqjSPVY9iSNdV1JTvkiG396yi4eLD lPVsksCDuKkdStRSKx4qN35YmRzQdcLeB0Xc09fig9Y9r+23V6vUBu1wK3Z+loUA+c+k /vjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=UbAi11qp5DTn/kiY7uPuGBDObYw/10Y1J5If4iuylkU=; b=nO24calcXQYae16FA4hxnHrYNiMvO0lUN2LGVqvC4JWOfUM50NS8dh2Burn5W3ISiD Z9CuBQg5xmL4s0Lu4wawyKU8bOL9S2Cv2oLfVpUyumcqpbtwXtTi91j2ERHYZqWjEq9y caRURwWQibdz0tyLthoubNY4uSXFxhpZegemSDv91CbRQWo2mnJyCymW6BS1issguE9t ITnqpk7qkVDUtAuheklwcLjWnePXXmrmmixe4g7CEl0W/32eOXjEeuc+5u+JCYGhdoFP ABF4c892iv4G/XOPIwXcJm8E43FTr2VebeXGUS/vnvp5oMiPRYBqLDDqFgi8uihu9d7N rYGQ== X-Gm-Message-State: AOAM533AvDbwuNT7S3HAOcEg+Epzs8xCuLp9+qenhsm3dcv7PMNbTzDs fYtL6k135dNoXnkWhTJ+ABY4bQ== X-Google-Smtp-Source: ABdhPJymJuZyD9JpI2fUlnCh+hsniUb5OSHN+1erAyXcoN5TVNkuBzXsGhuVH2mYjVFW/7lyBo6o+A== X-Received: by 2002:a05:6402:430d:b0:42e:199a:4eb8 with SMTP id m13-20020a056402430d00b0042e199a4eb8mr1106417edc.411.1654162630874; Thu, 02 Jun 2022 02:37:10 -0700 (PDT) Received: from [192.168.0.181] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id fx10-20020a170906b74a00b00708743e31b2sm1240308ejb.27.2022.06.02.02.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jun 2022 02:37:10 -0700 (PDT) Message-ID: Date: Thu, 2 Jun 2022 11:37:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/6] dt-bindings: phy: samsung,ufs-phy: make pmu-syscon as phandle-array Content-Language: en-US From: Krzysztof Kozlowski To: Chanho Park , Kishon Vijay Abraham I , Vinod Koul , Alim Akhtar , Rob Herring , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220602053250.62593-1-chanho61.park@samsung.com> <20220602053250.62593-2-chanho61.park@samsung.com> <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> In-Reply-To: <44fceb66-fd33-4b2d-fe8e-9a1a5837a51a@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_023717_100966_D8E10BCE X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/06/2022 11:34, Krzysztof Kozlowski wrote: > On 02/06/2022 07:32, Chanho Park wrote: >> To support secondary ufs phy devices, we need to get an offset value >> from pmu-syscon. >> >> Signed-off-by: Chanho Park >> --- >> .../devicetree/bindings/phy/samsung,ufs-phy.yaml | 13 ++++++++++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> index f6ed1a005e7a..d0ba92aa578d 100644 >> --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml >> @@ -40,9 +40,16 @@ properties: >> - const: tx0_symbol_clk >> >> samsung,pmu-syscon: >> - $ref: '/schemas/types.yaml#/definitions/phandle' >> - description: phandle for PMU system controller interface, used to >> - control pmu registers bits for ufs m-phy >> + $ref: '/schemas/types.yaml#/definitions/phandle-array' >> + items: >> + minItems: 1 >> + items: >> + - description: phandle for PMU system controller interface, used to >> + control pmu registers bits for ufs m-phy >> + - description: offset of the pmu control register > > This does not work... Please test your bindings with different cases. Just to be clear - when I mentioned that minItems should be on second items level, I meant it should affect the second items list, not the first. Now you can have 1, 2 or 10 phandles. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel