From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59F91C433EF for ; Fri, 29 Oct 2021 06:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3934A61151 for ; Fri, 29 Oct 2021 06:35:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232169AbhJ2GiR (ORCPT ); Fri, 29 Oct 2021 02:38:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:54634 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232123AbhJ2GiC (ORCPT ); Fri, 29 Oct 2021 02:38:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ACD37610D2; Fri, 29 Oct 2021 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635489329; bh=6L9d1Ezd7kwg1IfsoMHgf5b33hOvvWq/PQqAlZkeHGQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QwfsIJwdYqVryW06h3c2Cl2KR/HVsN9j2EldZP6281F0uToZh5uk6lc+bcpKBdg4q W21CAt06HgStIj1Xm/xdTNy5lmVF3rcFKL6QtezOKJT8uSLWrt6ccTjeP+uf0+zf2D TpMLWOVsDeJiJya8ecwnITd7ZksWTXZvY4jgY4f96+VYNxejUKMu/GkS272g1hfSP8 yfKquY1PkIrOkVyfzv7BkNWvDZSOLqV0hXfHz2UqUWKzSr4KAQF0JqGALs5ybUimpi PROFyblGoPfChL6TWRp9O+uhs4TGTGMv8qC9J3iqx65LnMtqZB3cICYQDelyr/aB5G 9Z5vB7q0l2LAQ== Message-ID: Date: Fri, 29 Oct 2021 14:35:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH] erofs: don't trigger WARN() when decompression fails Content-Language: en-US To: Gao Xiang , linux-erofs@lists.ozlabs.org Cc: LKML , syzbot+d8aaffc3719597e8cfb4@syzkaller.appspotmail.com, Dmitry Vyukov References: <20211025074311.130395-1-hsiangkao@linux.alibaba.com> From: Chao Yu In-Reply-To: <20211025074311.130395-1-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/10/25 15:43, Gao Xiang wrote: > syzbot reported a WARNING [1] due to corrupted compressed data. > > As Dmitry said, "If this is not a kernel bug, then the code should > not use WARN. WARN if for kernel bugs and is recognized as such by > all testing systems and humans." > > [1] https://lore.kernel.org/r/000000000000b3586105cf0ff45e@google.com > Reported-by: syzbot+d8aaffc3719597e8cfb4@syzkaller.appspotmail.com > Cc: Dmitry Vyukov > Cc: Chao Yu > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65241C433EF for ; Fri, 29 Oct 2021 06:35:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0825C610D2 for ; Fri, 29 Oct 2021 06:35:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0825C610D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HgXk24kZSz2yb5 for ; Fri, 29 Oct 2021 17:35:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QwfsIJwd; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=chao@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=QwfsIJwd; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HgXjw5QVbz2y7M for ; Fri, 29 Oct 2021 17:35:32 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id ACD37610D2; Fri, 29 Oct 2021 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635489329; bh=6L9d1Ezd7kwg1IfsoMHgf5b33hOvvWq/PQqAlZkeHGQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QwfsIJwdYqVryW06h3c2Cl2KR/HVsN9j2EldZP6281F0uToZh5uk6lc+bcpKBdg4q W21CAt06HgStIj1Xm/xdTNy5lmVF3rcFKL6QtezOKJT8uSLWrt6ccTjeP+uf0+zf2D TpMLWOVsDeJiJya8ecwnITd7ZksWTXZvY4jgY4f96+VYNxejUKMu/GkS272g1hfSP8 yfKquY1PkIrOkVyfzv7BkNWvDZSOLqV0hXfHz2UqUWKzSr4KAQF0JqGALs5ybUimpi PROFyblGoPfChL6TWRp9O+uhs4TGTGMv8qC9J3iqx65LnMtqZB3cICYQDelyr/aB5G 9Z5vB7q0l2LAQ== Message-ID: Date: Fri, 29 Oct 2021 14:35:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.0.3 Subject: Re: [PATCH] erofs: don't trigger WARN() when decompression fails Content-Language: en-US To: Gao Xiang , linux-erofs@lists.ozlabs.org References: <20211025074311.130395-1-hsiangkao@linux.alibaba.com> From: Chao Yu In-Reply-To: <20211025074311.130395-1-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syzbot+d8aaffc3719597e8cfb4@syzkaller.appspotmail.com, LKML , Dmitry Vyukov Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 2021/10/25 15:43, Gao Xiang wrote: > syzbot reported a WARNING [1] due to corrupted compressed data. > > As Dmitry said, "If this is not a kernel bug, then the code should > not use WARN. WARN if for kernel bugs and is recognized as such by > all testing systems and humans." > > [1] https://lore.kernel.org/r/000000000000b3586105cf0ff45e@google.com > Reported-by: syzbot+d8aaffc3719597e8cfb4@syzkaller.appspotmail.com > Cc: Dmitry Vyukov > Cc: Chao Yu > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,