All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Lorenzo Colitti <lorenzo@google.com>, netdev@vger.kernel.org
Cc: astrachan@google.com, subashab@codeaurora.org,
	eric.dumazet@gmail.com, davem@davemloft.net,
	David Ahern <dsa@cumulusnetworks.com>
Subject: Re: [PATCH net] net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort
Date: Sat, 7 Jul 2018 06:28:38 -0700	[thread overview]
Message-ID: <b16ec946-9945-c304-25fa-bc0059c0c8c2@gmail.com> (raw)
In-Reply-To: <20180707073140.202004-1-lorenzo@google.com>



On 07/07/2018 12:31 AM, Lorenzo Colitti wrote:
> When tcp_diag_destroy closes a TCP_NEW_SYN_RECV socket, it first
> frees it by calling inet_csk_reqsk_queue_drop_and_and_put in
> tcp_abort, and then frees it again by calling sock_gen_put.
> 
> Since tcp_abort only has one caller, and all the other codepaths
> in tcp_abort don't free the socket, just remove the free in that
> function.
> 
> Cc: David Ahern <dsa@cumulusnetworks.com>
> Tested: passes Android sock_diag_test.py, which exercises this codepath
> Fixes: d7226c7a4dd1 ("net: diag: Fix refcnt leak in error path destroying socket")
> Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
> ---

Signed-off-by: Eric Dumazet <edumazet@google.com>

Thanks !

  parent reply	other threads:[~2018-07-07 13:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-07  7:31 [PATCH net] net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort Lorenzo Colitti
2018-07-07 13:11 ` David Miller
2018-07-07 13:29   ` Eric Dumazet
2018-07-07 13:58     ` Eric Dumazet
2018-07-09  4:53     ` Lorenzo Colitti
2018-07-09 14:59       ` David Ahern
2018-07-09 15:17         ` Eric Dumazet
2018-07-09 16:14           ` David Ahern
2018-07-09 16:21             ` Eric Dumazet
2018-07-07 13:33   ` David Ahern
2018-07-07 13:45     ` Eric Dumazet
2018-07-07 13:51       ` Eric Dumazet
2018-07-07 13:56         ` David Ahern
2018-07-07 14:16           ` Eric Dumazet
2018-07-07 14:19             ` Eric Dumazet
2018-07-09  5:24           ` Lorenzo Colitti
2018-07-09 15:00             ` David Ahern
2018-07-07 13:28 ` Eric Dumazet [this message]
2018-07-07 22:07 ` David Ahern
2018-07-08  1:57 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b16ec946-9945-c304-25fa-bc0059c0c8c2@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=astrachan@google.com \
    --cc=davem@davemloft.net \
    --cc=dsa@cumulusnetworks.com \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=subashab@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.