From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ACB6C433DB for ; Thu, 7 Jan 2021 10:56:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2E7423333 for ; Thu, 7 Jan 2021 10:56:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2E7423333 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14F166E28B; Thu, 7 Jan 2021 10:56:14 +0000 (UTC) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E8B66E28B; Thu, 7 Jan 2021 10:56:13 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id m5so5174197wrx.9; Thu, 07 Jan 2021 02:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=J0PdSkFsE8JsrkbEiYiHhjf/UPpdicMh4ZEU5WTuIJY=; b=i3zD6TQvqwaUenSW8Evq0Y3IzcOwlCjjZelWDLY4sR7XnJzPPNkoZx8+7H2sqZqijQ DT5my4eeVjiXJazjQp+DmjWp1gHOyUrkmQSGk2bDTsRtZnUyQB5d4dKa1ipQUmv8YMBB C2vG15app2HN2MrbKNzjDLxIYFBpQCwhEPkCDxxLdlKQWY2egFLX+uNkjd/h0zUGGbtu +UdKbMPJtBBiFcs6732SWYrkdQEK6vTMLZApM1ElESGVM6vCsfCHYrEK1BwqHXNOTwdi K/HZTNjtYo1t0wcatXXEO50z/aWFFJ0OekKKMJrfLvlqB8/cznDHyYecYoj0Ocns3Q4Y /iWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=J0PdSkFsE8JsrkbEiYiHhjf/UPpdicMh4ZEU5WTuIJY=; b=oGfwcPxvQ+Kcw/Luuw+C5EpTa1nPdi2R4IUeB2DTCbgevKtkH/6kKEbLuLknp7kRZe 6U0RRWzxjbN4CMEn9NOPE/yqWmFe+HUPxvt0xTs15yBD9szim8h/9/VdNU6mQiekJXri u8dxT1J/Ek7AA7c+4v/5RjxoWOy4d095rgXKsra50h3eWFptVmQuS7IyDkKCnhM341xS sbKQEgXXonL703CrIcehhT8KuOJociQhFRiUzSP4iDnI3JXprEaqrzIOct59s/1v/fqE ZoVethABjh0+Txi7eB+Un0Sp7sj7gbT0VrlWfKY0sWeNywGxfEA+2ISZDLLvwWKfBbv1 T8dw== X-Gm-Message-State: AOAM533caA4auFbAOL2+eAkvf077AUEtQbnJWVMnmYXpjhsJvFU8+LT2 qrv7M12J9dTDz7aLcrU75Ck= X-Google-Smtp-Source: ABdhPJzK4tjYWUj/6qDPNTx9GRuH/GWSr1ORngcGTWUU8AU/aCB7kwXfER3FNB8Gf+3Y1l0vrCrTOg== X-Received: by 2002:adf:e84f:: with SMTP id d15mr8492742wrn.245.1610016972068; Thu, 07 Jan 2021 02:56:12 -0800 (PST) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id p9sm6994895wmm.17.2021.01.07.02.56.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jan 2021 02:56:11 -0800 (PST) Subject: Re: [PATCH 29/35] drm/amdgpu: svm bo enable_signal call condition To: Felix Kuehling , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20210107030127.20393-1-Felix.Kuehling@amd.com> <20210107030127.20393-30-Felix.Kuehling@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 7 Jan 2021 11:56:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210107030127.20393-30-Felix.Kuehling@amd.com> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: alex.sierra@amd.com, philip.yang@amd.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 07.01.21 um 04:01 schrieb Felix Kuehling: > From: Alex Sierra > > [why] > To support svm bo eviction mechanism. > > [how] > If the BO crated has AMDGPU_AMDKFD_CREATE_SVM_BO flag set, > enable_signal callback will be called inside amdgpu_evict_flags. > This also causes gutting of the BO by removing all placements, > so that TTM won't actually do an eviction. Instead it will discard > the memory held by the BO. This is needed for HMM migration to user > mode system memory pages. I don't think that this will work. What exactly are you doing here? As Daniel pointed out HMM and dma_fences are fundamentally incompatible. Christian. > > Signed-off-by: Alex Sierra > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index f423f42cb9b5..62d4da95d22d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -107,6 +107,20 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo, > } > > abo = ttm_to_amdgpu_bo(bo); > + if (abo->flags & AMDGPU_AMDKFD_CREATE_SVM_BO) { > + struct dma_fence *fence; > + struct dma_resv *resv = &bo->base._resv; > + > + rcu_read_lock(); > + fence = rcu_dereference(resv->fence_excl); > + if (fence && !fence->ops->signaled) > + dma_fence_enable_sw_signaling(fence); > + > + placement->num_placement = 0; > + placement->num_busy_placement = 0; > + rcu_read_unlock(); > + return; > + } > switch (bo->mem.mem_type) { > case AMDGPU_PL_GDS: > case AMDGPU_PL_GWS: _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2479C433DB for ; Thu, 7 Jan 2021 10:56:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75B1823333 for ; Thu, 7 Jan 2021 10:56:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75B1823333 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8CA76E425; Thu, 7 Jan 2021 10:56:14 +0000 (UTC) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E8B66E28B; Thu, 7 Jan 2021 10:56:13 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id m5so5174197wrx.9; Thu, 07 Jan 2021 02:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=reply-to:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=J0PdSkFsE8JsrkbEiYiHhjf/UPpdicMh4ZEU5WTuIJY=; b=i3zD6TQvqwaUenSW8Evq0Y3IzcOwlCjjZelWDLY4sR7XnJzPPNkoZx8+7H2sqZqijQ DT5my4eeVjiXJazjQp+DmjWp1gHOyUrkmQSGk2bDTsRtZnUyQB5d4dKa1ipQUmv8YMBB C2vG15app2HN2MrbKNzjDLxIYFBpQCwhEPkCDxxLdlKQWY2egFLX+uNkjd/h0zUGGbtu +UdKbMPJtBBiFcs6732SWYrkdQEK6vTMLZApM1ElESGVM6vCsfCHYrEK1BwqHXNOTwdi K/HZTNjtYo1t0wcatXXEO50z/aWFFJ0OekKKMJrfLvlqB8/cznDHyYecYoj0Ocns3Q4Y /iWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=J0PdSkFsE8JsrkbEiYiHhjf/UPpdicMh4ZEU5WTuIJY=; b=oGfwcPxvQ+Kcw/Luuw+C5EpTa1nPdi2R4IUeB2DTCbgevKtkH/6kKEbLuLknp7kRZe 6U0RRWzxjbN4CMEn9NOPE/yqWmFe+HUPxvt0xTs15yBD9szim8h/9/VdNU6mQiekJXri u8dxT1J/Ek7AA7c+4v/5RjxoWOy4d095rgXKsra50h3eWFptVmQuS7IyDkKCnhM341xS sbKQEgXXonL703CrIcehhT8KuOJociQhFRiUzSP4iDnI3JXprEaqrzIOct59s/1v/fqE ZoVethABjh0+Txi7eB+Un0Sp7sj7gbT0VrlWfKY0sWeNywGxfEA+2ISZDLLvwWKfBbv1 T8dw== X-Gm-Message-State: AOAM533caA4auFbAOL2+eAkvf077AUEtQbnJWVMnmYXpjhsJvFU8+LT2 qrv7M12J9dTDz7aLcrU75Ck= X-Google-Smtp-Source: ABdhPJzK4tjYWUj/6qDPNTx9GRuH/GWSr1ORngcGTWUU8AU/aCB7kwXfER3FNB8Gf+3Y1l0vrCrTOg== X-Received: by 2002:adf:e84f:: with SMTP id d15mr8492742wrn.245.1610016972068; Thu, 07 Jan 2021 02:56:12 -0800 (PST) Received: from ?IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7? ([2a02:908:1252:fb60:be8a:bd56:1f94:86e7]) by smtp.gmail.com with ESMTPSA id p9sm6994895wmm.17.2021.01.07.02.56.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jan 2021 02:56:11 -0800 (PST) Subject: Re: [PATCH 29/35] drm/amdgpu: svm bo enable_signal call condition To: Felix Kuehling , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20210107030127.20393-1-Felix.Kuehling@amd.com> <20210107030127.20393-30-Felix.Kuehling@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: Date: Thu, 7 Jan 2021 11:56:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210107030127.20393-30-Felix.Kuehling@amd.com> Content-Language: en-US X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Cc: alex.sierra@amd.com, philip.yang@amd.com, Daniel Vetter Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Am 07.01.21 um 04:01 schrieb Felix Kuehling: > From: Alex Sierra > > [why] > To support svm bo eviction mechanism. > > [how] > If the BO crated has AMDGPU_AMDKFD_CREATE_SVM_BO flag set, > enable_signal callback will be called inside amdgpu_evict_flags. > This also causes gutting of the BO by removing all placements, > so that TTM won't actually do an eviction. Instead it will discard > the memory held by the BO. This is needed for HMM migration to user > mode system memory pages. I don't think that this will work. What exactly are you doing here? As Daniel pointed out HMM and dma_fences are fundamentally incompatible. Christian. > > Signed-off-by: Alex Sierra > Signed-off-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index f423f42cb9b5..62d4da95d22d 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -107,6 +107,20 @@ static void amdgpu_evict_flags(struct ttm_buffer_object *bo, > } > > abo = ttm_to_amdgpu_bo(bo); > + if (abo->flags & AMDGPU_AMDKFD_CREATE_SVM_BO) { > + struct dma_fence *fence; > + struct dma_resv *resv = &bo->base._resv; > + > + rcu_read_lock(); > + fence = rcu_dereference(resv->fence_excl); > + if (fence && !fence->ops->signaled) > + dma_fence_enable_sw_signaling(fence); > + > + placement->num_placement = 0; > + placement->num_busy_placement = 0; > + rcu_read_unlock(); > + return; > + } > switch (bo->mem.mem_type) { > case AMDGPU_PL_GDS: > case AMDGPU_PL_GWS: _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx