[Buildroot] [PATCH/autobuild 5/8] autobuild-run: check that toolchain config lines are still present

[Arnout Vandecappelle <arnout@mind.be>]

On 10-04-17 10:28, Thomas Petazzoni wrote:
> Hello,
> 
> On Sun, 9 Apr 2017 22:51:25 +0200, Arnout Vandecappelle
> (Essensium/Mind) wrote:
>> Some lines from the toolchain config may be removed due to dependency
>> issues. Currently this is covered by explicit conditions in the
>> autobuild-run script, e.g. checking that libc is not glibc before
>> enabling BR2_STATIC_LIBS. However, that binds this script pretty
>> tightly to the logic in Buildroot itself.
> 
> Seems like a good idea!
> 
>> +    # Check that the toolchain configuration is still present
>> +    # Report all the missing ones
>> +    toolchaincomplete = True
>> +    for toolchainline in kwargs['config']:
>> +        if toolchainline not in configlines:
>> +            log_write(log, "WARN: missing toolchain config line: %s" % toolchainline[:-1])
> 
> We should remove this warning, it's not a warning at all. It is
> a perfectly normal situation that a configuration gets rejected here,
> for example when glibc+static is used. So having a warning everytime a
> completely regular situation occurs doesn't seem like a good idea.

 Yes of course. I needed that for debugging but it indeed shouldn't be there in
production.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF