From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC90C433E2 for ; Thu, 3 Sep 2020 15:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAB7421527 for ; Thu, 3 Sep 2020 15:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728473AbgICPaM (ORCPT ); Thu, 3 Sep 2020 11:30:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:58750 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728145AbgICPaK (ORCPT ); Thu, 3 Sep 2020 11:30:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE5D6AD60; Thu, 3 Sep 2020 15:30:09 +0000 (UTC) Subject: Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Boris Ostrovsky , Stefano Stabellini , Dan Carpenter , Wei Liu , Yan Yankovskyi , dri-devel@lists.freedesktop.org, xen-devel@lists.xenproject.org, linux-mm@kvack.org, David Hildenbrand , Michal Hocko , Dan Williams References: <20200901083326.21264-1-roger.pau@citrix.com> <20200901083326.21264-4-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Thu, 3 Sep 2020 17:30:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200901083326.21264-4-roger.pau@citrix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.09.20 10:33, Roger Pau Monne wrote: > To be used in order to create foreign mappings. This is based on the > ZONE_DEVICE facility which is used by persistent memory devices in > order to create struct pages and kernel virtual mappings for the IOMEM > areas of such devices. Note that on kernels without support for > ZONE_DEVICE Xen will fallback to use ballooned pages in order to > create foreign mappings. > > The newly added helpers use the same parameters as the existing > {alloc/free}_xenballooned_pages functions, which allows for in-place > replacement of the callers. Once a memory region has been added to be > used as scratch mapping space it will no longer be released, and pages > returned are kept in a linked list. This allows to have a buffer of > pages and prevents resorting to frequent additions and removals of > regions. > > If enabled (because ZONE_DEVICE is supported) the usage of the new > functionality untangles Xen balloon and RAM hotplug from the usage of > unpopulated physical memory ranges to map foreign pages, which is the > correct thing to do in order to avoid mappings of foreign pages depend > on memory hotplug. > > Note the driver is currently not enabled on Arm platforms because it > would interfere with the identity mapping required on some platforms. > > Signed-off-by: Roger Pau Monné Sorry, I just got a build error for x86 32-bit build: WARNING: unmet direct dependencies detected for ZONE_DEVICE Depends on [n]: MEMORY_HOTPLUG [=n] && MEMORY_HOTREMOVE [=n] && SPARSEMEM_VMEMMAP [=n] && ARCH_HAS_PTE_DEVMAP [=n] Selected by [y]: - XEN_UNPOPULATED_ALLOC [=y] && XEN [=y] && X86 [=y] GEN Makefile CC kernel/bounds.s CALL /home/gross/korg/src/scripts/atomic/check-atomics.sh UPD include/generated/bounds.h CC arch/x86/kernel/asm-offsets.s In file included from /home/gross/korg/src/include/linux/mmzone.h:19:0, from /home/gross/korg/src/include/linux/gfp.h:6, from /home/gross/korg/src/include/linux/slab.h:15, from /home/gross/korg/src/include/linux/crypto.h:19, from /home/gross/korg/src/arch/x86/kernel/asm-offsets.c:9: /home/gross/korg/src/include/linux/page-flags-layout.h:95:2: error: #error "Not enough bits in page flags" #error "Not enough bits in page flags" ^~~~~ make[2]: *** [/home/gross/korg/src/scripts/Makefile.build:114: arch/x86/kernel/asm-offsets.s] Error 1 make[1]: *** [/home/gross/korg/src/Makefile:1175: prepare0] Error 2 make[1]: Leaving directory '/home/gross/korg/x8632' make: *** [Makefile:185: __sub-make] Error 2 Juergen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA3B0C433E9 for ; Thu, 3 Sep 2020 15:30:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EFC62072A for ; Thu, 3 Sep 2020 15:30:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EFC62072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF15A6E1E5; Thu, 3 Sep 2020 15:30:11 +0000 (UTC) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 797536E1E5 for ; Thu, 3 Sep 2020 15:30:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CE5D6AD60; Thu, 3 Sep 2020 15:30:09 +0000 (UTC) Subject: Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory To: Roger Pau Monne , linux-kernel@vger.kernel.org References: <20200901083326.21264-1-roger.pau@citrix.com> <20200901083326.21264-4-roger.pau@citrix.com> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Thu, 3 Sep 2020 17:30:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200901083326.21264-4-roger.pau@citrix.com> Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Oleksandr Andrushchenko , David Airlie , Yan Yankovskyi , David Hildenbrand , dri-devel@lists.freedesktop.org, Michal Hocko , linux-mm@kvack.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , Dan Williams , Dan Carpenter Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMDEuMDkuMjAgMTA6MzMsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBUbyBiZSB1c2VkIGlu IG9yZGVyIHRvIGNyZWF0ZSBmb3JlaWduIG1hcHBpbmdzLiBUaGlzIGlzIGJhc2VkIG9uIHRoZQo+ IFpPTkVfREVWSUNFIGZhY2lsaXR5IHdoaWNoIGlzIHVzZWQgYnkgcGVyc2lzdGVudCBtZW1vcnkg ZGV2aWNlcyBpbgo+IG9yZGVyIHRvIGNyZWF0ZSBzdHJ1Y3QgcGFnZXMgYW5kIGtlcm5lbCB2aXJ0 dWFsIG1hcHBpbmdzIGZvciB0aGUgSU9NRU0KPiBhcmVhcyBvZiBzdWNoIGRldmljZXMuIE5vdGUg dGhhdCBvbiBrZXJuZWxzIHdpdGhvdXQgc3VwcG9ydCBmb3IKPiBaT05FX0RFVklDRSBYZW4gd2ls bCBmYWxsYmFjayB0byB1c2UgYmFsbG9vbmVkIHBhZ2VzIGluIG9yZGVyIHRvCj4gY3JlYXRlIGZv cmVpZ24gbWFwcGluZ3MuCj4gCj4gVGhlIG5ld2x5IGFkZGVkIGhlbHBlcnMgdXNlIHRoZSBzYW1l IHBhcmFtZXRlcnMgYXMgdGhlIGV4aXN0aW5nCj4ge2FsbG9jL2ZyZWV9X3hlbmJhbGxvb25lZF9w YWdlcyBmdW5jdGlvbnMsIHdoaWNoIGFsbG93cyBmb3IgaW4tcGxhY2UKPiByZXBsYWNlbWVudCBv ZiB0aGUgY2FsbGVycy4gT25jZSBhIG1lbW9yeSByZWdpb24gaGFzIGJlZW4gYWRkZWQgdG8gYmUK PiB1c2VkIGFzIHNjcmF0Y2ggbWFwcGluZyBzcGFjZSBpdCB3aWxsIG5vIGxvbmdlciBiZSByZWxl YXNlZCwgYW5kIHBhZ2VzCj4gcmV0dXJuZWQgYXJlIGtlcHQgaW4gYSBsaW5rZWQgbGlzdC4gVGhp cyBhbGxvd3MgdG8gaGF2ZSBhIGJ1ZmZlciBvZgo+IHBhZ2VzIGFuZCBwcmV2ZW50cyByZXNvcnRp bmcgdG8gZnJlcXVlbnQgYWRkaXRpb25zIGFuZCByZW1vdmFscyBvZgo+IHJlZ2lvbnMuCj4gCj4g SWYgZW5hYmxlZCAoYmVjYXVzZSBaT05FX0RFVklDRSBpcyBzdXBwb3J0ZWQpIHRoZSB1c2FnZSBv ZiB0aGUgbmV3Cj4gZnVuY3Rpb25hbGl0eSB1bnRhbmdsZXMgWGVuIGJhbGxvb24gYW5kIFJBTSBo b3RwbHVnIGZyb20gdGhlIHVzYWdlIG9mCj4gdW5wb3B1bGF0ZWQgcGh5c2ljYWwgbWVtb3J5IHJh bmdlcyB0byBtYXAgZm9yZWlnbiBwYWdlcywgd2hpY2ggaXMgdGhlCj4gY29ycmVjdCB0aGluZyB0 byBkbyBpbiBvcmRlciB0byBhdm9pZCBtYXBwaW5ncyBvZiBmb3JlaWduIHBhZ2VzIGRlcGVuZAo+ IG9uIG1lbW9yeSBob3RwbHVnLgo+IAo+IE5vdGUgdGhlIGRyaXZlciBpcyBjdXJyZW50bHkgbm90 IGVuYWJsZWQgb24gQXJtIHBsYXRmb3JtcyBiZWNhdXNlIGl0Cj4gd291bGQgaW50ZXJmZXJlIHdp dGggdGhlIGlkZW50aXR5IG1hcHBpbmcgcmVxdWlyZWQgb24gc29tZSBwbGF0Zm9ybXMuCj4gCj4g U2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+CgpT b3JyeSwgSSBqdXN0IGdvdCBhIGJ1aWxkIGVycm9yIGZvciB4ODYgMzItYml0IGJ1aWxkOgoKV0FS TklORzogdW5tZXQgZGlyZWN0IGRlcGVuZGVuY2llcyBkZXRlY3RlZCBmb3IgWk9ORV9ERVZJQ0UK ICAgRGVwZW5kcyBvbiBbbl06IE1FTU9SWV9IT1RQTFVHIFs9bl0gJiYgTUVNT1JZX0hPVFJFTU9W RSBbPW5dICYmIApTUEFSU0VNRU1fVk1FTU1BUCBbPW5dICYmIEFSQ0hfSEFTX1BURV9ERVZNQVAg Wz1uXQogICBTZWxlY3RlZCBieSBbeV06CiAgIC0gWEVOX1VOUE9QVUxBVEVEX0FMTE9DIFs9eV0g JiYgWEVOIFs9eV0gJiYgWDg2IFs9eV0KICAgR0VOICAgICBNYWtlZmlsZQogICBDQyAgICAgIGtl cm5lbC9ib3VuZHMucwogICBDQUxMICAgIC9ob21lL2dyb3NzL2tvcmcvc3JjL3NjcmlwdHMvYXRv bWljL2NoZWNrLWF0b21pY3Muc2gKICAgVVBEICAgICBpbmNsdWRlL2dlbmVyYXRlZC9ib3VuZHMu aAogICBDQyAgICAgIGFyY2gveDg2L2tlcm5lbC9hc20tb2Zmc2V0cy5zCkluIGZpbGUgaW5jbHVk ZWQgZnJvbSAvaG9tZS9ncm9zcy9rb3JnL3NyYy9pbmNsdWRlL2xpbnV4L21tem9uZS5oOjE5OjAs CiAgICAgICAgICAgICAgICAgIGZyb20gL2hvbWUvZ3Jvc3Mva29yZy9zcmMvaW5jbHVkZS9saW51 eC9nZnAuaDo2LAogICAgICAgICAgICAgICAgICBmcm9tIC9ob21lL2dyb3NzL2tvcmcvc3JjL2lu Y2x1ZGUvbGludXgvc2xhYi5oOjE1LAogICAgICAgICAgICAgICAgICBmcm9tIC9ob21lL2dyb3Nz L2tvcmcvc3JjL2luY2x1ZGUvbGludXgvY3J5cHRvLmg6MTksCiAgICAgICAgICAgICAgICAgIGZy b20gL2hvbWUvZ3Jvc3Mva29yZy9zcmMvYXJjaC94ODYva2VybmVsL2FzbS1vZmZzZXRzLmM6OToK L2hvbWUvZ3Jvc3Mva29yZy9zcmMvaW5jbHVkZS9saW51eC9wYWdlLWZsYWdzLWxheW91dC5oOjk1 OjI6IGVycm9yOiAKI2Vycm9yICJOb3QgZW5vdWdoIGJpdHMgaW4gcGFnZSBmbGFncyIKICAjZXJy b3IgIk5vdCBlbm91Z2ggYml0cyBpbiBwYWdlIGZsYWdzIgogICBefn5+fgptYWtlWzJdOiAqKiog Wy9ob21lL2dyb3NzL2tvcmcvc3JjL3NjcmlwdHMvTWFrZWZpbGUuYnVpbGQ6MTE0OiAKYXJjaC94 ODYva2VybmVsL2FzbS1vZmZzZXRzLnNdIEVycm9yIDEKbWFrZVsxXTogKioqIFsvaG9tZS9ncm9z cy9rb3JnL3NyYy9NYWtlZmlsZToxMTc1OiBwcmVwYXJlMF0gRXJyb3IgMgptYWtlWzFdOiBMZWF2 aW5nIGRpcmVjdG9yeSAnL2hvbWUvZ3Jvc3Mva29yZy94ODYzMicKbWFrZTogKioqIFtNYWtlZmls ZToxODU6IF9fc3ViLW1ha2VdIEVycm9yIDIKCgpKdWVyZ2VuCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=