From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933878AbdC3Plv (ORCPT ); Thu, 30 Mar 2017 11:41:51 -0400 Received: from mail-eopbgr30080.outbound.protection.outlook.com ([40.107.3.80]:48222 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933356AbdC3Plr (ORCPT ); Thu, 30 Mar 2017 11:41:47 -0400 Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=mellanox.com; Subject: Re: [PATCH 2/6] mm, tile: drop arch_{add,remove}_memory To: Michal Hocko , References: <20170330115454.32154-1-mhocko@kernel.org> <20170330115454.32154-3-mhocko@kernel.org> CC: Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Reza Arbab , Yasuaki Ishimatsu , Tang Chen , , Kani Toshimitsu , , Joonsoo Kim , Andi Kleen , Zhang Zhen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko From: Chris Metcalf Message-ID: Date: Thu, 30 Mar 2017 11:41:33 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170330115454.32154-3-mhocko@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BN6PR01CA0062.prod.exchangelabs.com (2603:10b6:404:cc::24) To AM4PR0501MB2753.eurprd05.prod.outlook.com (2603:10a6:200:5b::9) X-MS-Office365-Filtering-Correlation-Id: 8ac76ac9-0a49-4a65-cf3f-08d4778344ba X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:AM4PR0501MB2753; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2753;3:pvGMKdr+yeS2kR/MkjMqnjTRN05qXF7wfsbu8U3MG2O1xk6X2GqqFPELcshnJYWbRE8GU2Nh5whOZBuFZ19NqmCG4C2DIC5C/KDBLMgkxe8qhUw/gilrjoVKRWQspa+ZfUfTfr+P0L/wMAU7iyw7eZ+y7WuLg+biGJQilYpvf7DZJ/HKgwyZzywZdodUqay8oSswZrZl9wcjDo3YoAL9PIL7OUP7sqn9A1zctyzIQDlZHDqKqdvMvzDNsOb/8Z5EgXaY8C5tPH5Wf4RL5kWzAH59Klof+sBaHIPXsRGJXssX9N9TEXMSvblSrBm+jOnMOogj2jAOmQjWqPhdMrP7SDLCtwJSbkesFIDnqRvBRjc=;25:IUNZvR2EGKCPPzV+g+XCWkKBDs4mkz2h2UUPNJHmxY+B/WA40fRrZGQlX/nLq4G4wdPL4ESLwjuPQ//WcruiTd+onIImANH8Y3XlwXqdZXut7k0PPx/1c54sRaSIICgG8avpTwz0wPaMH3WQUMSAD4Vdkn+7PS29UqmVCfm0t3srj4Qt7uamS3/D2g96VgrFAv/bOUuVqt9hrnEM9GAzSdEq16916mQQeJstLN+h8L0fG0FP+VkhPdzCx3Sb28LP98k7RDv3VsufL1pvKNgDNa0lsYaglW+QaDgwHBPV+YBy9+EO1YirFWklKK5RnWbzxDxv4DBSwgIrMo3j/IekG9opyDaHIY9dD81JIzMc6HPzcFcF/yCbRhWQqk2aELRMUyZPp3uf7KlQ8B18c00z7xQMSuXZeWNL0bJ08agy6scsugWwH0Um1hCWMGOc8foY9XrRHGP0AhALa55ZUOJ7uw== X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2753;31:6jXYkeyvB1QqK1T/QFU6SKQabRYcwEHRjmWvRmPj2xUBiorklORnCkUkJEEfQhW9yUBCbSzogC2ZmwDGYHk8PwR7RXjLc8WVceME91B8fWVasgyMcN5xXzH95hHPzM4UpxvtpktuZzfD6jm7sIiALEOstp57smX26RCiBdI/XqewEgkuGilr5eyOsR0iPNhhjgWeo5RogQkNrbRSQonBrebdiBhA8+rLrOg/QvH8YdBt0Y/aqqNkkZHH8YPfT5N0U7Bt5LoebOY2FtLIus9yKKlUqjECs810R3umnlclSLU=;20:Rl4wO26nU5kNMYCClFZJQ6+oMSOSuVnbKw21anluKMU1Zu+cAKlLzD26IY6oTXOFdzwgmW2QaMEPk34vCtAAW58S2R4DZqrRn8LlMiiHTtSqzczbHj4ma++gwJ5YxquWJVfKRMQJ7Swq5SSsU5RzWffbGG5fdrdS/cxCT6GMfgcytwgkP1Y+PVp6tFQCKuEwLzIgR51FIlUM3KJezTVN2bDtSVPY1iC+vdwDF2fCXJq3XGPTbmBQnHjHCmAODpVZ9KsbqdcsQL1sRl0+fZcwucq4sy9Lh5oj3UFD/DRkqTmPL8uSm1ewKp0pCyBLQAJlSonScAgL1QdvPiNDiyF6XMpYEWKB+6yy4J169Llgtzup/PPiJMrLYdrItaUBEFyZX8FR6Otxf7iFq/m3DrJM+Aof8fwyPk7psLAD6Ob5YivU7tVKTP4C1nfuZmfahN586ZOaoIVoTrsvBDF66nJXTGuUN952+p5ze+sVdoPa7oWwCZ+qiWbxs2F4xc1L+9Ze X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(171992500451332); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(93006067)(93001067)(3002001)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(20161123562025)(20161123555025)(20161123560025)(6072148);SRVR:AM4PR0501MB2753;BCL:0;PCL:0;RULEID:;SRVR:AM4PR0501MB2753; X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2753;4:jlwf/xf9D+i8kXHORtSO5npPOHUvtPls3cm4lB4oSu//wCn0QwPmD502ecTXXJIHHIJ9t0misVRd+5WBHaIePZL7aAkfAGzTCERqahm+gfWt0Yt6CSZ06CcGCwepAZAvf97sS7dKHhgl/jc1uf+LnAhcavQQzSuoG2gobALsRMO62hvdbiC+rUxOQxcFIk+OpocSfj0+UxCfgjWRTaA9082oqynI0wnIl2dqs4O+7RUsxzfEIY96MP3rgD3Q/ql9Raa1wEZC/fbYAKUYPjtn/71vqoI07RkGh7B4EXoIG6f0eancX6CKpECFx8ts1Lpo3HBOLG1P4Q3LEw8qYKXbazH1Ye6gFOqL8455lOI1TZxY9d/wLbMH2kbPF+Vn5LZ1Wf0QUSvHnfX/jdU+Roclz8gcjOrbwps4GI5k+hQPi9YZDjyasU3HqyNP7FPJ02G1lbrH6DzTuShWIP5GX/G5zIEGcrsAmnlfJwXv/sGeQEBShcQ5sbBavNDHRFuAVrMcYC47s4zjexxl08nKGab/DEWbW0L4pBAaVXF9x4f6mUbFtZ08AoKkvO5WqbHGTYNQJg0IIJ5vv6XIazkNgBI9R4qZedpK6pNcgc3Qr6UBZO6J8IdN9zZhLT8exuCgT5Lj9JIvt3udDwD0eV0wY+qjCu5VABlkbwM34HNOK4FzBPnNARio+NReLDZLh6oFBLhV+hV0EMR/lsozxjxorXtvSX9nP3auktuqJihp+x/X0zUQycgO+Uh+0RI3YJT/SK3P1Oakgz0b2ZMDZza50ZWdrQ== X-Forefront-PRVS: 02622CEF0A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(39860400002)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(377454003)(24454002)(50466002)(38730400002)(83506001)(229853002)(64126003)(31696002)(23746002)(33646002)(5660300001)(86362001)(189998001)(6116002)(4001350100001)(7416002)(47776003)(3846002)(65806001)(81166006)(65956001)(7736002)(8676002)(31686004)(77096006)(76176999)(230700001)(6486002)(54356999)(66066001)(50986999)(6666003)(42186005)(36756003)(6246003)(305945005)(53936002)(966004)(3260700006)(4326008)(2906002)(53546009)(54906002)(6306002)(2950100002)(25786009)(142933001)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4PR0501MB2753;H:[10.15.7.185];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;AM4PR0501MB2753;23:kN2udVpZeFm9gAV8Z7HaX+szzaA7uCcMLQz?= =?Windows-1252?Q?n06waDrbbpkM5Rn52LjXD5+YlyfACjcufUVTy3iPqEaxZweL+b6Vzu6U?= =?Windows-1252?Q?XBHssnHtSWT/r1F/ICuy3kgGWY+fXOKX+Zn9/OWAFXyrt8RIXivfsPKp?= =?Windows-1252?Q?MgI9fbTnasEIhueJN4WSLtkePPZIcYLlaxsvDCsDDhJbrk4S4hvllHF0?= =?Windows-1252?Q?BU8BNl6xi1XstIwP4B4NgYHqmHluEg1+SCyD/g7gkoJeQQVadBYS3jRE?= =?Windows-1252?Q?GLESXAVVwHIvJac0Tbgs+I4gMo0e94PRZitvwAnKSJnBFzYX0kA8dzxp?= =?Windows-1252?Q?oB7S6WxBGUr98gbPf025lEAQ9DPqX+nouZPJt4AZJaqZhDBiIZWKMhio?= =?Windows-1252?Q?OPVoDPoeX354keCBWzvEyiW0L0w3iW4QN8ioTPRlfeXepH0eJy5740PA?= =?Windows-1252?Q?XqPRTVVlA2Q1Py/kGDfQDp5zrQWx/iksB0loSpe5Vff5Gw1XOE/WjtfI?= =?Windows-1252?Q?bcZLZjMH3M4D1ZMicOBQ083JNmYxjV2j8llbGHpI3EqzxbI0KAm+LUmW?= =?Windows-1252?Q?K/hxf1aHGW1S66BpH299AwhkRJK0xQBqiRD9f2BsxsH9tIgSQadOF86e?= =?Windows-1252?Q?br9xbd0AjZ0W/9iUekRdzAIsbPmV6WPh8X488LFUXFSbY0VYtyl9nhmQ?= =?Windows-1252?Q?q/Ri3DwMev6a5sfcd1vhomKKScrH4g+ycELQokqkBthJbysd3poN437K?= =?Windows-1252?Q?BSJL1u9RGvTlGK+V+yM4KHGOuZMOvU8cxYX6JPLXgMOZK2KQl1Ctiy1Z?= =?Windows-1252?Q?d+75pOD30jG/NS1vuxXD3uhfBEcob0AKzlbZFB3NaoaJcKGV7/3mSbbx?= =?Windows-1252?Q?CeBMQBVp341vna0L/Vd8T8CMMiTar9Ls7xI4k8YzGKBXvItONYK2GnfT?= =?Windows-1252?Q?hwhJ86gqf3uo/0jN8yKYfV7cuMbFuFc+Q7SaXjsS9UhRf7kR8p+aVm8A?= =?Windows-1252?Q?dX004/AsVQjQhksn7pea0wNKZel2mmyQ8bJuX5duCwSKI3IAfgBh6za3?= =?Windows-1252?Q?uOHxY2UiS5EjTp4vvyupSqjQEGDhYCsBFLMXzw2Lz9XhjbHZs5M8l9yu?= =?Windows-1252?Q?oipaJC6h/BvSffSHFHrGHkRHYPAUJRY6PMxvRwC73pB64qOVbtMsMXVe?= =?Windows-1252?Q?Wnj2gOUIzrc8NcfQsuUSsy3Tvi+3mFCf4doQ55dPtyEAwfPvyBgNXS9e?= =?Windows-1252?Q?xHdigEbqA12xMLKCfcqtWmKeQrV8OkLvPXpVrGql1g15SWodMG5Vpqdd?= =?Windows-1252?Q?T40tcnmgJF/NKXMwHXcmfeZgGtYiqhxDCrDG7e3E8ukGmygr4BkkkH+B?= =?Windows-1252?Q?5d45S18m2UpWVbmoGnmrQa9k1O3s3qJwNQSxJ5VO1oZAbILuUSiRWUIe?= =?Windows-1252?Q?pj6eoGprYnJ/OQkgmw57f1tuZT2bg6aApxOJMBfFC+G88G40m5teRozw?= =?Windows-1252?Q?PZfub3kesZCTMSbFdPklt9RiJKQ6y?= X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2753;6:FCCFZoN+ISElO1XZfbGVZlp6kBbxNY8JE0AcrY1J2TLjJ9Tn1ILTNO10/ToHTQgZ+wYWKUNgnhLHprPKbAhL1Vv+QuE9ktcP5npgoby1XO/8nU/4imMymQcqTQOCWxG5iBUdjgVhoxjm8L+4oylImvHzSymqTT1/F5CJMoFKXETWM5zEHV8HRuhli/9P1E0aGhN7eV2J1nmEsUFsOLCEeo4eXpEVSQda4xwLt0GleUfKNK8j9wLIHhg+6ps2vLROcA8hwXYSMfaoNmg3DYzWX8JOLQXJtAkYaFWsEnz6CQF5bXKqV7QstZPYbfhb1oeLDYUApMfAVgHjSUoKvXiLZYgKtR4KC6+XAtUsyEnCSDnQrk8Z4jMtqPhYMqVjyAwIxfSNByUQysfJIf/KXfuwhCY3iTx8djSY+2YdpzaVweA=;5:H3mkk2adzKXLGYbuFUGiUItYAm9ROU5uhcHQNzyndb0dDVAchH/Hmu6YQGLwXeoUvmh9ZdjWYLz4XWqkH5B4Kbsjn/vp/FWCdnLHr03XCfrEhyW3lxVWxS+LrBRN84+81pgD1q+b80unznYDVfMmwQ==;24:VwESTTtHOzD61UI9cI9JyS0fVKsRKqMjZsRGan/hUJHP3jgcASEUA2eMNtB8uteO5LXmoj4E+1lyuBRbaHk5/3R3rbirL+u+qFHr4iPgeok= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;AM4PR0501MB2753;7:Qwc4tyPNWr+ww1lk2gpEuitQbIPYiqDLcu3LTyNonYG2Cj3W1L6rPHjb4jqZwQo+g8bCA4lVGBtqF3nOwaiB1wC3D3srNoOe+UhIcTcd7X1TugEbe5AtF/+K2ICvZaAPJneURDYP3ENpeKg8+EuC5n9tBzRS8HbcIpHGycOS15Pm54Bo/0Xg/oW1m56YskBK5oRNyYf91HnJkvEiqkiehUwGDYIkL0bQA5+8lF8CZt6NYBZWe4R3Mj6/g1GIYGvj8m+Cl4omHJdFCIRBEzJQOy2MlHbZEJGnfkKf+7XGsMlRfuYEs7kEMzi4OaRsHzn8QSR2qVQs4QugAJOZxIjTeg== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2017 15:41:41.8526 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2753 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/30/2017 7:54 AM, Michal Hocko wrote: > From: Michal Hocko > > these functions are unreachable because tile doesn't support memory > hotplug becasuse it doesn't select ARCH_ENABLE_MEMORY_HOTPLUG nor > it supports SPARSEMEM. > > This code hasn't been compiled for a while obviously because nobody has > noticed that __add_pages has a different signature since 2009. > > Cc: Chris Metcalf > Signed-off-by: Michal Hocko > --- > arch/tile/mm/init.c | 30 ------------------------------ > 1 file changed, 30 deletions(-) Thanks - taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id 7750C6B0390 for ; Thu, 30 Mar 2017 11:41:47 -0400 (EDT) Received: by mail-pg0-f72.google.com with SMTP id m28so49326452pgn.14 for ; Thu, 30 Mar 2017 08:41:47 -0700 (PDT) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30080.outbound.protection.outlook.com. [40.107.3.80]) by mx.google.com with ESMTPS id o4si2481252plb.192.2017.03.30.08.41.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Mar 2017 08:41:46 -0700 (PDT) Subject: Re: [PATCH 2/6] mm, tile: drop arch_{add,remove}_memory References: <20170330115454.32154-1-mhocko@kernel.org> <20170330115454.32154-3-mhocko@kernel.org> From: Chris Metcalf Message-ID: Date: Thu, 30 Mar 2017 11:41:33 -0400 MIME-Version: 1.0 In-Reply-To: <20170330115454.32154-3-mhocko@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko , linux-mm@kvack.org Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Reza Arbab , Yasuaki Ishimatsu , Tang Chen , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , Zhang Zhen , David Rientjes , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Michal Hocko On 3/30/2017 7:54 AM, Michal Hocko wrote: > From: Michal Hocko > > these functions are unreachable because tile doesn't support memory > hotplug becasuse it doesn't select ARCH_ENABLE_MEMORY_HOTPLUG nor > it supports SPARSEMEM. > > This code hasn't been compiled for a while obviously because nobody has > noticed that __add_pages has a different signature since 2009. > > Cc: Chris Metcalf > Signed-off-by: Michal Hocko > --- > arch/tile/mm/init.c | 30 ------------------------------ > 1 file changed, 30 deletions(-) Thanks - taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org