From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanimir Varbanov Subject: Re: [PATCH v9 3/5] venus: firmware: register separate platform_device for firmware loader Date: Wed, 26 Sep 2018 10:51:08 +0300 Message-ID: References: <1537314192-26892-1-git-send-email-vgarodia@codeaurora.org> <1537314192-26892-4-git-send-email-vgarodia@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1537314192-26892-4-git-send-email-vgarodia@codeaurora.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Vikash Garodia , stanimir.varbanov@linaro.org, hverkuil@xs4all.nl, mchehab@kernel.org, robh@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, arnd@arndb.de, bjorn.andersson@linaro.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, acourbot@chromium.org List-Id: linux-arm-msm@vger.kernel.org Hi Vikash, On 09/19/2018 02:43 AM, Vikash Garodia wrote: > From: Stanimir Varbanov > > This registers a firmware platform_device and associate it with > video-firmware DT subnode. Then calls dma configure to initialize > dma and iommu. Please replace the description with something like this: This registers a firmware platform_device and associates it with video-firmware DT subnode, by that way we are able to parse iommu configuration. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platform/qcom/venus/core.c | 14 +++++--- > drivers/media/platform/qcom/venus/core.h | 3 ++ > drivers/media/platform/qcom/venus/firmware.c | 54 ++++++++++++++++++++++++++++ > drivers/media/platform/qcom/venus/firmware.h | 2 ++ > 4 files changed, 69 insertions(+), 4 deletions(-) > -- regards, Stan