From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225D1LLOvU4qMhA7nRG6gBW293wJOZ4O91kbCUK5K5uzTGqIaOjQf/GApyIoAp4XZrpibWmw ARC-Seal: i=1; a=rsa-sha256; t=1518486800; cv=none; d=google.com; s=arc-20160816; b=QK+vezFHR7FqbuKeAbK0LWYVPOStzlLc9sC8YxjvORm3lUedsqiTj21Mp2Q9Mz4y9r Z385wiVaTUlQBlW4kNub+efTok8Ip873xSX1T8n5/gbuF38OpM8i98cb6erDnbyLagEb WDdlyKx5KPKJVd/lNy/Rq6x1XuVj82rWSkcIiFB4zDbPO47mF38a9ATLWyXbPmiMWCYR F1ggXXtO0ZPIqMxehuapq21Y+mdBHDtmC5/i+QsBHnbq1fXbZci45ti779X32JgcLPFX dOWWkLwyB4niPcCeApIKy5gpS8yflenVax83+hF85qcyMSAb2wEYzOxS+WxdXq8dND/K oYbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature:dkim-signature:arc-authentication-results; bh=4MfvqemmosT/ay6A1TW3SAUIP61pcQFsaS5a1wXN7sM=; b=f6lWpa72ML/4MjuMuhp3v6w6apuCQlQ4Chz5hdFDFzUSUifgLKWpNowg+AuC9xeFpA C2ntEFwpR7QBISkQjONomPi8c7Vho9tnCwc9cWUQVJt+1I/m9cwKZG8e+oaMqursiv/a UybI9Ge71mKRmuc1UyQsYAB83P8dCCuxPFbh5QbfPZOJC7eOtlDmkWz8nRyER+kw6hHY WihOrAJGzJ+IfMTCyIygK2phRsvqRR5xkHVY0jLvhbDP8H2K2CdHMdOy1f75Ux3oHu/w 88FbIGy9JNqvHx0ssq8vmLEZWl2HPbcbz6ERVZDrFLN0hukzlIYdrkrTpvZAmeqrRpcN RbSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Y1G9rnp7; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=mWNWxoUi; spf=pass (google.com: best guess record for domain of rdunlap@infradead.org designates 85.118.1.10 as permitted sender) smtp.mailfrom=rdunlap@infradead.org Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Y1G9rnp7; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=mWNWxoUi; spf=pass (google.com: best guess record for domain of rdunlap@infradead.org designates 85.118.1.10 as permitted sender) smtp.mailfrom=rdunlap@infradead.org Subject: Re: [RFC PATCH 4/7] kconfig: support new special property shell= To: Masahiro Yamada Cc: Kees Cook , Ulf Magnusson , Linus Torvalds , Linux Kbuild mailing list , Greg Kroah-Hartman , Andrew Morton , Nicolas Pitre , "Luis R . Rodriguez" , Sam Ravnborg , Michal Marek , Martin Schwidefsky , Pavel Machek , linux-s390 , Jiri Kosina , Linux Kernel Mailing List , Tejun Heo , Ingo Molnar , "Van De Ven, Arjan" , Arnd Bergmann References: <20180210054843.z3g7wvcmlccvww3h@huvuddator> <20180210074924.3nhxsza5zdbaahxx@huvuddator> <20180210080556.mycqsjhxbaguwhay@huvuddator> <20180210085519.737ckf4bcl57h4g2@huvuddator> <20180211103432.pf2ot6nd7nbhdhsy@huvuddator> <49c196ec-891d-2030-bd6c-7222feb22059@infradead.org> From: Randy Dunlap Message-ID: Date: Mon, 12 Feb 2018 17:53:05 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1591850368607646970?= X-GMAIL-MSGID: =?utf-8?q?1592248815125911064?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 02/12/2018 05:41 PM, Masahiro Yamada wrote: > 2018-02-13 8:48 GMT+09:00 Randy Dunlap : >> On 02/12/2018 07:24 AM, Kees Cook wrote: >>> On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada >>> wrote: >> >>>>> (And in thinking about this, does Kconfig know the true $CC in use? >>>>> i.e. the configured cross compiler, etc?) >>>> >>>> I was thinking of removing CONFIG_CROSS_COMPILE. >>>> >>>> A user can dynamically change CROSS_COMPILE from >>>> "make menuconfig". >>> >>> Most builds I've seen implement cross compilers as an environment >>> variable during all "make" invocations. >> >> I agree. I think you would break a bunch of build bots if you remove that. > > > For clarification, I suggested to remove CONFIG_CROSS_COMPILE. > > The following code: > https://github.com/torvalds/linux/blob/v4.16-rc1/Makefile#L315 > https://github.com/torvalds/linux/blob/v4.16-rc1/init/Kconfig#L58 > > I hope build bots are not using this. > > > Passing CROSS_COMPILE via the command line, environment > is still supported. OK, I misunderstood. That one can go away IMO. thanks, -- ~Randy