All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ludovic Desroches via buildroot <buildroot@busybox.net>
To: <arnout@mind.be>, <buildroot@buildroot.org>
Cc: thomas.petazzoni@bootlin.com, Eugen.Hristev@microchip.com,
	biagio.hkr@gmail.com, bonet@grenoble.cnrs.fr,
	Nicolas.Ferre@microchip.com
Subject: Re: [Buildroot] [PATCH 2/3] configs/acmesystems_*: bump at91bootstrap3 version
Date: Wed, 18 Aug 2021 11:20:28 +0000	[thread overview]
Message-ID: <b19518d7-4b48-e3fc-6d4c-f84238f1186d@microchip.com> (raw)
In-Reply-To: <aeca7e19-f3f0-c66b-8033-f6bb1da29ab2@mind.be>

> 
> On 16/08/2021 14:04, Ludovic Desroches via buildroot wrote:
>> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
>> ---
>>   configs/acmesystems_acqua_a5_256mb_defconfig    | 2 +-
>>   configs/acmesystems_acqua_a5_512mb_defconfig    | 2 +-
>>   configs/acmesystems_aria_g25_128mb_defconfig    | 2 +-
>>   configs/acmesystems_aria_g25_256mb_defconfig    | 2 +-
>>   configs/acmesystems_arietta_g25_128mb_defconfig | 2 +-
>>   configs/acmesystems_arietta_g25_256mb_defconfig | 2 +-
>>   6 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/configs/acmesystems_acqua_a5_256mb_defconfig b/configs/acmesystems_acqua_a5_256mb_defconfig
>> index 00b99c0ad8..f8129f3780 100644
>> --- a/configs/acmesystems_acqua_a5_256mb_defconfig
>> +++ b/configs/acmesystems_acqua_a5_256mb_defconfig
>> @@ -19,7 +19,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="5232adb1c42636e1e9cf495a6abd1a8d66475f83"
>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
> 
>   The point of having a fixed version is so that we are sure that it's only
> updated after actually testin on a board. If you make such a wholesale change, I
> assume you haven't actually tested it on all those boards... So you could just
> as well have set BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X...

Right I didn't test it on old boards. I discussed with Eugen, the 
maintainer of at91bootstrap, the need to release a 3.8.x and a 3.9.x or 
not. 3.9 and 3.10 are about support for new boards so there is no 
compatibility problem. Nevertheless, it's true that unless it it has 
been tested we are not 100% sure...

If we set BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X, the risk is 
higher as it becomes a continuous risk versus a one-shot risk.

I have no strong opinion, so if there is a preference to set 
BR2_TARGET_AT91BOOTSTRAP3_LATEST_VERSION_3X, I'll update the patches.

Regards,
Ludovic



> 
>   That said, we really have to do this because all the defconfigs are broken at
> the moment, so applied the series to master, thanks.
> 
>   Regards,
>   Arnout
> 
>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="acqua-256m"
>>   BR2_PACKAGE_HOST_DOSFSTOOLS=y
>>   BR2_PACKAGE_HOST_GENIMAGE=y
>> diff --git a/configs/acmesystems_acqua_a5_512mb_defconfig b/configs/acmesystems_acqua_a5_512mb_defconfig
>> index f4af2501b8..e399d4a9ff 100644
>> --- a/configs/acmesystems_acqua_a5_512mb_defconfig
>> +++ b/configs/acmesystems_acqua_a5_512mb_defconfig
>> @@ -19,7 +19,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="5232adb1c42636e1e9cf495a6abd1a8d66475f83"
>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="acqua-512m"
>>   BR2_PACKAGE_HOST_DOSFSTOOLS=y
>>   BR2_PACKAGE_HOST_GENIMAGE=y
>> diff --git a/configs/acmesystems_aria_g25_128mb_defconfig b/configs/acmesystems_aria_g25_128mb_defconfig
>> index cf62b5b72e..8bc8c4dcef 100644
>> --- a/configs/acmesystems_aria_g25_128mb_defconfig
>> +++ b/configs/acmesystems_aria_g25_128mb_defconfig
>> @@ -29,7 +29,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.13"
>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="aria-128m"
>>
>>   # Tools to build sdcard.img
>> diff --git a/configs/acmesystems_aria_g25_256mb_defconfig b/configs/acmesystems_aria_g25_256mb_defconfig
>> index 496ccd6853..d161b118ae 100644
>> --- a/configs/acmesystems_aria_g25_256mb_defconfig
>> +++ b/configs/acmesystems_aria_g25_256mb_defconfig
>> @@ -29,7 +29,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.13"
>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="aria-256m"
>>
>>   # Tools to build sdcard.img
>> diff --git a/configs/acmesystems_arietta_g25_128mb_defconfig b/configs/acmesystems_arietta_g25_128mb_defconfig
>> index 17ef7e757c..62bcbd44cb 100644
>> --- a/configs/acmesystems_arietta_g25_128mb_defconfig
>> +++ b/configs/acmesystems_arietta_g25_128mb_defconfig
>> @@ -29,7 +29,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.13"
>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="arietta-128m"
>>
>>   # Tools to build sdcard.img
>> diff --git a/configs/acmesystems_arietta_g25_256mb_defconfig b/configs/acmesystems_arietta_g25_256mb_defconfig
>> index aa0236bbb3..94258444a2 100644
>> --- a/configs/acmesystems_arietta_g25_256mb_defconfig
>> +++ b/configs/acmesystems_arietta_g25_256mb_defconfig
>> @@ -29,7 +29,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>>   BR2_TARGET_AT91BOOTSTRAP3=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
>>   BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
>> -BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.8.13"
>> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="v3.10.3"
>>   BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="arietta-256m"
>>
>>   # Tools to build sdcard.img
>>

_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

  reply	other threads:[~2021-08-18 11:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 12:04 [Buildroot] [PATCH 0/3] Fix Microchip breakage related to at91bootstrap Ludovic Desroches via buildroot
2021-08-16 12:04 ` [Buildroot] [PATCH 1/3] boot/at91bootstrap3: bump 3.x series to 3.10.3 Ludovic Desroches via buildroot
2021-08-16 12:04 ` [Buildroot] [PATCH 2/3] configs/acmesystems_*: bump at91bootstrap3 version Ludovic Desroches via buildroot
2021-08-17 21:19   ` Arnout Vandecappelle
2021-08-18 11:20     ` Ludovic Desroches via buildroot [this message]
2021-08-18 11:35       ` Arnout Vandecappelle
2021-08-18 11:39       ` Eugen.Hristev--- via buildroot
2021-08-18 18:39       ` Edgar Bonet
2021-08-16 12:04 ` [Buildroot] [PATCH 3/3] configs/{atmel, microchip}: " Ludovic Desroches via buildroot
2021-08-16 17:44   ` Pierre-Jean Texier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b19518d7-4b48-e3fc-6d4c-f84238f1186d@microchip.com \
    --to=buildroot@busybox.net \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=arnout@mind.be \
    --cc=biagio.hkr@gmail.com \
    --cc=bonet@grenoble.cnrs.fr \
    --cc=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.