* [PATCH V2] target: fix the pgr/alua_support_store functions
@ 2021-09-06 15:18 Maurizio Lombardi
2021-09-06 15:44 ` Bodo Stroesser
2021-09-14 3:43 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Maurizio Lombardi @ 2021-09-06 15:18 UTC (permalink / raw)
To: martin.petersen; +Cc: bostroesser, michael.christie, target-devel, linux-scsi
Commit 356ba2a8bc8d ("scsi: target: tcmu: Make pgr_support and
alua_support attributes writable")
introduced support for changeable alua_support and pgr_support
target attributes. They can only be changed
if the backstore is user-backed, otherwise the kernel returns -EINVAL.
This triggers a warning in the targetcli/rtslib code when performing
a target restore that includes non-userbacked backstores:
#targetctl restore
Storage Object block/storage1: Cannot set attribute alua_support:
[Errno 22] Invalid argument, skipped
Storage Object block/storage1: Cannot set attribute pgr_support:
[Errno 22] Invalid argument, skipped
Fix this warning by returning an error code only if we are really
going to flip the PGR/ALUA bit in the transport_flags field,
otherwise we'll do nothing and return success.
Return ENOSYS instead of EINVAL if the pgr/alua attributes
can't be changed, this way it'll be possible for userspace to understand
if the operation failed because an invalid value has been passed
to strtobool() or because the attributes are fixed.
Fixes: 356ba2a8bc8d ("scsi: target: tcmu: Make pgr_support and alua_support attributes writable")
v2: replace EOPNOTSUPP with ENOSYS
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
drivers/target/target_core_configfs.c | 32 +++++++++++++++++----------
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 102ec644bc8a..023bd4516a68 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -1110,20 +1110,24 @@ static ssize_t alua_support_store(struct config_item *item,
{
struct se_dev_attrib *da = to_attrib(item);
struct se_device *dev = da->da_dev;
- bool flag;
+ bool flag, oldflag;
int ret;
+ ret = strtobool(page, &flag);
+ if (ret < 0)
+ return ret;
+
+ oldflag = !(dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_ALUA);
+ if (flag == oldflag)
+ return count;
+
if (!(dev->transport->transport_flags_changeable &
TRANSPORT_FLAG_PASSTHROUGH_ALUA)) {
pr_err("dev[%p]: Unable to change SE Device alua_support:"
" alua_support has fixed value\n", dev);
- return -EINVAL;
+ return -ENOSYS;
}
- ret = strtobool(page, &flag);
- if (ret < 0)
- return ret;
-
if (flag)
dev->transport_flags &= ~TRANSPORT_FLAG_PASSTHROUGH_ALUA;
else
@@ -1145,20 +1149,24 @@ static ssize_t pgr_support_store(struct config_item *item,
{
struct se_dev_attrib *da = to_attrib(item);
struct se_device *dev = da->da_dev;
- bool flag;
+ bool flag, oldflag;
int ret;
+ ret = strtobool(page, &flag);
+ if (ret < 0)
+ return ret;
+
+ oldflag = !(dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_PGR);
+ if (flag == oldflag)
+ return count;
+
if (!(dev->transport->transport_flags_changeable &
TRANSPORT_FLAG_PASSTHROUGH_PGR)) {
pr_err("dev[%p]: Unable to change SE Device pgr_support:"
" pgr_support has fixed value\n", dev);
- return -EINVAL;
+ return -ENOSYS;
}
- ret = strtobool(page, &flag);
- if (ret < 0)
- return ret;
-
if (flag)
dev->transport_flags &= ~TRANSPORT_FLAG_PASSTHROUGH_PGR;
else
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] target: fix the pgr/alua_support_store functions
2021-09-06 15:18 [PATCH V2] target: fix the pgr/alua_support_store functions Maurizio Lombardi
@ 2021-09-06 15:44 ` Bodo Stroesser
2021-09-14 3:43 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Bodo Stroesser @ 2021-09-06 15:44 UTC (permalink / raw)
To: Maurizio Lombardi, martin.petersen
Cc: michael.christie, target-devel, linux-scsi
On 06.09.21 17:18, Maurizio Lombardi wrote:
> Commit 356ba2a8bc8d ("scsi: target: tcmu: Make pgr_support and
> alua_support attributes writable")
> introduced support for changeable alua_support and pgr_support
> target attributes. They can only be changed
> if the backstore is user-backed, otherwise the kernel returns -EINVAL.
>
> This triggers a warning in the targetcli/rtslib code when performing
> a target restore that includes non-userbacked backstores:
>
> #targetctl restore
> Storage Object block/storage1: Cannot set attribute alua_support:
> [Errno 22] Invalid argument, skipped
> Storage Object block/storage1: Cannot set attribute pgr_support:
> [Errno 22] Invalid argument, skipped
>
> Fix this warning by returning an error code only if we are really
> going to flip the PGR/ALUA bit in the transport_flags field,
> otherwise we'll do nothing and return success.
>
> Return ENOSYS instead of EINVAL if the pgr/alua attributes
> can't be changed, this way it'll be possible for userspace to understand
> if the operation failed because an invalid value has been passed
> to strtobool() or because the attributes are fixed.
>
> Fixes: 356ba2a8bc8d ("scsi: target: tcmu: Make pgr_support and alua_support attributes writable")
>
> v2: replace EOPNOTSUPP with ENOSYS
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
Reviewed-by: Bodo Stroesser <bostroesser@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] target: fix the pgr/alua_support_store functions
2021-09-06 15:18 [PATCH V2] target: fix the pgr/alua_support_store functions Maurizio Lombardi
2021-09-06 15:44 ` Bodo Stroesser
@ 2021-09-14 3:43 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2021-09-14 3:43 UTC (permalink / raw)
To: Maurizio Lombardi
Cc: Martin K . Petersen, michael.christie, linux-scsi, target-devel,
bostroesser
On Mon, 6 Sep 2021 17:18:09 +0200, Maurizio Lombardi wrote:
> Commit 356ba2a8bc8d ("scsi: target: tcmu: Make pgr_support and
> alua_support attributes writable")
> introduced support for changeable alua_support and pgr_support
> target attributes. They can only be changed
> if the backstore is user-backed, otherwise the kernel returns -EINVAL.
>
> This triggers a warning in the targetcli/rtslib code when performing
> a target restore that includes non-userbacked backstores:
>
> [...]
Applied to 5.15/scsi-fixes, thanks!
[1/1] target: fix the pgr/alua_support_store functions
https://git.kernel.org/mkp/scsi/c/ef7ae7f746e9
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-14 3:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-06 15:18 [PATCH V2] target: fix the pgr/alua_support_store functions Maurizio Lombardi
2021-09-06 15:44 ` Bodo Stroesser
2021-09-14 3:43 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.