From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03B83C433EF for ; Wed, 29 Jun 2022 22:55:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231477AbiF2WzB (ORCPT ); Wed, 29 Jun 2022 18:55:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbiF2Wyh (ORCPT ); Wed, 29 Jun 2022 18:54:37 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 878873FDB3 for ; Wed, 29 Jun 2022 15:54:05 -0700 (PDT) Received: from [192.168.1.90] (unknown [188.24.177.228]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id BBCD26601933; Wed, 29 Jun 2022 23:54:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656543243; bh=NPpKl2bppLzLhD0GjNYn7KYiv5/qMiG43eoBG7+S+ZI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YUltykbyQlXRz6QyDjVK4cKpJIBgOmnE2pzt9ruem/bO/Xv0nTfYjRKbqBXgz0Rpb DOyVwslbRCYiRg//Au2SL27jD9qlaPxSrUQCzeufO8UWY2uJMNiW2kScSlOHObL6uQ VDUnEvOjphdPrzOF7k6j6BVA8wklDZpBbuQi85qCY353f1mBJHXeEeDiNF0WNR0MIy JtZusP9qddOmBK6T+SSYggkXNm+QrQVaJAPWicZIKP37Le9xui+V1RQDs2p/WldVBe dzx0Ez8Ke7dL3kueutpJFn5o7/YuNHTy5A6dIQc5LQ/JOZyMKNMMzmt+EK1v0T1t8i khPqrL3F50CuQ== Message-ID: Date: Thu, 30 Jun 2022 01:54:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] scripts/tags.sh: Include tools directory in tags generation Content-Language: en-US To: Vipin Sharma , Greg KH , rkovhaev@gmail.com, zackary.liu.pro@gmail.com, ripxorip@gmail.com, masahiroy@kernel.org, xujialu@vimux.org, "drjones@redhat.com" Cc: dmatlack@google.com, linux-kernel@vger.kernel.org References: <20220618005457.2379324-1-vipinsh@google.com> From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/30/22 01:18, Vipin Sharma wrote: > On Mon, Jun 27, 2022 at 11:05 PM Greg KH wrote: >> >> On Mon, Jun 27, 2022 at 10:47:35AM -0700, Vipin Sharma wrote: >>> On Fri, Jun 17, 2022 at 5:55 PM Vipin Sharma wrote: >>>> >>>> Add tools directory in generating tags and quiet the "No such file or >>>> directory" warnings. >>>> >>>> It reverts the changes introduced in commit 162343a876f1 >>>> ("scripts/tags.sh: exclude tools directory from tags generation") while >>>> maintainig the original intent of the patch to get rid of the warnings. >>>> This allows the root level cscope files to include tools source code >>>> besides kernel and a single place to browse the code for both. >>>> >>>> Signed-off-by: Vipin Sharma >>>> --- >>>> >>>> I have found myself many times to browse tools and other part of the >>>> kernel code together. Excluding tools from the root level cscope makes >>>> it difficult to efficiently move between files and find user api >>>> definitions. >>>> >>>> Root cause of these warning is due to generated .cmd files which use >>>> relative paths in some files, I am not sure how to make them absolute >>>> file paths which can satisfy realpath warnings. Also, not sure if those >>>> warnings are helpful and should be kept. Passing "-q" to realpath seems >>>> easier solution. Please, let me know if there is a better alternative. >>>> >>>> Thanks >>>> >>>> scripts/tags.sh | 9 +-------- >>>> 1 file changed, 1 insertion(+), 8 deletions(-) >>>> >>>> diff --git a/scripts/tags.sh b/scripts/tags.sh >>>> index 01fab3d4f90b5..e137cf15aae9d 100755 >>>> --- a/scripts/tags.sh >>>> +++ b/scripts/tags.sh >>>> @@ -25,13 +25,6 @@ else >>>> tree=${srctree}/ >>>> fi >>>> >>>> -# ignore userspace tools >>>> -if [ -n "$COMPILED_SOURCE" ]; then >>>> - ignore="$ignore ( -path ./tools ) -prune -o" >>>> -else >>>> - ignore="$ignore ( -path ${tree}tools ) -prune -o" >>>> -fi >>>> - >>>> # Detect if ALLSOURCE_ARCHS is set. If not, we assume SRCARCH >>>> if [ "${ALLSOURCE_ARCHS}" = "" ]; then >>>> ALLSOURCE_ARCHS=${SRCARCH} >>>> @@ -100,7 +93,7 @@ all_compiled_sources() >>>> find $ignore -name "*.cmd" -exec \ >>>> grep -Poh '(?(?=^source_.* \K).*|(?=^ \K\S).*(?= \\))' {} \+ | >>>> awk '!a[$0]++' >>>> - } | xargs realpath -es $([ -z "$KBUILD_ABS_SRCTREE" ] && echo --relative-to=.) | >>>> + } | xargs realpath -esq $([ -z "$KBUILD_ABS_SRCTREE" ] && echo --relative-to=.) | >>>> sort -u >>>> } >>>> >>>> -- >>>> 2.37.0.rc0.104.g0611611a94-goog >>>> >>> >>> Hi Greg, >>> >>> Any update on the patch? >> >> Nope! >> >> I don't really think we should add back in the tools to this, as if you >> want to search them, then can't you just generate the needed tags for >> the tools directory? >> > > Some folders in the tools directory do provide cscope rules. However, > those tags can only be used when I open the vim in those directories. > For example, if I am writing a KVM selftest and I want to explore code > related to certain ioctl in kernel as well as some code in KVM > selftest library, I cannot use two cscope files (one in the kernel > root dir and another in tools/testing/selftests/kvm) in a single VIM > instance. It starts having issues with the file paths. If the root > level cscope file includes tools directory then all of the tags will > be at one place and makes it very easy to browse tools code along with > the rest of the kernel. > >> But as I don't even use this script ever, it feels odd for me to be the >> one "owning" it, so it would be great if others could chime in who >> actually use it. >> Since the tools directory has been excluded just to get rid of those warnings, I think there is no obvious reason to not add it back - at least the use case described above is perfectly valid. > I have added some folks in this email who have touched this script > file in the last couple of years or use cscope, hopefully they can > chime in. > > Thanks > Vipin