From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C67CC433E3 for ; Mon, 17 Aug 2020 12:28:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23AC620658 for ; Mon, 17 Aug 2020 12:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728385AbgHQM2t (ORCPT ); Mon, 17 Aug 2020 08:28:49 -0400 Received: from foss.arm.com ([217.140.110.172]:54458 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbgHQM2s (ORCPT ); Mon, 17 Aug 2020 08:28:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA29330E; Mon, 17 Aug 2020 05:28:47 -0700 (PDT) Received: from [10.37.12.68] (unknown [10.37.12.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF22B3F66B; Mon, 17 Aug 2020 05:28:45 -0700 (PDT) Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Additional locking for 'curr_rate' To: Krzysztof Kozlowski Cc: oss-self-reviewed-patches@listhost.cambridge.arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kgene@kernel.org, b.zolnierkie@samsung.com References: <20200811101727.3976-1-lukasz.luba@arm.com> <20200817115435.GA2346@kozik-lap> From: Lukasz Luba Message-ID: Date: Mon, 17 Aug 2020 13:28:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200817115435.GA2346@kozik-lap> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 8/17/20 12:54 PM, Krzysztof Kozlowski wrote: > On Tue, Aug 11, 2020 at 11:17:27AM +0100, Lukasz Luba wrote: >> The 'curr_rate' is protected by local 'dmc->lock' in various places, but >> not in a function exynos5_dmc_get_status(). The lock protects frequency >> (and voltage) change process and the corresponding value stored in >> 'curr_rate'. Add the locking mechanism to protect the 'curr_rate' reading >> also in the exynos5_dmc_get_status(). >> >> Suggested-by: Krzysztof Kozlowski >> Signed-off-by: Lukasz Luba >> --- >> drivers/memory/samsung/exynos5422-dmc.c | 3 +++ > > Thanks, applied. > Thank you for applying it. Regards, Lukasz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3CEC433E1 for ; Mon, 17 Aug 2020 12:30:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 453C3204EA for ; Mon, 17 Aug 2020 12:30:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gkco+DU8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 453C3204EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VbWsb13uree40DkC2Jm3LTnuilsgO0YI4iwwcQPfGpw=; b=gkco+DU8HyxZixoUAq95s3aGV WvamIRmEY5I4PNqr1TvoOotsidkFoFI2J3VsNY9nMMbtz/X/4H3WctYugRfa6bHMtS8NIKk00CbWI m8xSf30uQv+TZqqGT2Ylbdn9co3W5dt1+26NepBjVtmOnP8AJTyrOlRefS7j2wrRZS6TNovVsbAQA OSH1GVZ725D6mnwwMfZ2CsTmSqZuh/sG8i3PAoWgEjB6UwfymDp7FFXI0am3t0Qk0Hf6+E89EaF9A Zi8CLg3DdQtHyVprsOJPHgOiEGl/AprIXpaqWMJ+GRKcElPXSYhVMV8taAcKdm9k1ZkS1YYaFZlla 0ZLwX9r0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7eFz-0004SI-V7; Mon, 17 Aug 2020 12:28:56 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7eFv-0004Q8-Kv for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 12:28:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA29330E; Mon, 17 Aug 2020 05:28:47 -0700 (PDT) Received: from [10.37.12.68] (unknown [10.37.12.68]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF22B3F66B; Mon, 17 Aug 2020 05:28:45 -0700 (PDT) Subject: Re: [PATCH] memory: samsung: exynos5422-dmc: Additional locking for 'curr_rate' To: Krzysztof Kozlowski References: <20200811101727.3976-1-lukasz.luba@arm.com> <20200817115435.GA2346@kozik-lap> From: Lukasz Luba Message-ID: Date: Mon, 17 Aug 2020 13:28:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200817115435.GA2346@kozik-lap> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_082851_782767_7C2F8635 X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, linux-pm@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, oss-self-reviewed-patches@listhost.cambridge.arm.com, kgene@kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 8/17/20 12:54 PM, Krzysztof Kozlowski wrote: > On Tue, Aug 11, 2020 at 11:17:27AM +0100, Lukasz Luba wrote: >> The 'curr_rate' is protected by local 'dmc->lock' in various places, but >> not in a function exynos5_dmc_get_status(). The lock protects frequency >> (and voltage) change process and the corresponding value stored in >> 'curr_rate'. Add the locking mechanism to protect the 'curr_rate' reading >> also in the exynos5_dmc_get_status(). >> >> Suggested-by: Krzysztof Kozlowski >> Signed-off-by: Lukasz Luba >> --- >> drivers/memory/samsung/exynos5422-dmc.c | 3 +++ > > Thanks, applied. > Thank you for applying it. Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel