All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@kernel.org>
To: x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Cc: Borislav Petkov <bp@alien8.de>, Stas Sergeev <stsp@list.ru>,
	bartoldeman@gmail.com, Brian Gerst <brgerst@gmail.com>,
	Andy Lutomirski <luto@kernel.org>,
	stable@vger.kernel.org
Subject: [PATCH 1/3] selftests/x86/entry_from_vm86: Exit with 1 if we fail
Date: Tue, 13 Mar 2018 22:03:10 -0700	[thread overview]
Message-ID: <b1cc37144038958a469c8f70a5f47a6a5638636a.1521003603.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1521003603.git.luto@kernel.org>
In-Reply-To: <cover.1521003603.git.luto@kernel.org>

Fix a logic error that caused the test to exit with 0 even if test
cases failed.

Cc: stable@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
 tools/testing/selftests/x86/entry_from_vm86.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/entry_from_vm86.c b/tools/testing/selftests/x86/entry_from_vm86.c
index 361466a2eaef..6e85f0d0498d 100644
--- a/tools/testing/selftests/x86/entry_from_vm86.c
+++ b/tools/testing/selftests/x86/entry_from_vm86.c
@@ -318,7 +318,7 @@ int main(void)
 	clearhandler(SIGSEGV);
 
 	/* Make sure nothing explodes if we fork. */
-	if (fork() > 0)
+	if (fork() == 0)
 		return 0;
 
 	return (nerrs == 0 ? 0 : 1);
-- 
2.14.3

  reply	other threads:[~2018-03-14  5:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14  5:03 [PATCH 0/3] x86/vm86/32: A bugfix and a matching test improvement Andy Lutomirski
2018-03-14  5:03 ` Andy Lutomirski [this message]
2018-03-14  8:46   ` [tip:x86/pti] selftests/x86/entry_from_vm86: Exit with 1 if we fail tip-bot for Andy Lutomirski
2018-03-14  5:03 ` [PATCH 2/3] selftests/x86/entry_from_vm86: Add test cases for POPF Andy Lutomirski
2018-03-14  8:46   ` [tip:x86/pti] " tip-bot for Andy Lutomirski
2018-03-14  5:03 ` [PATCH 3/3] x86/vm86/32: Fix POPF emulation Andy Lutomirski
2018-03-14  8:47   ` [tip:x86/pti] " tip-bot for Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b1cc37144038958a469c8f70a5f47a6a5638636a.1521003603.git.luto@kernel.org \
    --to=luto@kernel.org \
    --cc=bartoldeman@gmail.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=stsp@list.ru \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.