From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E8BDC11F6A for ; Fri, 2 Jul 2021 08:05:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24C01613FB for ; Fri, 2 Jul 2021 08:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbhGBIHs (ORCPT ); Fri, 2 Jul 2021 04:07:48 -0400 Received: from comms.puri.sm ([159.203.221.185]:43932 "EHLO comms.puri.sm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbhGBIHr (ORCPT ); Fri, 2 Jul 2021 04:07:47 -0400 Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 9B003DF80A; Fri, 2 Jul 2021 01:04:44 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D7DRqfSlUVAH; Fri, 2 Jul 2021 01:04:40 -0700 (PDT) Message-ID: Subject: Re: [PATCH v5 2/3] scsi: sd: send REQUEST SENSE for BLIST_MEDIA_CHANGE devices in runtime_resume() From: Martin Kepplinger To: Christoph Hellwig Cc: bvanassche@acm.org, jejb@linux.ibm.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, kernel@puri.sm, stern@rowland.harvard.edu Date: Fri, 02 Jul 2021 10:04:35 +0200 In-Reply-To: References: <20210630084453.186764-1-martin.kepplinger@puri.sm> <20210630084453.186764-3-martin.kepplinger@puri.sm> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, dem 01.07.2021 um 15:49 +0100 schrieb Christoph Hellwig: > On Wed, Jun 30, 2021 at 10:44:52AM +0200, Martin Kepplinger wrote: > > +       struct scsi_disk *sdkp = dev_get_drvdata(dev); > > +       struct scsi_device *sdp = sdkp->device; > > +       int timeout, res; > > + > > +       timeout = sdp->request_queue->rq_timeout * > > SD_FLUSH_TIMEOUT_MULTIPLIER; > > Is REQUEST SENSE reqlly a so slow operation on these devices that > we need to override the timeout? using SD_TIMEOUT works equally fine for me. Is that what you'd rather like to see? Bart, is SD_TIMEOUT equally ok for you? If so, I'll resend with your reviewed-by. thank you for reviewing! martin