From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbdHXTXM (ORCPT ); Thu, 24 Aug 2017 15:23:12 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:35053 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbdHXTXL (ORCPT ); Thu, 24 Aug 2017 15:23:11 -0400 Subject: Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency To: Arnd Bergmann , Greg Kroah-Hartman Cc: Ping-Ke Shih , Yan-Hsuan Chuang , Birming Chiu , Shaofu , Steven Ting , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <20170823132337.517466-1-arnd@arndb.de> <20170823132337.517466-2-arnd@arndb.de> From: Larry Finger Message-ID: Date: Thu, 24 Aug 2017 14:23:08 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170823132337.517466-2-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/23/2017 08:22 AM, Arnd Bergmann wrote: > Like the version in drivers/net/wireless, this driver requires the > MAC80211 framework, otherwise we run into a link error: > > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined! > ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined! > ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined! > ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined! > > This adds the Kconfig dependency for it. > > Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver") > Signed-off-by: Arnd Bergmann Greg, I lost track of which version of this patch you are taking. The one that Randy Dunlap sent that added NETDEVICES was better than the initial version, but this one with MAC80211 is the correct one. Randy's patch is in the latest pull I did on staging. Do you want an updated patch? Larry > --- > drivers/staging/rtlwifi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtlwifi/Kconfig b/drivers/staging/rtlwifi/Kconfig > index fc482b49f9aa..cb3a29ae764b 100644 > --- a/drivers/staging/rtlwifi/Kconfig > +++ b/drivers/staging/rtlwifi/Kconfig > @@ -1,6 +1,6 @@ > config R8822BE > tristate "Realtek RTL8822BE Wireless Network Adapter" > - depends on PCI && m > + depends on PCI && MAC80211 && m > select FW_LOADER > ---help--- > This is the staging driver for Realtek RTL8822BE 802.11ac PCIe >