All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Antipov <dmantipov@yandex.ru>
To: Ping-Ke Shih <pkshih@realtek.com>,
	Larry Finger <Larry.Finger@lwfinger.net>
Cc: Kalle Valo <kvalo@kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>,
	Dmitriy Antipov <Dmitriy.Antipov@softline.com>
Subject: Re: [PATCH] rtlwifi: rtl8188ee: drop RTX_POWER_BEFORE_IQK_A and RTX_POWER_AFTER_IQK_A reads
Date: Wed, 31 May 2023 08:51:07 +0300	[thread overview]
Message-ID: <b2198915-0e92-de99-d950-be46c2bd8e91@yandex.ru> (raw)
In-Reply-To: <c861d21d606441c9bf40ff963090d098@realtek.com>

On 5/31/23 03:25, Ping-Ke Shih wrote:

> Another way is to add a debug message to show them, and then static checker
> shouldn't warn this. Also, people can diagnose IQK & LOK results if needed.

1. When CONFIG_RTLWIFI_DEBUG is not set, rtl_dbg() becomes a no-op inline
function which doesn't use any of its arguments at all. This may (an will)
cause the tool to produce even more warnings.

2. I don't like an idea to add some code just to make some tool happy.

3. In general, is it always (or just sometimes) required to read (some
subset of?) BB registers even if we don't interested in their values?
Is it explicitly required by the hardware design?

Thanks,
Dmitry


  reply	other threads:[~2023-05-31  5:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 15:54 [PATCH] rtlwifi: rtl8188ee: drop RTX_POWER_BEFORE_IQK_A and RTX_POWER_AFTER_IQK_A reads Dmitry Antipov
2023-05-30 17:42 ` Larry Finger
2023-05-30 18:26   ` Dmitry Antipov
2023-05-30 18:55     ` Larry Finger
2023-05-31  0:25       ` Ping-Ke Shih
2023-05-31  5:51         ` Dmitry Antipov [this message]
2023-06-01  0:53           ` Ping-Ke Shih
2023-06-01 10:52           ` [PATCH] rtlwifi: rtl8188ee: mark RTX_POWER_{BEFORE,AFTER}_IQK_A reads as unused Dmitry Antipov
2023-06-01 12:30             ` Ping-Ke Shih
2023-06-01 13:50               ` Dmitry Antipov
2023-06-02  6:13                 ` Ping-Ke Shih
2023-06-05  9:43                   ` Dmitry Antipov
2023-06-13  8:17                 ` Kalle Valo
2023-06-13  8:18             ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2198915-0e92-de99-d950-be46c2bd8e91@yandex.ru \
    --to=dmantipov@yandex.ru \
    --cc=Dmitriy.Antipov@softline.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.