From: Andrew Cooper <Andrew.Cooper3@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: George Dunlap <George.Dunlap@citrix.com>,
Jan Beulich <jbeulich@suse.com>, Julien Grall <julien@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] livepatch: set -f{function,data}-sections compiler option
Date: Wed, 2 Mar 2022 15:35:07 +0000 [thread overview]
Message-ID: <b2381496-4dc5-5051-2bf5-9d164041c9c8@citrix.com> (raw)
In-Reply-To: <20220302134425.38465-1-roger.pau@citrix.com>
On 02/03/2022 13:44, Roger Pau Monne wrote:
> diff --git a/xen/common/Kconfig b/xen/common/Kconfig
> index 6443943889..2423d9f490 100644
> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -353,7 +353,9 @@ config CRYPTO
> config LIVEPATCH
> bool "Live patching support"
> default X86
> - depends on "$(XEN_HAS_BUILD_ID)" = "y"
> + depends on "$(XEN_HAS_BUILD_ID)" = "y" && \
> + $(cc-option,-ffunction-sections) && \
> + $(cc-option,-fdata-sections)
cc-option can take multiple, so just $(cc-option,-ffunction-sections
-fdata-sections)
However, we in practice want these in combination with $(LD)
--gc-sections anyway although that wants to be separately configurable.
Therefore, we probably want something like:
config FUNC_SECTIONS
bool
config LIVEPATCH
selects FUNC_SECTIONS
or so, so in the future we can add "config LD_GC_SECTIONS" which also
selects FUNC_SECTIONS.
Thoughts?
~Andrew
next prev parent reply other threads:[~2022-03-02 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 13:44 [PATCH] livepatch: set -f{function,data}-sections compiler option Roger Pau Monne
2022-03-02 14:41 ` Jan Beulich
2022-03-02 15:46 ` Roger Pau Monné
2022-03-02 16:09 ` Jan Beulich
2022-03-02 16:20 ` Roger Pau Monné
2022-03-02 16:13 ` Jan Beulich
2022-03-02 15:35 ` Andrew Cooper [this message]
2022-03-02 16:13 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2381496-4dc5-5051-2bf5-9d164041c9c8@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.