From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934320AbdIYJWa (ORCPT ); Mon, 25 Sep 2017 05:22:30 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:36777 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933212AbdIYJW2 (ORCPT ); Mon, 25 Sep 2017 05:22:28 -0400 Subject: Re: [RFC PATCH 0/7] AXP803 AC/Battery support To: Jonathan Cameron , Icenowy Zheng Cc: devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Jonathan Cameron , Maxime Ripard , Chen-Yu Tsai , Lee Jones , linux-arm-kernel@lists.infradead.org References: <20170920151814.22461-1-icenowy@aosc.io> <20170921154621.0000328d@huawei.com> <20170924153647.1d82e83c@archlinux> From: Quentin Schulz Message-ID: Date: Mon, 25 Sep 2017 11:22:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170924153647.1d82e83c@archlinux> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Icenowy, On 24/09/2017 16:36, Jonathan Cameron wrote: > On Thu, 21 Sep 2017 23:20:11 +0800 > Icenowy Zheng wrote: > >> 于 2017年9月21日 GMT+08:00 下午10:46:21, Jonathan Cameron 写到: >>> On Wed, 20 Sep 2017 23:18:07 +0800 >>> Icenowy Zheng wrote: >>> >>>> The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power >>> inputs: >>>> AC, USB and Battery. >>>> >>>> This patchset adds support for the AC and Battery supplies, which is >>> useful >>>> for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, >>> Pinebook). >>>> >>>> The USB supply is not yet supported in this patchset because it's not >>>> present on Pine series boards. >>>> >>>> In order to enable battery monitoring the ADC for battery is also >>> enabled >>>> for AXs. >>>> >>>> In order to enable battery monitoring the ADC for battery is also >>> enabled >>>> for AXP803. >>> >>> I'll go with the obvious question... >>> >>> Why an RFC rather than a standard patch submission? I'm not immediately >>> seeing what is controversial! >> >> Oh I am just not confident about this patchset, >> especially the IIO part. > > It all looks fine to me. I would imagine that, once everyone is > happy, this will go through the mfd tree, but Lee may have other ideas! > Small modifications to make but I definitely agree with Jonathan that you did not need to send an RFC. Quentin > Jonathan >> >>> >>> Jonathan >>> >>>> >>>> Icenowy Zheng (7): >>>> dt-bindings: add compatibles for AXP803 Battery/USB power supplies >>>> iio: adc: axp20x-adc: allow to skip ADC rate setup now >>>> iio: adc: axp20x-adc: add support for AXP803 >>>> power: supply: axp20x-battery: support AXP803 >>>> mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery >>>> arm64: allwinner: a64: add power supply nodes in AXP803 DTSI >>>> arm64: allwinner: a64: enable AC and Battery for Pine64 >>>> >>>> .../bindings/power/supply/axp20x_battery.txt | 1 + >>>> .../bindings/power/supply/axp20x_usb_power.txt | 1 + >>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ >>>> .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++ >>>> drivers/iio/adc/axp20x_adc.c | 114 >>> ++++++++++++++++++++- >>>> drivers/mfd/axp20x.c | 11 ++ >>>> drivers/power/supply/axp20x_battery.c | 88 >>> ++++++++++++++-- >>>> 7 files changed, 226 insertions(+), 12 deletions(-) >>>> >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Schulz Subject: Re: [RFC PATCH 0/7] AXP803 AC/Battery support Date: Mon, 25 Sep 2017 11:22:16 +0200 Message-ID: References: <20170920151814.22461-1-icenowy@aosc.io> <20170921154621.0000328d@huawei.com> <20170924153647.1d82e83c@archlinux> Reply-To: quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20170924153647.1d82e83c@archlinux> Content-Language: en-US List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Jonathan Cameron , Icenowy Zheng Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Jonathan Cameron , Maxime Ripard , Chen-Yu Tsai , Lee Jones , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Icenowy, On 24/09/2017 16:36, Jonathan Cameron wrote: > On Thu, 21 Sep 2017 23:20:11 +0800 > Icenowy Zheng wrote: >=20 >> =E4=BA=8E 2017=E5=B9=B49=E6=9C=8821=E6=97=A5 GMT+08:00 =E4=B8=8B=E5=8D= =8810:46:21, Jonathan Cameron =E5=86=99=E5=88= =B0: >>> On Wed, 20 Sep 2017 23:18:07 +0800 >>> Icenowy Zheng wrote: >>> =20 >>>> The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power = =20 >>> inputs: =20 >>>> AC, USB and Battery. >>>> >>>> This patchset adds support for the AC and Battery supplies, which is = =20 >>> useful =20 >>>> for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, =20 >>> Pinebook). =20 >>>> >>>> The USB supply is not yet supported in this patchset because it's not >>>> present on Pine series boards. >>>> >>>> In order to enable battery monitoring the ADC for battery is also =20 >>> enabled =20 >>>> for AXs. >>>> >>>> In order to enable battery monitoring the ADC for battery is also =20 >>> enabled =20 >>>> for AXP803. =20 >>> >>> I'll go with the obvious question... >>> >>> Why an RFC rather than a standard patch submission? I'm not immediately >>> seeing what is controversial! =20 >> >> Oh I am just not confident about this patchset, >> especially the IIO part. >=20 > It all looks fine to me. I would imagine that, once everyone is > happy, this will go through the mfd tree, but Lee may have other ideas! >=20 Small modifications to make but I definitely agree with Jonathan that you did not need to send an RFC. Quentin > Jonathan >> >>> >>> Jonathan >>> =20 >>>> >>>> Icenowy Zheng (7): >>>> dt-bindings: add compatibles for AXP803 Battery/USB power supplies >>>> iio: adc: axp20x-adc: allow to skip ADC rate setup now >>>> iio: adc: axp20x-adc: add support for AXP803 >>>> power: supply: axp20x-battery: support AXP803 >>>> mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery >>>> arm64: allwinner: a64: add power supply nodes in AXP803 DTSI >>>> arm64: allwinner: a64: enable AC and Battery for Pine64 >>>> >>>> .../bindings/power/supply/axp20x_battery.txt | 1 + >>>> .../bindings/power/supply/axp20x_usb_power.txt | 1 + >>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ >>>> .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++ >>>> drivers/iio/adc/axp20x_adc.c | 114 =20 >>> ++++++++++++++++++++- =20 >>>> drivers/mfd/axp20x.c | 11 ++ >>>> drivers/power/supply/axp20x_battery.c | 88 =20 >>> ++++++++++++++-- =20 >>>> 7 files changed, 226 insertions(+), 12 deletions(-) >>>> =20 >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel =20 >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >=20 >=20 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >=20 --=20 Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: quentin.schulz@free-electrons.com (Quentin Schulz) Date: Mon, 25 Sep 2017 11:22:16 +0200 Subject: [RFC PATCH 0/7] AXP803 AC/Battery support In-Reply-To: <20170924153647.1d82e83c@archlinux> References: <20170920151814.22461-1-icenowy@aosc.io> <20170921154621.0000328d@huawei.com> <20170924153647.1d82e83c@archlinux> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Icenowy, On 24/09/2017 16:36, Jonathan Cameron wrote: > On Thu, 21 Sep 2017 23:20:11 +0800 > Icenowy Zheng wrote: > >> ? 2017?9?21? GMT+08:00 ??10:46:21, Jonathan Cameron ??: >>> On Wed, 20 Sep 2017 23:18:07 +0800 >>> Icenowy Zheng wrote: >>> >>>> The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power >>> inputs: >>>> AC, USB and Battery. >>>> >>>> This patchset adds support for the AC and Battery supplies, which is >>> useful >>>> for the boards from Pine64 (Pine64, SoPine w/ baseboard model A, >>> Pinebook). >>>> >>>> The USB supply is not yet supported in this patchset because it's not >>>> present on Pine series boards. >>>> >>>> In order to enable battery monitoring the ADC for battery is also >>> enabled >>>> for AXs. >>>> >>>> In order to enable battery monitoring the ADC for battery is also >>> enabled >>>> for AXP803. >>> >>> I'll go with the obvious question... >>> >>> Why an RFC rather than a standard patch submission? I'm not immediately >>> seeing what is controversial! >> >> Oh I am just not confident about this patchset, >> especially the IIO part. > > It all looks fine to me. I would imagine that, once everyone is > happy, this will go through the mfd tree, but Lee may have other ideas! > Small modifications to make but I definitely agree with Jonathan that you did not need to send an RFC. Quentin > Jonathan >> >>> >>> Jonathan >>> >>>> >>>> Icenowy Zheng (7): >>>> dt-bindings: add compatibles for AXP803 Battery/USB power supplies >>>> iio: adc: axp20x-adc: allow to skip ADC rate setup now >>>> iio: adc: axp20x-adc: add support for AXP803 >>>> power: supply: axp20x-battery: support AXP803 >>>> mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery >>>> arm64: allwinner: a64: add power supply nodes in AXP803 DTSI >>>> arm64: allwinner: a64: enable AC and Battery for Pine64 >>>> >>>> .../bindings/power/supply/axp20x_battery.txt | 1 + >>>> .../bindings/power/supply/axp20x_usb_power.txt | 1 + >>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++ >>>> .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++ >>>> drivers/iio/adc/axp20x_adc.c | 114 >>> ++++++++++++++++++++- >>>> drivers/mfd/axp20x.c | 11 ++ >>>> drivers/power/supply/axp20x_battery.c | 88 >>> ++++++++++++++-- >>>> 7 files changed, 226 insertions(+), 12 deletions(-) >>>> >>> >>> >>> _______________________________________________ >>> linux-arm-kernel mailing list >>> linux-arm-kernel at lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo at vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com