From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Helge Deller" <deller@gmx.de>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-devel@nongnu.org, "Ilya Leoshkevich" <iii@linux.ibm.com>
Subject: Re: [PATCH] linux-user: Add translation for argument of msync()
Date: Thu, 15 Dec 2022 07:58:29 -0800 [thread overview]
Message-ID: <b2432b6a-ceef-647d-3e0f-ff7a7bdc0beb@linaro.org> (raw)
In-Reply-To: <165fbdfe-8e72-0ab7-727e-0f54df9957b3@linaro.org>
On 12/14/22 23:58, Philippe Mathieu-Daudé wrote:
>> --- a/linux-user/alpha/target_mman.h
>> +++ b/linux-user/alpha/target_mman.h
>> @@ -3,6 +3,10 @@
>>
>> #define TARGET_MADV_DONTNEED 6
>>
>> +#define TARGET_MS_ASYNC 1
>> +#define TARGET_MS_SYNC 2
>> +#define TARGET_MS_INVALIDATE 4
>> +
>> #include "../generic/target_mman.h"
>>
>> #endif
>> diff --git a/linux-user/generic/target_mman.h b/linux-user/generic/target_mman.h
>> index 1436a3c543..32bf1a52d0 100644
>> --- a/linux-user/generic/target_mman.h
>> +++ b/linux-user/generic/target_mman.h
>> @@ -89,4 +89,17 @@
>> #define TARGET_MADV_DONTNEED_LOCKED 24
>> #endif
>>
>> +
>> +#ifndef TARGET_MS_ASYNC
>> +#define TARGET_MS_ASYNC 1
>
> Hmm don't we want to keep the host flag instead?
>
> #define TARGET_MS_ASYNC MS_ASYNC
No. What if the host has an odd value, like Alpha.
r~
next prev parent reply other threads:[~2022-12-15 15:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 7:27 [PATCH] linux-user: Add translation for argument of msync() Helge Deller
2022-12-15 7:58 ` Philippe Mathieu-Daudé
2022-12-15 8:15 ` Helge Deller
2022-12-15 15:58 ` Richard Henderson [this message]
2022-12-15 20:58 ` Philippe Mathieu-Daudé
2022-12-15 23:23 ` Richard Henderson
2023-03-07 16:19 ` Laurent Vivier
2023-03-07 16:21 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2432b6a-ceef-647d-3e0f-ff7a7bdc0beb@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.