From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5129AC4167B for ; Tue, 29 Nov 2022 16:14:51 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CF8040691; Tue, 29 Nov 2022 17:14:50 +0100 (CET) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id C9F564067E for ; Tue, 29 Nov 2022 17:14:48 +0100 (CET) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 8062F49F for ; Tue, 29 Nov 2022 17:14:48 +0100 (CET) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 7F200704; Tue, 29 Nov 2022 17:14:48 +0100 (CET) Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id D4A0C61A; Tue, 29 Nov 2022 17:14:45 +0100 (CET) Message-ID: Date: Tue, 29 Nov 2022 17:14:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 0/4] lcore telemetry improvements Content-Language: en-US To: Robin Jarry , dev@dpdk.org References: <20221123102612.1688865-1-rjarry@redhat.com> <20221129153329.181652-1-rjarry@redhat.com> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= In-Reply-To: <20221129153329.181652-1-rjarry@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2022-11-29 16:33, Robin Jarry wrote: > This is a follow up on previous work by Kevin Laatz: > > http://patches.dpdk.org/project/dpdk/list/?series=24658&state=* > > This series is aimed at allowing DPDK applications to expose their CPU > usage stats in the DPDK telemetry under /eal/lcore/info. This is a much > more basic and naive approach which leaves the cpu cycles accounting > completely up to the application. > This seems like a reasonable approach to me. DPDK needs to have more OS-type constructs for a feature like this to be implemented, without application involvement. I would love for this to happen, but we aren't there yet. > For reference, I have implemented a draft patch in OvS to use > rte_lcore_register_usage_cb() and report the already available busy > cycles information. > > https://github.com/rjarry/ovs/commit/327db12c751be0375fcfed5e44b6065bcfb75c82 > > Changes since v2: > > - Fixed typos in docstrings. > - Used if (xxx != NULL) instead of if (xxx) test convention. > - Guarded against an unlikely race if rte_lcore_dump() is called by > a thread while another one calls rte_lcore_register_usage_cb(NULL). > - s/utilization/usage/ > - Fixed build on Windows. > > Changes since v1: > > - The cpuset field in telemetry is now a JSON list of CPU ids. > - Applications must now report their raw CPU cycles counts. The busyness > ratio and rate of change is left to external monitoring tools. > - Renamed show lcores -> dump_lcores in testpmd. > > Robin Jarry (4): > eal: add lcore info in telemetry > eal: allow applications to report their cpu cycles usage > testpmd: add dump_lcores command > testpmd: report lcore usage > > app/test-pmd/5tswap.c | 5 +- > app/test-pmd/cmdline.c | 3 + > app/test-pmd/csumonly.c | 6 +- > app/test-pmd/flowgen.c | 2 +- > app/test-pmd/icmpecho.c | 6 +- > app/test-pmd/iofwd.c | 5 +- > app/test-pmd/macfwd.c | 5 +- > app/test-pmd/macswap.c | 5 +- > app/test-pmd/noisy_vnf.c | 4 + > app/test-pmd/rxonly.c | 5 +- > app/test-pmd/shared_rxq_fwd.c | 5 +- > app/test-pmd/testpmd.c | 39 ++++++++- > app/test-pmd/testpmd.h | 14 +++- > app/test-pmd/txonly.c | 7 +- > lib/eal/common/eal_common_lcore.c | 131 +++++++++++++++++++++++++++++- > lib/eal/include/rte_lcore.h | 29 +++++++ > lib/eal/version.map | 1 + > 17 files changed, 242 insertions(+), 30 deletions(-) >