From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932887AbdDGK0u (ORCPT ); Fri, 7 Apr 2017 06:26:50 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:48890 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754097AbdDGK0l (ORCPT ); Fri, 7 Apr 2017 06:26:41 -0400 X-AuditID: b6c32a58-f79586d000001c40-a2-58e7695e9a55 Subject: Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs To: Smitha T Murthy Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, kamil@wypas.org, jtp.park@samsung.com, a.hajda@samsung.com, mchehab@kernel.org, pankaj.dubey@samsung.com, krzk@kernel.org, m.szyprowski@samsung.com From: Sylwester Nawrocki Message-id: Date: Fri, 07 Apr 2017 12:26:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-version: 1.0 In-reply-to: <1491559409.15698.1237.camel@smitha-fedora> Content-type: text/plain; charset=utf-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLKsWRmVeSWpSXmKPExsWy7bCmlm5c5vMIg49LBS1urTvHanFk7VUm i5kn2lktzp/fwG5xtukNu8Wmx9dYLS7vmsNm0bNhK6vF2iN32S2WbfrDZLFo6xd2i7t7tjE6 8HhsWtXJ5rF5Sb1H35ZVjB6fN8l5XDnSyB7AGsVlk5Kak1mWWqRvl8CV8W33Y5aCtewVvxZN YWtg/MDaxcjJISFgIrGi7ScLhC0mceHeerYuRi4OIYGljBLbOt8yQTjtTBLL/56A63jy/g8r RGIOo8SEGYuhnPuMEs37zzODVAkLeEscaDjFBGKLCGhJ/Nz5AqyIWWAmk8SNviVsIAk2AUOJ 3qN9jCA2r4CdxJ9bs9hBbBYBVYmtH1+CDRIViJC4PmcLVI2gxI/J94CO5eDgFLCQOLU2ECTM LGAl8exfKyuELS+xec1bZpBdEgKn2CX+f3vAClIvISArsekAM8QHLhLr7hxnh7CFJV4d3wJl S0v8XXqLEaK3n1HixJpmKGcGo8Sd9glMEFXWEoePX4TaxifR+/sJE8QCXomONiGIEg+JB/cu QoPLUWL2FVhwbWeSaFn3h3ECo/wsJP/MQvLELCRPLGBkXsUollpQnJueWmxaYKJXnJhbXJqX rpecn7uJEZyItCJ2MP6bEXSIUYCDUYmHN+Pgswgh1sSy4srcQ4wSHMxKIrxCwDQmxJuSWFmV WpQfX1Sak1p8iFGag0VJnFd95bUIIYH0xJLU7NTUgtQimCwTB6dUA+Ohzdr1tYv0l3xfqeR2 7lR5p2/DsmNXvkpds7XzVTjOo3krLyTC4uDsqG8sHrNYRVwv13Hr3E4svPr/2mfbxoDVnl17 m55umPFjredGv9vBIetYs9Wy/2jtPKRhfLF50inOjXd2CVczi598fOgik7YVY8hlw7//mmu3 X7ayZA2pvh5buK6GebcSS3FGoqEWc1FxIgA4PXF4QAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsVy+t9jQd3YzOcRBtPvS1ncWneO1eLI2qtM FjNPtLNanD+/gd3ibNMbdotNj6+xWlzeNYfNomfDVlaLtUfuslss2/SHyWLR1i/sFnf3bGN0 4PHYtKqTzWPzknqPvi2rGD0+b5LzuHKkkT2ANcrNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJ IS8xN9VWKULXNyRISaEsMacUyDMyQAMOzgHuwUr6dgluGd92P2YpWMte8WvRFLYGxg+sXYyc HBICJhJP3v+BssUkLtxbzwZiCwnMYpTY21gLYT9klDh+JB7EFhbwljjQcIoJxBYR0JL4ufMF UC8XUM12Jomm/8vAmpkFZjJJ7L5nB2KzCRhK9B7tYwSxeQXsJP7cmsUOYrMIqEps/fiSGcQW FYiQeNi5ix2iRlDix+R7LF2MHBycAhYSp9YGQow0k/jy8jArhC0vsXnNW+YJjEBHInTMQlI2 C0nZAkbmVYwSqQXJBcVJ6blGeanlesWJucWleel6yfm5mxjBEflMegfj4V3uhxgFOBiVeHg9 Hj+JEGJNLCuuzD3EKMHBrCTCG5PyPEKINyWxsiq1KD++qDQntfgQoynQHxOZpUST84HJIq8k 3tDE3MTc2MDC3NLSxEhJnLdx9rNwIYH0xJLU7NTUgtQimD4mDk6pBkbOk+/iZ56fsmaSGve9 dItFOrMvcHC2Mn5s/nCaadqz2zzLO78X8fvEe7jLSFVs/nbWZ3dC5VKeO5GWZfVlcq5O5ztP nTvScYX1/WPlv/pXWnilJF2ucv63OyLymNP9SMI3/c4eNzHdgs2XXv054LlsmuSKqXNUaqbl q0qJZU7azK32q2ZqxXolluKMREMt5qLiRADtmWA23gIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170407102637epcas5p40c483536d965e4337f576d88ea4fbf36 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170406061027epcas5p2628e0a8e0fd76e2e267fad3ea1209f65 X-RootMTR: 20170406061027epcas5p2628e0a8e0fd76e2e267fad3ea1209f65 References: <1491459105-16641-1-git-send-email-smitha.t@samsung.com> <1491459105-16641-13-git-send-email-smitha.t@samsung.com> <1491559409.15698.1237.camel@smitha-fedora> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/07/2017 12:03 PM, Smitha T Murthy wrote: >>> +``V4L2_CID_MPEG_VIDEO_HEVC_LF`` >>> + Indicates loop filtering. Control ID 0 indicates loop filtering >>> + is enabled and when set to 1 indicates no filter. >> >> "Setting this control to 0 enables loop filtering, setting this control >> to 1 disables loop filtering." ? >> >> Couldn't the meaning be inverted, so setting the control to 0 disables >> the loop filtering? >> >>>From register point of view, this control value needs be 0 to enable > loop filtering. OK, this is true for our specific hardware/firmware implementation. In general, for this user space interface I would rather define that boolean control so value 1 enables LF and value 0 disables LF. The driver could simply negate the value when writing registers. BTW we might need to specify type of the control here as Hans suggested commenting on other control. -- Regards, Sylwester From mboxrd@z Thu Jan 1 00:00:00 1970 From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Fri, 07 Apr 2017 12:26:31 +0200 Subject: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs In-Reply-To: <1491559409.15698.1237.camel@smitha-fedora> References: <1491459105-16641-1-git-send-email-smitha.t@samsung.com> <1491459105-16641-13-git-send-email-smitha.t@samsung.com> <1491559409.15698.1237.camel@smitha-fedora> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/07/2017 12:03 PM, Smitha T Murthy wrote: >>> +``V4L2_CID_MPEG_VIDEO_HEVC_LF`` >>> + Indicates loop filtering. Control ID 0 indicates loop filtering >>> + is enabled and when set to 1 indicates no filter. >> >> "Setting this control to 0 enables loop filtering, setting this control >> to 1 disables loop filtering." ? >> >> Couldn't the meaning be inverted, so setting the control to 0 disables >> the loop filtering? >> >>>From register point of view, this control value needs be 0 to enable > loop filtering. OK, this is true for our specific hardware/firmware implementation. In general, for this user space interface I would rather define that boolean control so value 1 enables LF and value 0 disables LF. The driver could simply negate the value when writing registers. BTW we might need to specify type of the control here as Hans suggested commenting on other control. -- Regards, Sylwester