Re: [PATCH 1/2] mt76: mt7921: reduce log severity levels for informative messages

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 23/06/22 02:35, sean.wang@mediatek.com ha scritto:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> Use dev_info instead for the informative messages.
> 
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
>   drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> index eb1bfb682e02..2ce3a833176e 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c
> @@ -740,7 +740,7 @@ void mt7921_mac_reset_work(struct work_struct *work)
>   	struct mt76_connac_pm *pm = &dev->pm;
>   	int i;
>   
> -	dev_err(dev->mt76.dev, "chip reset\n");
> +	dev_info(dev->mt76.dev, "chip reset\n");

Since this function is normally expected to be called and this message is
describing the wanted flow and/or this worker function starting, I'd say
that this is not a really important information anyway...

What about changing that one to a dev_dbg() instead?

Regards,
Angelo

>   	dev->hw_full_reset = true;
>   	ieee80211_stop_queues(hw);
>