From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1428C433ED for ; Wed, 21 Apr 2021 19:59:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87BF1601FD for ; Wed, 21 Apr 2021 19:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245588AbhDUT77 (ORCPT ); Wed, 21 Apr 2021 15:59:59 -0400 Received: from namei.org ([65.99.196.166]:48254 "EHLO mail.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236274AbhDUT76 (ORCPT ); Wed, 21 Apr 2021 15:59:58 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.namei.org (Postfix) with ESMTPS id 59035C6B; Wed, 21 Apr 2021 19:55:33 +0000 (UTC) Date: Thu, 22 Apr 2021 05:55:33 +1000 (AEST) From: James Morris To: Greg Kroah-Hartman cc: linux-kernel@vger.kernel.org, Wenwen Wang , Adam Radford , "Martin K . Petersen" Subject: Re: [PATCH 189/190] Revert "scsi: 3w-9xxx: fix a missing-check bug" In-Reply-To: <20210421130105.1226686-190-gregkh@linuxfoundation.org> Message-ID: References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-190-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021, Greg Kroah-Hartman wrote: > This reverts commit c9318a3e0218bc9dacc25be46b9eec363259536f. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Wenwen Wang > Cc: Adam Radford > Cc: Martin K. Petersen > Signed-off-by: Greg Kroah-Hartman The original patch here looks valid and necessary. Please un-revert. Reviewed-by: James Morris > --- > drivers/scsi/3w-9xxx.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c > index b96e82de4237..4c5d4ea8a592 100644 > --- a/drivers/scsi/3w-9xxx.c > +++ b/drivers/scsi/3w-9xxx.c > @@ -886,11 +886,6 @@ static int twa_chrdev_open(struct inode *inode, struct file *file) > unsigned int minor_number; > int retval = TW_IOCTL_ERROR_OS_ENODEV; > > - if (!capable(CAP_SYS_ADMIN)) { > - retval = -EACCES; > - goto out; > - } > - > minor_number = iminor(inode); > if (minor_number >= twa_device_extension_count) > goto out; > -- > 2.31.1 > -- James Morris