All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH 6/6] RDMA/ulp: Use dev_name instead of ibdev->name
Date: Wed, 26 Sep 2018 13:18:27 +0000	[thread overview]
Message-ID: <b28f3b86-0417-e96a-3764-a65fac76290b@intel.com> (raw)
In-Reply-To: <20180920224227.9988-7-jgg@ziepe.ca>

On 9/20/2018 6:42 PM, Jason Gunthorpe wrote:
> diff --git a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> index 15711dcc6f5856..d119d9afa845a7 100644
> --- a/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> +++ b/drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
> @@ -888,7 +888,8 @@ static void opa_vnic_event(struct ib_event_handler *handler,
>   		return;
>   
>   	c_dbg("OPA_VNIC received event %d on device %s port %d\n",
> -	      record->event, record->device->name, record->element.port_num);
> +	      record->event, dev_name(&record->device->dev),
> +	      record->element.port_num);

Looks fine.

> diff --git a/include/rdma/rdma_vt.h b/include/rdma/rdma_vt.h
> index 496f31ac9d8421..db4739eb253e86 100644
> --- a/include/rdma/rdma_vt.h
> +++ b/include/rdma/rdma_vt.h
> @@ -427,7 +427,7 @@ struct rvt_dev_info {
>    */
>   static inline const char *rvt_get_ibdev_name(const struct rvt_dev_info *rdi)
>   {
> -	return rdi->ibdev.name;
> +	return dev_name(&rdi->ibdev.dev);
>   }
>   
>   static inline struct rvt_pd *ibpd_to_rvtpd(struct ib_pd *ibpd)
> 

I think this would have been better to be included in the other patch. 
This isn't really "ulp" related.

Codewise I'm OK with this.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>

      parent reply	other threads:[~2018-09-26 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 22:42 [PATCH 6/6] RDMA/ulp: Use dev_name instead of ibdev->name Jason Gunthorpe
2018-09-21 16:44 ` Steve Wise
2018-09-24  6:21 ` Sagi Grimberg
2018-09-26 13:18 ` Dennis Dalessandro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b28f3b86-0417-e96a-3764-a65fac76290b@intel.com \
    --to=dennis.dalessandro@intel.com \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.