From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24F96C43215 for ; Wed, 27 Nov 2019 10:40:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0B6F2071E for ; Wed, 27 Nov 2019 10:40:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="kWIzEDNT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726591AbfK0Kk4 (ORCPT ); Wed, 27 Nov 2019 05:40:56 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:45798 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727141AbfK0Kjp (ORCPT ); Wed, 27 Nov 2019 05:39:45 -0500 Received: from localhost (mailhub1-ext [192.168.12.233]) by localhost (Postfix) with ESMTP id 47NHMf0FdNz9tytq; Wed, 27 Nov 2019 11:39:42 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=kWIzEDNT; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id jwb7r-R0sh0X; Wed, 27 Nov 2019 11:39:41 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 47NHMd6J22z9tytm; Wed, 27 Nov 2019 11:39:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1574851181; bh=YAoJUkpNn9+eoDMhzZkqkbOPlQd5fIZwb21M8VPkm7I=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=kWIzEDNTFSkjgnsk54jyYFFOgrsYvv+iXZmsqpRfXC3mdfTIhVux8bxFN4dNsZ0w7 rxI3Iqz/WDsbIX0MRMy9IzIHrwFZfsGK7fzoRzMD1KF1CWSJ88uom94BF2M3QmnDaC riWbAHoEy0zqCKc0gKX8909G5oG3aPcd4Ulf2ucM= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id C6DAB8B847; Wed, 27 Nov 2019 11:39:42 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id Z-yqxHs69KXl; Wed, 27 Nov 2019 11:39:42 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 488B18B84E; Wed, 27 Nov 2019 11:39:42 +0100 (CET) Subject: Re: Boot failure with 5.4-rc5, bisected to 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO descriptors") To: Linus Walleij Cc: linux-spi , Mark Brown , Fabio Estevam , "open list:GPIO SUBSYSTEM" References: <1efb797c-e3c1-25a4-0e81-78b5bbadb355@c-s.fr> <3c79a8b9-65e4-bfc9-d718-b8530fe1e672@c-s.fr> <582b5ccf-8993-6345-94d1-3c2fc94e4d4f@c-s.fr> From: Christophe Leroy Message-ID: Date: Wed, 27 Nov 2019 11:39:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Le 27/11/2019 à 11:02, Linus Walleij a écrit : > On Wed, Nov 27, 2019 at 10:34 AM Christophe Leroy > wrote: > >> In the meantime, I have tried changing "gpios" by "cs-gpios" in the >> device tree, and I get the following warning: > (...) >> [ 3.156654] WARNING: CPU: 0 PID: 1 at drivers/spi/spi-fsl-spi.c:716 >> fsl_spi_cs_control+0x64/0x7c > > That should be this one: > > if (WARN_ON_ONCE(!pinfo->immr_spi_cs)) > return; > > That happens when spi->cs_gpiod is NULL so the > chipselect isn't found and assigned, and the code > goes on to check the native CS and find that this isn't > available either and issues the warning. That's in spi_add_device(), it is spi->cs_gpio and not spi->cs_gpiod which is assigned, so spi->cs_gpiod remains NULL. Christophe > > That one is a bit puzzling because I know we have this > working with other "cs-gpios" consumer drivers working > just fine. :/ > > Yours, > Linus Walleij >