From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3] net/i40e: log when provided RSS key is
	not valid
Date: Tue, 26 Mar 2019 14:51:39 +0000
Message-ID: <b2986dce-4f68-66f3-3b6d-2e71314ede1b@intel.com>
References: <1553224009-36918-1-git-send-email-wei.zhao1@intel.com>
 <1553589324-16990-1-git-send-email-wei.zhao1@intel.com>
 <039ED4275CED7440929022BC67E7061153354AD5@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "stable@dpdk.org" <stable@dpdk.org>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Zhao1, Wei" <wei.zhao1@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <039ED4275CED7440929022BC67E7061153354AD5@SHSMSX103.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/26/2019 12:41 PM, Zhang, Qi Z wrote:
> 
> 
>> -----Original Message-----
>> From: Zhao1, Wei
>> Sent: Tuesday, March 26, 2019 4:35 PM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
>> Subject: [PATCH v3] net/i40e: log when provided RSS key is not valid
>>
>> A log message is required when provided RSS key is not valid so that driver will
>> use the default RSS key.
>>
>> Fixes: ecad87d22383 ("net/i40e: move RSS to flow API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>> Tested-by: Peng Yuan <yuan.peng@intel.com>
>>
>> ---
>>
>> v2:
>> update dev info message
>>
>> v3:
>> update log info
>> ---
>>  drivers/net/i40e/i40e_ethdev.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>> index 63ec813..5472312 100644
>> --- a/drivers/net/i40e/i40e_ethdev.c
>> +++ b/drivers/net/i40e/i40e_ethdev.c
>> @@ -12745,6 +12745,7 @@ i40e_config_rss_filter(struct i40e_pf *pf,
>>  		rss_conf.rss_key = (uint8_t *)rss_key_default;
>>  		rss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *
>>  							sizeof(uint32_t);
>> +		PMD_DRV_LOG(INFO, "No perfect RSS key config for i40e, using
>> +default\n");
> 
> s/perfect/valid to align with the title
> 
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> 
> Applied to dpdk-next-net-intel.

Message carried into next line to keep line length < 80 while merging next-net:

    PMD_DRV_LOG(INFO,
            "No valid RSS key config for i40e, using default\n");