From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yizhuo Zhai <yzhai003@ucr.edu>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Zhiyun Qian <zhiyunq@cs.ucr.edu>, Chengyu Song <csong@cs.ucr.edu>
Subject: Re: Potential NULL pointer deference in net: sched
Date: Mon, 7 Oct 2019 14:20:21 -0700 [thread overview]
Message-ID: <b2997ffb-728a-b4ee-abfa-2c9fe9869d8b@gmail.com> (raw)
In-Reply-To: <CABvMjLRuGnatUxBEMKpXWGNJnAjNMiCXQ7Ce88ejuuJJnENR+g@mail.gmail.com>
On 10/7/19 2:08 PM, Yizhuo Zhai wrote:
> Hi All:
>
> net/sched/sch_mq.c:
> Inside function mq_dump_class(), mq_queue_get() could return NULL,
> however, the return value of dev_queue is not checked and get used.
> This could potentially be unsafe.
>
>
Not really.
mq_dump_class() is called by a layer that made sure the @cl argument
was not complete garbage.
prev parent reply other threads:[~2019-10-07 21:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 21:08 Potential NULL pointer deference in net: sched Yizhuo Zhai
2019-10-07 21:20 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2997ffb-728a-b4ee-abfa-2c9fe9869d8b@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=csong@cs.ucr.edu \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yzhai003@ucr.edu \
--cc=zhiyunq@cs.ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.